Skip to content

Add tl localized messages#10269

Merged
Gudahtt merged 1 commit intodevelopfrom
add-tl-localized-messages
Feb 25, 2021
Merged

Add tl localized messages#10269
Gudahtt merged 1 commit intodevelopfrom
add-tl-localized-messages

Conversation

@Gudahtt
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt commented Jan 23, 2021

These translations were provided by Lionbridge.

@Gudahtt Gudahtt requested a review from a team as a code owner January 23, 2021 05:08
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jan 23, 2021

Builds ready [657dd94]
Page Load Metrics (697 ± 49 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint528769115
domContentLoaded52293869510249
load52494069710249
domInteractive52293869510249

@Gudahtt Gudahtt force-pushed the add-tl-localized-messages branch from 657dd94 to f0e71c0 Compare February 2, 2021 14:49
@Gudahtt
Copy link
Copy Markdown
Member Author

Gudahtt commented Feb 2, 2021

This PR has been rebased onto develop to ensure that the yourSigRequested message was not present (it was removed in #10300).

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Feb 2, 2021

Builds ready [f0e71c0]
Page Load Metrics (570 ± 27 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint45755995
domContentLoaded3586565685627
load3596585705627
domInteractive3586565685627

@Gudahtt Gudahtt force-pushed the add-tl-localized-messages branch from f0e71c0 to 68d65f9 Compare February 15, 2021 22:00
@Gudahtt
Copy link
Copy Markdown
Member Author

Gudahtt commented Feb 15, 2021

This has been rebased on develop, and the unused message swapGetQuotes has been removed.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Feb 15, 2021

Builds ready [68d65f9]
Page Load Metrics (600 ± 25 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint45725984
domContentLoaded4136835985225
load4156846005225
domInteractive4136835985225

@Gudahtt Gudahtt force-pushed the add-tl-localized-messages branch from 68d65f9 to 582ebc6 Compare February 23, 2021 14:19
@Gudahtt
Add tl localized messages
ca119c9 
These translations were provided by Lionbridge.
@Gudahtt Gudahtt force-pushed the add-tl-localized-messages branch from 582ebc6 to ca119c9 Compare February 23, 2021 14:20
@Gudahtt
Copy link
Copy Markdown
Member Author

Gudahtt commented Feb 23, 2021

I've just rebased this again to resolve conflicts (two messages were removed)

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Feb 23, 2021

Builds ready [ca119c9]
Page Load Metrics (595 ± 32 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint50796194
domContentLoaded3847005946732
load3867015956732
domInteractive3847005936732

@Gudahtt
Copy link
Copy Markdown
Member Author

Gudahtt commented Feb 25, 2021

We were unable to find reviewers for these translations, so we'll have to go without, and rely upon reports to point out any mistakes or opportunities for improvement. I've double-checked some of the more crucial messages using Google Translate.

@Gudahtt Gudahtt merged commit 3181eca into develop Feb 25, 2021
@Gudahtt Gudahtt deleted the add-tl-localized-messages branch February 25, 2021 03:24
@github-actions github-actions bot locked and limited conversation to collaborators Feb 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@NiranjanaBinoy NiranjanaBinoy Awaiting requested review from NiranjanaBinoy

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Gudahtt @metamaskbot