use native currency in asset row#10413
Merged
brad-decker merged 2 commits intodevelopfrom Feb 11, 2021
Merged
Conversation
33e9fb9 to
6d1b7ca
Compare
Collaborator
Builds ready [6d1b7ca]
Page Load Metrics (620 ± 36 ms)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #9701
Explanation:
The asset-row component in the send page had a method called 'renderETH' which used the 'userPreferencedCurrencyDisplay' but hardcoded ETH as the symbol/icon. This PR changes the nomenclature and implementation to consider the nativeCurrency.
I also noticed that when starting up the background there is nothing that initializes the nativeCurrency (it defaults to ETH, so even if you have a custom network with symbol setup correctly you'd get ETH showing up). I discovered this during development as reloading the application after changes and then refreshing my browser (expanded view) would result in 'ETH' showing back up until I clicked my custom network again in the network selector.