Fix BatchRequest.execute() multiple window issue#10423
Merged
Gudahtt merged 3 commits intoMetaMask:developfrom Feb 11, 2021
Merged
Fix BatchRequest.execute() multiple window issue#10423Gudahtt merged 3 commits intoMetaMask:developfrom
Gudahtt merged 3 commits intoMetaMask:developfrom
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Gudahtt
requested changes
Feb 11, 2021
Member
Gudahtt
left a comment
There was a problem hiding this comment.
Thanks for the contribution! I noticed this problem recently as well, and had been meaning to create an issue for it.
This solution looks good overall! I just had one suggested change.
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Gudahtt
previously approved these changes
Feb 11, 2021
Contributor
Author
I figured it was too easy for there not to be something lol, just added a commit, lmk if there's anything else. Thanks |
Gudahtt
approved these changes
Feb 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #10422
Explanation: The issue describes the problem with a sandbox, but this PR fixes multiple windows being opened on BatchRequest.execute()