Merged
Conversation
Collaborator
Builds ready [f987e26]
Page Load Metrics (605 ± 56 ms)
|
Gudahtt
reviewed
Feb 25, 2021
b06b0ea to
c96db31
Compare
Collaborator
Builds ready [c96db31]
Page Load Metrics (648 ± 40 ms)
|
Gudahtt
reviewed
Feb 25, 2021
| useEffect(() => { | ||
| const environmentType = getEnvironmentType(); | ||
| // If the number of pending confirmations reduces to zero when the user | ||
| // is in the fullscreen or popup UI, return them to the default route. |
Member
There was a problem hiding this comment.
Nit: This comment should probably be updated since this now applies to the notification UI as well
ui/app/store/actions.js
Outdated
| const { pendingApprovals } = await forceUpdateMetamaskState(dispatch); | ||
| if (Object.values(pendingApprovals).length === 0) { | ||
| dispatch(closeCurrentNotificationWindow()); | ||
| dispatch(closeNotificationWindow()); |
Member
There was a problem hiding this comment.
What does this function do 🤔
Edit: To expand on this (sorry I was in a meeting when I wrote this 😅 ), it looks like this is dead code. It dispatches an action that doesn't do anything.
Contributor
Author
There was a problem hiding this comment.
haha when i read it i was like "doh i used the wrong function" -- i added a commit to remove the dead code.
c96db31 to
5b3341f
Compare
Collaborator
Builds ready [012c720]
Page Load Metrics (674 ± 38 ms)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: QA issues four with wallet_addEthereumChain
The alternative solution to the third bullet is to wait for promisifedBackground.getState instead of using redux's getState... but not sure what kind of impact that'll have on all the other confirmations.