Merged
Conversation
Member
Author
|
This depends upon #10391 |
kumavis
previously approved these changes
Feb 8, 2021
Collaborator
Builds ready [c7e9fea]
Page Load Metrics (572 ± 25 ms)
|
de1aa5c to
a8ab8e8
Compare
c7e9fea to
32513b7
Compare
brad-decker
previously approved these changes
Feb 8, 2021
Base automatically changed from
use-string-literals-for-transaction-category-messages
to
develop
February 8, 2021 16:07
The base branch was changed.
The `transferFrom` localized message has been unused at least since the transaction list redesign was implemented. The `transactionCategory` has been used directly as the localized message key since then. For most of the other categories this was fine, but for `transferFrom` the message differs slightly from the category (the category is `transferfrom`, with a lower-cased 'f').
6412e86 to
aa6cb9a
Compare
Collaborator
Builds ready [aa6cb9a]
Page Load Metrics (582 ± 45 ms)
|
brad-decker
approved these changes
Feb 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
transferFromlocalized message has been unused at least since the transaction list redesign was implemented. ThetransactionCategoryhas been used directly as the localized message key since then. For most of the other categories this was fine, but fortransferFromthe message differs slightly from the category (the category istransferfrom, with a lower-cased 'f').I am not yet sure how to manually test this. I only discovered this incidentally via the
verify-localesscript.