Skip to content

Storybook i18n party#10382

Merged
kumavis merged 1 commit intodevelopfrom
storybook-i18n-party
Feb 8, 2021
Merged

Storybook i18n party#10382
kumavis merged 1 commit intodevelopfrom
storybook-i18n-party

Conversation

@kumavis
Copy link
Copy Markdown
Member

@kumavis kumavis commented Feb 5, 2021

made a rotating locale mode, good for checking locale coverage + ensuring components look good with all translation texts

@kumavis kumavis changed the base branch from develop to storybook-i18n February 5, 2021 14:31
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [bc9b40d]
Page Load Metrics (786 ± 49 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaintNaNNaNNaNNaNNaN
domContentLoaded48996578510249
load49196678610249
domInteractive48996478410149

Base automatically changed from storybook-i18n to develop February 6, 2021 02:28
@kumavis kumavis force-pushed the storybook-i18n-party branch from bc9b40d to daeeb76 Compare February 6, 2021 03:26
@kumavis kumavis force-pushed the storybook-i18n-party branch from daeeb76 to 4afa9a6 Compare February 6, 2021 03:30
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [4afa9a6]
Page Load Metrics (1867 ± 115 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaintNaNNaNNaNNaNNaN
domContentLoaded143022831847247118
load146022871867240115
domInteractive143022821846247118

@kumavis kumavis marked this pull request as ready for review February 6, 2021 04:04
@kumavis kumavis requested a review from a team as a code owner February 6, 2021 04:04
@kumavis kumavis requested a review from brad-decker February 6, 2021 04:04
@kumavis
Copy link
Copy Markdown
Member Author

kumavis commented Feb 6, 2021

you can see it working on this component, though most locales are missing the majority of text
click the star icon on the toolbar to activate the party mode
hindi (hi) has full text available for this component
https://242298-42009758-gh.circle-artifacts.com/0/storybook/index.html?path=/story/feecard--with-all-props

Copy link
Copy Markdown
Contributor

@brad-decker brad-decker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweeeeeet! LGTM

@kumavis kumavis merged commit 1e086ae into develop Feb 8, 2021
@kumavis kumavis deleted the storybook-i18n-party branch February 8, 2021 15:45
@github-actions github-actions bot locked and limited conversation to collaborators Feb 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants