Update zh_CN translation#9388
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
@Gudahtt I believe this is a merge-ready version |
fix incorrect translation
|
@arisac: Thanks for the contribution! I'll find somebody to review this as soon as the conflicts are resolved. We recently added JSON sorting to our formatter, so now there are many conflicts. Would you mind rebasing this onto |
@Gudahtt thanks for notify.I've done rebase and solved conflicts. |
|
Thanks again @arisac but something went wrong in your attempt to rebase. You've now duplicated ~56 commits from Could you check the "Allow edits from maintainers" checkbox on this PR? (see here: https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/allowing-changes-to-a-pull-request-branch-created-from-a-fork ). That would give me permission to fix things up myself. |
|
@arisac Thanks for granting access! I've just rebased your initial 5 commits onto |
Three messages added on this branch were unused by MetaMask. They have been removed.
|
I noticed that 3 messages were unused, so I removed them in c2153dc |
A few changes were made during the last attempt to update this branch. They were unintentionally discarded when this branch was rebased. Those changes have now been restored.
|
Ok that was my last update 😅 I had taken a closer look at your changes, and realized you had made a bunch of changes in that last attempt to update this branch. They were discarded when I rebased just the first 5 commits. I've just restored them all just as you had them. |
|
Thank you and sorry for the trouble, that was quite a lot work. |
# Solve Conflicts: # app/_locales/zh_CN/messages.json
|
I'm currently adding new translation strings to this PR. will update soon. |
|
I've updated this PR to sync with the latest develop branch. |
Solve Conflicts: # app/_locales/zh_CN/messages.json
remove unused strings add new strings
|
Hi @arisac, thank you for creating this monumental PR. Do you think you'd be willing to rebase it one more time? We recently received some more resources for translation-related work, and can finally review this properly. 很对不起我们花了这么长时间。🙇🏼♂️ |
Added new translation strings # Fixed Conflicts: # app/_locales/zh_CN/messages.json
|
@rekmarks done with new strings added. I saw ci/circleci: test-e2e-firefox is getting a failed result due to a timeout. |
|
@DDDDDanica, I (or someone else at MetaMask) can make you something by tomorrow! @arisac, if you created any comparison files while making this, please do let us know. |
|
@DDDDDanica @rekmarks I've uploaded the diff file to https://github.com/arisira/metamask-extension/blob/diff/en-zh_CN.diff using I removed description key from my translation file since it is not needed for translation, by removing the key, it also helps to diff the translation with the English file because it will pop up in the diff. And also I've noticed #9772 changed the |
app/_locales/zh_CN/messages.json
Outdated
| }, | ||
| "accountSelectionRequired": { | ||
| "message": "您需要选择一个账户 ！" | ||
| "message": "需要选择一个账户 ！" |
There was a problem hiding this comment.
In the doc translation, we can add 您 to make the sentence as a whole,
There was a problem hiding this comment.
We need to keep 您 actually from the context
There was a problem hiding this comment.
Thank you for the guideline. I've updated 你 with 您 in all strings on e86b5da
| "message": "资产" | ||
| }, | ||
| "attemptToCancel": { | ||
| "message": "想要取消吗？" |
There was a problem hiding this comment.
I actually prefer "想要取消吗？", which is more user friendly ~
app/_locales/zh_CN/messages.json
Outdated
| }, | ||
| "attemptToCancelDescription": { | ||
| "message": "确认提交该操作无法保证能够成功取消您的原始交易。如果取消成功，您将被收取上述交易费用。" | ||
| "message": "确认提交该操作无法保证能够成功取消你的原始交易。如取消成功，你将被收取上述交易费。" |
There was a problem hiding this comment.
In the translation doc we tend to use 您 to make it more formal and respectful
app/_locales/zh_CN/messages.json
Outdated
| }, | ||
| "browserNotSupported": { | ||
| "message": "您的浏览器不支持该功能…" | ||
| "message": "你的浏览器不支持该功能…" |
There was a problem hiding this comment.
"message": "您的浏览器不支持该功能。。。"
app/_locales/zh_CN/messages.json
Outdated
| }, | ||
| "accessingYourCamera": { | ||
| "message": "正在获取相机使用权限..." | ||
| "message": "正在访问相机..." |
There was a problem hiding this comment.
正在获取您的相机。。。
- you need to keep "you" from original context
- you need to use chinese punctuation ~
There was a problem hiding this comment.
All ... is updated with the Chinese punctuation …… in e86b5da
app/_locales/zh_CN/messages.json
Outdated
| "message": "仅在主网（mainnet）上提供" | ||
| }, | ||
| "onlyConnectTrust": { | ||
| "message": "只连接你信任的网站。" |
app/_locales/zh_CN/messages.json
Outdated
| "message": "“$1”会关闭此标签，直接回到 $2" | ||
| }, | ||
| "onlyAddTrustedNetworks": { | ||
| "message": "恶意的 Ethereum 以太坊网络提供商可以伪造区块链状态，并记录你的网络活动。只添加你信任的自定义网络。" |
app/_locales/zh_CN/messages.json
Outdated
| "message": "保证数额" | ||
| }, | ||
| "swapAmountReceivedInfo": { | ||
| "message": "这是你将收到的最低数额。你也可能会收到更多，这取决于滑点。" |
There was a problem hiding this comment.
你也可能会收到更多，这取决于滑点 => 根据滑点值， 您可能会收到更多。
app/_locales/zh_CN/messages.json
Outdated
| "message": "你还需 $1 $2 来完成这笔兑换" | ||
| }, | ||
| "swapBetterQuoteAvailable": { | ||
| "message": "有一个更好的报价可用" |
app/_locales/zh_CN/messages.json
Outdated
| "message": "这是预估的用于完成你的兑换所使用的网络手续费。实际数额可能会根据网络条件而变化。" | ||
| }, | ||
| "swapFailedErrorDescription": { | ||
| "message": "你的资金是安全的，仍然可以在你的钱包中使用。" |
solve Conflicts: # app/_locales/zh_CN/messages.json
|
rebased with the latested develop branch with 73bc553 since one string was removed from the English file: |
|
@DDDDDanica request for review. |
DDDDDanica
left a comment
There was a problem hiding this comment.
All looks good to me 👍
rekmarks
left a comment
There was a problem hiding this comment.
With @DDDDDanica's approval, I'm going to merge this.
Thank you so much for taking the time to do this @arisac, and thank you @DDDDDanica for reviewing!
No description provided.