Skip to content

Remove unused confirmTransaction state#10396

Merged
Gudahtt merged 1 commit intodevelopfrom
remove-unused-confirm-transaction-action
Feb 8, 2021
Merged

Remove unused confirmTransaction state#10396
Gudahtt merged 1 commit intodevelopfrom
remove-unused-confirm-transaction-action

Conversation

@Gudahtt
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt commented Feb 8, 2021

The confirmTransaction Redux slice had a lot of unused state and action creators. They have all been removed.

@Gudahtt
Copy link
Copy Markdown
Member Author

Gudahtt commented Feb 8, 2021

This depends upon #10395

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [14b48df]
Page Load Metrics (1171 ± 89 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaintNaNNaNNaNNaNNaN
domContentLoaded8411578116718790
load8421580117118689
domInteractive8401577116718790

@Gudahtt Gudahtt force-pushed the fix-transfer-from-localized-message branch from c7e9fea to 32513b7 Compare February 8, 2021 13:06
@Gudahtt Gudahtt force-pushed the remove-unused-confirm-transaction-action branch from 14b48df to 1a74ff9 Compare February 8, 2021 13:06
@Gudahtt Gudahtt force-pushed the fix-transfer-from-localized-message branch from 6412e86 to aa6cb9a Compare February 8, 2021 16:29
@Gudahtt Gudahtt force-pushed the remove-unused-confirm-transaction-action branch from 1a74ff9 to 66faacc Compare February 8, 2021 16:33
Base automatically changed from fix-transfer-from-localized-message to develop February 8, 2021 17:30
The `confirmTransaction` Redux slice had a lot of unused state and
action creators. They have all been removed.
@Gudahtt Gudahtt force-pushed the remove-unused-confirm-transaction-action branch from 66faacc to e7b3ef8 Compare February 8, 2021 17:30
@Gudahtt Gudahtt marked this pull request as ready for review February 8, 2021 17:31
@Gudahtt Gudahtt requested a review from a team as a code owner February 8, 2021 17:31
@Gudahtt Gudahtt requested a review from darkwing February 8, 2021 17:31
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [e7b3ef8]
Page Load Metrics (581 ± 23 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint45725584
domContentLoaded4156555804723
load4176555814723
domInteractive4156545804723

Copy link
Copy Markdown
Contributor

@brad-decker brad-decker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and reviewed the dead code. Looks good to me.

@Gudahtt Gudahtt merged commit 6677bd9 into develop Feb 8, 2021
@Gudahtt Gudahtt deleted the remove-unused-confirm-transaction-action branch February 8, 2021 21:20
@github-actions github-actions bot locked and limited conversation to collaborators Feb 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants