Skip to content

Update v9.1.0 changelog#10526

Merged
tmashuang merged 1 commit intoVersion-v9.1.0from
update-v9.1.0-changelog
Mar 1, 2021
Merged

Update v9.1.0 changelog#10526
tmashuang merged 1 commit intoVersion-v9.1.0from
update-v9.1.0-changelog

Conversation

@tmashuang
Copy link
Copy Markdown
Contributor

@tmashuang tmashuang commented Feb 26, 2021

Original auto-generated changelog.

Removed non-user facing issues and re-summarized some of the descriptions.

@tmashuang tmashuang requested a review from a team as a code owner February 26, 2021 00:08
@tmashuang tmashuang requested a review from darkwing February 26, 2021 00:08
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 26, 2021

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@tmashuang tmashuang changed the base branch from develop to Version-v9.1.0 February 26, 2021 00:09
@tmashuang tmashuang force-pushed the update-v9.1.0-changelog branch from 4f8700a to cd36582 Compare February 26, 2021 00:11
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Feb 26, 2021

Builds ready [cd36582]
Page Load Metrics (629 ± 41 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint478758105
domContentLoaded5548426278541
load5558446298541
domInteractive5538426278541

@darkwing
Copy link
Copy Markdown
Contributor

darkwing commented Feb 26, 2021

So far so good but I don't want to approve until that PR is out of draft. What is our practice for change logs when it comes to changes without an issue, because have plenty of those?

brad-decker
brad-decker suggested changes Feb 26, 2021
View reviewed changes
@tmashuang tmashuang force-pushed the update-v9.1.0-changelog branch from cd36582 to ab71816 Compare February 26, 2021 18:02
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Feb 26, 2021

Builds ready [ab71816]
Page Load Metrics (674 ± 54 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint477861105
domContentLoaded54394767211254
load54594867411254
domInteractive54394767211254

@tmashuang tmashuang force-pushed the update-v9.1.0-changelog branch from ab71816 to f51f6c2 Compare March 1, 2021 17:49
@tmashuang tmashuang force-pushed the update-v9.1.0-changelog branch from f51f6c2 to 8dd9ed8 Compare March 1, 2021 17:52
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Mar 1, 2021

Builds ready [8dd9ed8]
Page Load Metrics (702 ± 61 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint46786294
domContentLoaded36991570112761
load37091670212761
domInteractive36891570012761

@tmashuang tmashuang merged commit 1884ea2 into Version-v9.1.0 Mar 1, 2021
@tmashuang tmashuang deleted the update-v9.1.0-changelog branch March 1, 2021 18:34
@github-actions github-actions bot locked and limited conversation to collaborators Mar 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@darkwing darkwing Awaiting requested review from darkwing

1 more reviewer

@brad-decker brad-decker brad-decker approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tmashuang @metamaskbot @darkwing @brad-decker