Skip to content

Fix locale lint errors#10410

Merged
Gudahtt merged 1 commit intodevelopfrom
fix-locale-lint-errors
Feb 9, 2021
Merged

Fix locale lint errors#10410
Gudahtt merged 1 commit intodevelopfrom
fix-locale-lint-errors

Conversation

@Gudahtt
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt commented Feb 9, 2021

The updates to zh_CN merged in #9388 were a fair bit behind the develop branch, so they ended up introducing various lint failures despite passing on CI on the PR.

The localized messages have been updated to include English descriptions, and one extraneous message has been removed.

The updates to `zh_CN` merged in #9388 were a fair bit behind the
`develop` branch, so they ended up introducing various lint failures
despite passing on CI on the PR.

The localized messages have been updated to include English
descriptions, and one extraneous message has been removed.
@Gudahtt Gudahtt requested a review from a team as a code owner February 9, 2021 17:09
@Gudahtt Gudahtt requested a review from darkwing February 9, 2021 17:09
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [c5c7526]
Page Load Metrics (572 ± 11 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint44775374
domContentLoaded5306165712311
load5326175722311
domInteractive5306155702311

@Gudahtt Gudahtt merged commit 91aaa8c into develop Feb 9, 2021
@Gudahtt Gudahtt deleted the fix-locale-lint-errors branch February 9, 2021 17:26
@github-actions github-actions bot locked and limited conversation to collaborators Feb 9, 2021
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [c5c7526]
Page Load Metrics (622 ± 47 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint46795784
domContentLoaded3888956219847
load3898966229847
domInteractive3888946219847

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants