Skip to content

Lint - Lint all the things (without conflicts!)#4712

Merged
kumavis merged 24 commits intodevelopfrom
lint-fix
Jul 3, 2018
Merged

Lint - Lint all the things (without conflicts!)#4712
kumavis merged 24 commits intodevelopfrom
lint-fix

Conversation

@brunobar79
Copy link
Copy Markdown
Contributor

@brunobar79 brunobar79 commented Jul 3, 2018 •
edited
Loading

This is pretty much the same as #4395 except it was done based on the current develop branch so there are no conflicts.

  • Updated .eslintignore with the same paths as Lint - Lint all the things #4395
  • Updated .eslintrc with the same rules as Lint - Lint all the things #4395 and added missing global variables (for ex. "$")
  • Replaced gulp:lint && gulp:lint:fix by eslint && .eslint --fix
  • Removed gulp-eslint dependency and cleaned up gulpfile
  • Fixed all the autofixable warnings with eslint . --fix
  • Manually fixed all the warnings / errors left

cc: @kumavis

It would be great if we can get this merged soon to avoid massive merge conflicts.

brunobar79 added 24 commits July 2, 2018 18:35
@brunobar79
update eslint rules and paths
61fcec7
@brunobar79
remove gulp eslint and cleanup gulpfile
cc11a62
@brunobar79
eslint --fix .
a8f745f
@brunobar79
add $ to globals
0fad485
@brunobar79
fix beefy.js warnings
8fbcd95
@brunobar79
fix mock-dev.js warnings
ffaca79
@brunobar79
fix sourcemap-validator.js warnings
42feca1
@brunobar79
fix ui-dev.js warnings
3c1471d
@brunobar79
fix verify-locale-strings.js
26e4f87
@brunobar79
fix version-bump.js
73b6d5f
@brunobar79
fix gentests.js warnings
ce0232f
@brunobar79
fix mascara/example/server.js warnings
35d83c4
@brunobar79
fix mascara warnings
03ff8a7
@brunobar79
fix gentests.js
bbc0d6f
@brunobar79
add QUnit to eslint globals
8c03232
@brunobar79
fix notices warning
376188f
@brunobar79
fix warnings for e2e tests
cb71896
@brunobar79
fix warnings for integration tests
04743af
@brunobar79
fix test/mascara.conf.js warnings
390f861
@brunobar79
fix warning for unit tests
0da4126
@brunobar79
fix warning for new-ui screen tests
b4107a5
@brunobar79
fix tests
c734e48
@brunobar79
fix unit tests
4b39870
@brunobar79
fix contract-test
53f1072
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jul 3, 2018

Builds ready [53f1072]: mascara, chrome, firefox, edge, opera

@brunobar79 brunobar79 requested a review from kumavis July 3, 2018 02:40
@kumavis kumavis merged commit 1f0cf11 into develop Jul 3, 2018
@kumavis kumavis deleted the lint-fix branch July 3, 2018 16:40
@brunobar79 brunobar79 mentioned this pull request Jul 3, 2018
Closed
This was referenced Oct 1, 2018
Merged
Closed
Gudahtt added a commit that referenced this pull request Feb 12, 2021
@Gudahtt
Remove gulp-replace
fd0e3a0 
This package has not been used since #4712.
@Gudahtt Gudahtt mentioned this pull request Feb 12, 2021
Merged
Gudahtt added a commit that referenced this pull request Feb 12, 2021
@Gudahtt
Remove gulp-replace (#10432)
a9a6614 
This package has not been used since #4712.
Gudahtt added a commit that referenced this pull request Feb 12, 2021
@Gudahtt
Remove gulp-babel package
d9b6cf5 
This has not been used in some time. The last import was removed in
the PR #4712
@Gudahtt Gudahtt mentioned this pull request Feb 12, 2021
Merged
Gudahtt added a commit that referenced this pull request Feb 13, 2021
@Gudahtt
Remove gulp-babel package
4c082c6 
This has not been used in some time. The last import was removed in
the PR #4712
Gudahtt added a commit that referenced this pull request Feb 15, 2021
@Gudahtt
Remove gulp-babel package (#10437)
932794a 
This has not been used in some time. The last import was removed in
the PR #4712
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumavis kumavis kumavis approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brunobar79 @metamaskbot @kumavis