Merged
Conversation
* Add hiring note to the README * Update README.md * Update README.md
Fixes #9244 When trying to connect a Trezor account on a fresh install of MetaMask, the radio buttons on the account selection page would not respond to being clicked. When debugging this, it looks like the `onChange` event was never triggered. A radio `<input>` element should trigger `onChange` whenever the selection state change, but seemingly this wouldn't happen if the change in selection state was undone during the same render cycle. If I paused at a breakpoint during the render, I could see the checkbox get selected then unselected again without triggering `onChange`. The simplest fix was to use `onClick` instead of `onChange`. This seems more appropriate anyway because we're treating the radio button as a controlled component here, so the state of the underlying element isn't really of any concern.
To avoid repelling the neurotic JS developer.
* Use fetchWithTimeout everywhere * Memoize getFetchWithTimeout * Require specified timeout
* Refactor network display props * Add NETWORK_TYPE_RPC constant * Consolidate network constants
Restores the provider `data` event.
* origin/develop: add new typography component (#10197) @metamask/inpage-provider@8.0.3 (#10219) Add NETWORK_TYPE_RPC constant (#10203) Further improve organization of constants (#10200) add includePaths to sass-loader in storybook (#10213) Disable the swaps submit button after the first time it is clicked (#10162) Remove default to 18 decimals in quotesToRenderableData method (#10212) use dart sass, and update related modules (#10208) Fetch with a timeout everywhere (#10101) Make hiring link a link on text (#10206) improve design system scss (#10193) zh_TW: Translate buy, assets, activity (#10207) Update TW �term 乙太 -> 以太 (#10191) Fix hardware account selection (#10198) Add hiring note to the README (#10190) drop the fox in about (#10174)
Sync `master` with `develop`
* Add MAX_SAFE_CHAIN_ID constant * Add isSafeChainId to shared utils module * Move isPrefixedFormattedHexString to shared utils module * Validate custom RPC chain IDs in network controller * Update some network controller error messages. * Add isSafeChainId validation to UI
The changes made between v1.3.2 and v1.5.0 of `@reduxjs/toolkit` don't appear to affect us at all. They mostly consist of feature additions and bug fixes for edge cases we haven't encountered.[1] The one change that is technically breaking is that v8 of `immer` now freezes state objects in production rather than just in development. That would only be breaking if we were mutating Redux state though, which we aren't doing in the few Redux slices in which we use `@reduxjs/toolkit`. Even if we were, we would have noticed that it broke in development already. [1]: https://github.com/reduxjs/redux-toolkit/releases
Bumps [socket.io](https://github.com/socketio/socket.io) from 2.2.0 to 2.4.1. - [Release notes](https://github.com/socketio/socket.io/releases) - [Changelog](https://github.com/socketio/socket.io/blob/2.4.1/CHANGELOG.md) - [Commits](socketio/socket.io@2.2.0...2.4.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Firefox v68 is the _previous_ Extended Support Release. We are increasing this because our current minimum version doesn't support async iterators, so some of our dependencies cause the extension to crash. Our metrics show that usage of Firefox versions older than this is quite low (under 0.7% of Firefox users in the past month). These older versions are also _very behind_ on security updates. Using the Extended Support Release also makes it easier for us to test the minimum version, and ensure our extension remains compatible with it. Relates to #6805
The design system error constants were missing a hyphen. Now they match the CSS color variable they were intended to match.
* Fix getting the site metadata from the request origin params. Regressed from inpage-provider ts migration the request. The property domainMetadata is now set as a params key for the request. https://github.com/MetaMask/inpage-provider/blob/v7.0.0/src/siteMetadata.js#L19-L25 vs https://github.com/MetaMask/inpage-provider/blob/main/src/siteMetadata.ts#L19-L27 * Change hardcoded mocked response of the request to the prod response.
The decrupt message confirmation UI will crash if the origin metadata is not present. This PR makes the UI tolerant of that metadata being missing. It was always intended to be optional anyway.
* origin/develop: (29 commits) Reset swaps routeState in navigateBackToBuildQuote (#10166) Fix decrypt message confirmation UI crash (#10252) Fix site metadata JSON-RPC handler (#10243) Fix design system error constants (#10246) Remove unused environment variables (#10234) Update `yarn.lock` (#10241) Update postMessage structure for TrezorConnect 8 (#10192) Increase minimum Firefox version to v68 (#10195) Bump socket.io from 2.2.0 to 2.4.1 (#10232) Update `@reduxjs/toolkit` from v1.3.2 to v1.5.0 (#10228) eth-rpc-errors@4.0.2 (#10226) Add MAX_SAFE_CHAIN_ID and refactor chain ID validation (#10224) add chip component (#10199) add new typography component (#10197) @metamask/inpage-provider@8.0.3 (#10219) Add NETWORK_TYPE_RPC constant (#10203) Further improve organization of constants (#10200) add includePaths to sass-loader in storybook (#10213) Disable the swaps submit button after the first time it is clicked (#10162) Remove default to 18 decimals in quotesToRenderableData method (#10212) ...
Sync `master` with `develop`
This operator is being used under a condition that guarantees that the property is present, so the optional chain operator is useless.
…ding the tx fails. (#9947)
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
Author
Builds ready [498f980]
Page Load Metrics (538 ± 49 ms)
|
The `verify-locale-strings.js` script would blow up if you tried to verify a single locale. It now works.
The localized message descriptions from the `en` locale have been restored to all other locales. These descriptions are intended to help translators understand the context for each message, and are not intended to be translated.
The report on missing messages has been removed from the verify locales script. This report was making the console output of this command unreasonably long, and would obscure the reports on any invalid entries. A new script was written to report on missing localized messages. This can be run with the command `yarn locale-coverage`. This will print a report to the console on the coverage for each locale.
498f980 to
3803407
Compare
Collaborator
Author
Builds ready [3803407]
Page Load Metrics (594 ± 27 ms)
|
…tion fails (#10288) * Cancel transaction when swaps submission is failed because the simulation fails * Cleanup
Any commits with user-facing changes have been included, and re-worded to be more easily understood.
2ccb240 to
8f29e56
Compare
Collaborator
Author
Builds ready [8f29e56]
Page Load Metrics (607 ± 48 ms)
|
tmashuang
approved these changes
Jan 27, 2021
Member
|
I was able to test these changes:
I was unable to test these ones:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📦 🚀
Changelog