Fix decrypt message confirmation UI crash#10252
Merged
Conversation
rekmarks
requested changes
Jan 22, 2021
ui/app/pages/confirm-decrypt-message/confirm-decrypt-message.component.js
Outdated
Show resolved
Hide resolved
The decrupt message confirmation UI will crash if the origin metadata is not present. This PR makes the UI tolerant of that metadata being missing. It was always intended to be optional anyway.
e602e0c to
be33caf
Compare
rekmarks
reviewed
Jan 22, 2021
ui/app/pages/confirm-decrypt-message/confirm-decrypt-message.component.js
Show resolved
Hide resolved
rekmarks
approved these changes
Jan 22, 2021
Collaborator
Builds ready [be33caf]
Page Load Metrics (548 ± 53 ms)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #10247
Explanation:
The decrypt message confirmation UI will crash if the origin metadata is not present. This PR makes the UI tolerant of that metadata being missing. It was always intended to be optional anyway.
Manual testing steps: