Skip to content

Remove missing messages from verify locales script#10259

Merged
Gudahtt merged 1 commit intodevelopfrom
remove-missing-messages-from-verify-locales-script
Jan 26, 2021
Merged

Remove missing messages from verify locales script#10259
Gudahtt merged 1 commit intodevelopfrom
remove-missing-messages-from-verify-locales-script

Conversation

@Gudahtt
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt commented Jan 23, 2021

The report on missing messages has been removed from the verify locales script. This report was making the console output of this command unreasonably long, and would obscure the reports on any invalid entries.

A new script was written to report on missing localized messages. This can be run with the command yarn locale-coverage. This will print a report to the console on the coverage for each locale.

@Gudahtt Gudahtt force-pushed the remove-missing-messages-from-verify-locales-script branch from 37bebf0 to 61ba957 Compare January 23, 2021 03:13
The report on missing messages has been removed from the verify
locales script. This report was making the console output of this
command unreasonably long, and would obscure the reports on any invalid
entries.

A new script was written to report on missing localized messages.
This can be run with the command `yarn locale-coverage`. This will
print a report to the console on the coverage for each locale.
@Gudahtt Gudahtt force-pushed the remove-missing-messages-from-verify-locales-script branch from 61ba957 to ccc099c Compare January 23, 2021 03:36
@Gudahtt Gudahtt marked this pull request as ready for review January 23, 2021 03:47
@Gudahtt Gudahtt requested review from a team and kumavis as code owners January 23, 2021 03:47
@Gudahtt Gudahtt requested a review from brad-decker January 23, 2021 03:47
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [ccc099c]
Page Load Metrics (583 ± 49 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint41695494
domContentLoaded34576058110249
load34676258310249
domInteractive34476058110249

Copy link
Copy Markdown
Contributor

@brad-decker brad-decker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gudahtt Gudahtt merged commit b441b7c into develop Jan 26, 2021
@Gudahtt Gudahtt deleted the remove-missing-messages-from-verify-locales-script branch January 26, 2021 17:33
@github-actions github-actions bot locked and limited conversation to collaborators Jan 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants