Merged
Conversation
7ac9372 to
b7b60c3
Compare
d814326 to
ac968ac
Compare
Collaborator
Builds ready [ac968ac]
Page Load Metrics (470 ± 48 ms)
|
5b8f87f to
b6a1c02
Compare
ac968ac to
7b859b5
Compare
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
7b859b5 to
3baa8dd
Compare
b6a1c02 to
f5fb0dd
Compare
3baa8dd to
0fa8434
Compare
Collaborator
Builds ready [0fa8434]
Page Load Metrics (483 ± 45 ms)
|
f5fb0dd to
ada325b
Compare
0fa8434 to
ed947a9
Compare
Collaborator
Builds ready [ed947a9]
Page Load Metrics (537 ± 55 ms)
|
ed947a9 to
5d5954b
Compare
Contributor
Author
|
Reviewed with @rachelcope and the distinction between button and chip will be tackled later, but for now chip doesn't default to having click styling (cursor: pointer, etc) |
5d5954b to
90ed72d
Compare
Collaborator
Builds ready [90ed72d]
Page Load Metrics (562 ± 45 ms)
|
darkwing
approved these changes
Jan 20, 2021
Contributor
darkwing
left a comment
There was a problem hiding this comment.
Looks excellent, only feedback was my DMs regarding accessibility, i.e. <button> or tabindex='0'!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires:
#10193,#10197Adds a new
Chipcomponent based on designs from various parts of figma:CC @rachelcope -- I think this component is very useful, I've managed to refactor (in a different, forthcoming PR) a few different things to use this component effectively (anywhere the network is displayed with an indicator color, with the exception of the networks in the dropdown). I just want to make sure there is some distinction between a chip and a button Our buttons are rounded, like this chip, and we have buttons with just an outline. I have, for example, converted the dropdown for choosing network in the extension app header to be a chip. This is where the confusion comes for me because it has a click action, and is effectively a button. Chips in material design can have actions but they are generally reserved for the icons themselves and not the entire chip.