Merged
Conversation
7ac9372 to
b7b60c3
Compare
3576522 to
2bd77ce
Compare
Collaborator
Builds ready [2bd77ce]
Page Load Metrics (459 ± 41 ms)
|
Merged
5b8f87f to
b6a1c02
Compare
Collaborator
Builds ready [b6a1c02]
Page Load Metrics (541 ± 55 ms)
|
b6a1c02 to
f5fb0dd
Compare
Collaborator
Builds ready [f5fb0dd]
Page Load Metrics (551 ± 121 ms)
|
f5fb0dd to
ada325b
Compare
Collaborator
Builds ready [ada325b]
Page Load Metrics (596 ± 41 ms)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires:
#10193Adds a new
TypographyUI component that will allow quickly styling text per the design system without adding additional class names and scss.Example: where you might have previously needed to do something like this:
You can now do:
The lack of an example scss file for the second one is on purpose... you don't need it!
To an extent, this PR also will do some alignment and positioning for you, behind the
spacingandalignprops. Eventually, I hope to improve theTypographycomponent to hit 90% of the UI use cases without needing to apply a className or custom scss.Storybook:
