Reset swaps routeState in navigateBackToBuildQuote#10166
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
Builds ready [2d40c0c]
Page Load Metrics (533 ± 45 ms)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the back button on the swaps loading quotes page.
#9994 removed a call to
resetSwapsPostFetchStatefrom thenavigateBackToBuildQuotemethod. This was done to stop clearing some state that was needed on first render of the build quote component, and then subsequently cleared anyway in a useEffect call in the build quote screen.Due to some unnecessary complexity and messy inter-dependencies within our routing logic, removing the
resetSwapsPostFetchStatecall removed one piece of state clearing that was needed before thehistory.push(BUILD_QUOTE_ROUTE)call withinnavigateBackToBuildQuote: resettingrouteStatefrom'loading'to''. If that was not reset, the component passed to the render property of theFeatureToggledRoutefor theBUILD_QUOTE_ROUTEinpages/swaps/index.jswould redirect to theLOADING_QUOTES_ROUTE(See lines 276-289 ofpages/swaps/index.js)This PR ensures the resetting of the route state is done before the history.push call in
navigateBackToBuildQuote. This fixes the back button on the loading quotes screen, while maintaining the fix to the issue that was fixed in #9994