Fix 9906 - Prevent unwanted 'no quotes available' message when going back to build quote screen while having insufficient funds#9994
Merged
darkwing merged 1 commit intoMetaMask:developfrom Dec 7, 2020
Conversation
…back to build quote screen while having insufficient funds
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
|
This PR is safe because |
Contributor
|
Confirmed that it fixes #9906 |
danjm
approved these changes
Dec 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supercedes #9958
Fixes: #9906
Explanation:
This bug took me in a million places but in the end, I found that this call to
resetSwapsPostFetchStateappears to do absolutely nothing with regard to changing the state, but what it does do is redirect the user back to the "build quote" screen, thus negating the need forhistory.push(BUILD_QUOTE_ROUTE)and causing our timing conflict.Manual testing steps: