Fix 9906 - Prevent unwanted 'no quotes available' message when going back to build quote screen while having insufficient funds#9958
Closed
darkwing wants to merge 1 commit intoMetaMask:developfrom
Closed
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
danjm
reviewed
Dec 1, 2020
Contributor
There was a problem hiding this comment.
Is it necessary to remove the async and await? I'm not sure what the side effects might be, given that navigateBackToBuildQuote returns an async function
Contributor
Author
There was a problem hiding this comment.
The async/await is having no effect; if you hover over await in your text editor, the linter is saying that it in't necessary, thus the call isn't useful.
…ack to build quote screen while having insufficient funds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #9906
Explanation: As I detailed in #9906's comments, there's a timing conflict between going back to the build screen and the balanceError being reset. See comments for details.
Manual testing steps: