Skip to content

Update @reduxjs/toolkit from v1.3.2 to v1.5.0#10228

Merged
Gudahtt merged 1 commit intodevelopfrom
update-redux-toolkit
Jan 21, 2021
Merged

Update @reduxjs/toolkit from v1.3.2 to v1.5.0#10228
Gudahtt merged 1 commit intodevelopfrom
update-redux-toolkit

Conversation

@Gudahtt
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt commented Jan 21, 2021

The changes made between v1.3.2 and v1.5.0 of @reduxjs/toolkit don't appear to affect us at all. They mostly consist of feature additions and bug fixes for edge cases we haven't encountered.1

The one change that is technically breaking is that v8 of immer now freezes state objects in production rather than just in development. That would only be breaking if we were mutating Redux state though, which we aren't doing in the few Redux slices in which we use @reduxjs/toolkit. Even if we were, we would have noticed that it broke in development already.

The changes made between v1.3.2 and v1.5.0 of `@reduxjs/toolkit` don't
appear to affect us at all. They mostly consist of feature additions
and bug fixes for edge cases we haven't encountered.[1]

The one change that is technically breaking is that v8 of `immer` now
freezes state objects in production rather than just in development.
That would only be breaking if we were mutating Redux state though,
which we aren't doing in the few Redux slices in which we use
`@reduxjs/toolkit`. Even if we were, we would have noticed that it
broke in development already.

[1]: https://github.com/reduxjs/redux-toolkit/releases
@Gudahtt Gudahtt requested a review from a team as a code owner January 21, 2021 06:15
@Gudahtt Gudahtt requested a review from rekmarks January 21, 2021 06:15
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [a24a389]
Page Load Metrics (1145 ± 45 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaintNaNNaNNaNNaNNaN
domContentLoaded964130311419345
load965130411459345
domInteractive963130311419345

Copy link
Copy Markdown
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt merged commit 6de41a1 into develop Jan 21, 2021
@Gudahtt Gudahtt deleted the update-redux-toolkit branch January 21, 2021 13:34
@github-actions github-actions bot locked and limited conversation to collaborators Jan 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants