Fix getting the site metadata from the request origin params.#10243
Fix getting the site metadata from the request origin params.#10243
Conversation
Regressed from inpage-provider ts migration the request. The property domainMetadata is now set as a params key for the request. https://github.com/MetaMask/inpage-provider/blob/v7.0.0/src/siteMetadata.js#L19-L25 vs https://github.com/MetaMask/inpage-provider/blob/main/src/siteMetadata.ts#L19-L27
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [7bd1be0]
Page Load Metrics (551 ± 59 ms)
|
Gudahtt
left a comment
There was a problem hiding this comment.
LGTM, great catch!
Fixes getting the site metadata to populate the domainMetadata in state that is used for populating the decrypt message component which has been broken since the updated of the inpage-provider package.
How broken is it exactly? Does it crash, or is it just the site icon that's missing? If it's worse than a missing icon, we should also update the UI to be more tolerant of missing site metadata. Sites/extensions with embedded providers might fail to send site metadata, so we shouldn't assume it's present anywhere if at all possible.
|
Do you know if this would fix #10247? |
Regressed from inpage-provider ts migration the request. The property domainMetadata is now set as a params key for the request.
https://github.com/MetaMask/inpage-provider/blob/v7.0.0/src/siteMetadata.js#L19-L25
vs
https://github.com/MetaMask/inpage-provider/blob/main/src/siteMetadata.ts#L19-L27
Fixes getting the site metadata to populate the domainMetadata in state that is used for populating the decrypt message component which has been broken since the updated of the inpage-provider package.