Skip to content

Do not publish swaps transaction if the estimateGas call made when adding the tx fails.#9947

Merged
Gudahtt merged 1 commit intodevelopfrom
fail-swap-if-simulation-fails
Jan 22, 2021
Merged

Do not publish swaps transaction if the estimateGas call made when adding the tx fails.#9947
Gudahtt merged 1 commit intodevelopfrom
fail-swap-if-simulation-fails

Conversation

@danjm
Copy link
Copy Markdown
Contributor

@danjm danjm commented Nov 26, 2020

This PR is explained by the inline comment that is added within the code change.

For now, the swaps that are failed due to the changes in this PR will have the same error screen as all other failures. That will be improved upon with #9948

@danjm danjm requested a review from a team as a code owner November 26, 2020 10:16
@danjm danjm requested a review from NiranjanaBinoy November 26, 2020 10:16
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [29e5374]
Page Load Metrics (494 ± 37 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint3293622211
domContentLoaded3205644927737
load3225664947737
domInteractive3205644927737

Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt merged commit 7f1f683 into develop Jan 22, 2021
@Gudahtt Gudahtt deleted the fail-swap-if-simulation-fails branch January 22, 2021 21:14
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants