Skip to content

Update TW term 乙太 -> 以太#10191

Merged
rekmarks merged 1 commit intoMetaMask:developfrom
gasolin:patch-1
Jan 18, 2021
Merged

Update TW term 乙太 -> 以太#10191
rekmarks merged 1 commit intoMetaMask:developfrom
gasolin:patch-1

Conversation

@gasolin
Copy link
Copy Markdown
Contributor

@gasolin gasolin commented Jan 14, 2021

Fixes: # Non
Refer https://www.facebook.com/groups/taipei.ethereum.meetup/?multi_permalinks=1611359475723887&comment_id=1611504179042750&notif_id=1610547434079356&notif_t=feedback_reaction_generic&ref=notif

Explanation:

In Traditional/Simplified chinese world, 以太坊 is more common than 乙太坊
https://ethereum.org/zh-tw/

I think it caused by my origin translation's fault

@gasolin gasolin requested a review from a team as a code owner January 14, 2021 14:58
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 14, 2021 •
edited
Loading

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@andy0130tw
Copy link
Copy Markdown
Contributor

andy0130tw commented Jan 14, 2021 •
edited
Loading

As MetaMask has gained more popularity then ever over Taiwan, I think it is a good time to also update the zh_TW l10n file to its most recent version. Mostly there are some words to be polished, 乙太/以太 serving as an instance. For missing translations, I can make efforts to suggest some.

@Gudahtt
Copy link
Copy Markdown
Member

Gudahtt commented Jan 15, 2021

Thanks for the contribution @gasolin! Could you sign the CLA? The instructions are here: #10191 (comment)

@gasolin
Copy link
Copy Markdown
Contributor Author

gasolin commented Jan 16, 2021

I have read the CLA Document and I hereby sign the CLA

rekmarks
rekmarks approved these changes Jan 18, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, Pinyin keyboards, Google searches, and dictionaries confirm that “以太” is far more common. It is also what's used on ethereum.org (although only for the simplified translation; maybe the authors want to PR the traditional one there as well).

LGTM. 谢谢！

@rekmarks
Copy link
Copy Markdown
Member

rekmarks commented Jan 18, 2021

CI passes for Firefox: https://app.circleci.com/jobs/github/MetaMask/metamask-extension/234445?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

@rekmarks rekmarks merged commit b0bb190 into MetaMask:develop Jan 18, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@rekmarks rekmarks rekmarks approved these changes

@NiranjanaBinoy NiranjanaBinoy Awaiting requested review from NiranjanaBinoy

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gasolin @andy0130tw @Gudahtt @rekmarks