remove matomo and route to segment#9646
Merged
brad-decker merged 4 commits intodevelopfrom Oct 26, 2020
Merged
Conversation
brad-decker
commented
Oct 19, 2020
package.json
Outdated
Contributor
Author
There was a problem hiding this comment.
I added this as a convenience so that IntelliSense works with types provided via JSdocs and react hooks.
a1c279d to
b51d50e
Compare
Collaborator
Builds ready [ee3ef95]
Page Load Metrics (393 ± 48 ms)
|
ee3ef95 to
f519f0f
Compare
f519f0f to
432abeb
Compare
1. updates contexts/metametrics.js to create a thin wrapper around the trackEvent function created by getTrackMetaMetricsEvent function. This wrapper casts the old api calls to the new format so that we can quickly migrate analytics tracking from matomo to segment. 2. Removes metametrics.util.js as it is no longer used. 3. Removes background-metametrics.js as it is no longere used 4. Updates metamask-controller to call .trackMetaMetricsEvent directly instead of using the background-metametrics helper 5. updates share/modules/metametrics to conditionally call one of two segment instances depending on the existence of a new key in MetaMetricsEventPayload: matomoEvent. If matomoEvent is true, it'll route the call to a special source in Segment. 6. Added support for manually providing metaMetricsId to the trackEvent function. This is required when tracking the event properly after successfully opting in to the metametrics system. 7. Adds explicit handling for the 'isOptIn' config flag on trackEvent which will always track an event but will use the ANONYMOUS_ID if the user doesn't yet have a metaMetricsId
432abeb to
844ea0c
Compare
Collaborator
Builds ready [4b7a398]
Page Load Metrics (416 ± 65 ms)
|
brad-decker
commented
Oct 23, 2020
Gudahtt
reviewed
Oct 23, 2020
Gudahtt
reviewed
Oct 23, 2020
Gudahtt
reviewed
Oct 24, 2020
Collaborator
Builds ready [93dc526]
Page Load Metrics (457 ± 61 ms)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces usage of the MetaMetrics.util.js library with our new shared segment module by mapping the event tracking signature of the old API to our new one at the provider level.