Conversation
* Fix getting the site metadata from the request origin params. Regressed from inpage-provider ts migration the request. The property domainMetadata is now set as a params key for the request. https://github.com/MetaMask/inpage-provider/blob/v7.0.0/src/siteMetadata.js#L19-L25 vs https://github.com/MetaMask/inpage-provider/blob/main/src/siteMetadata.ts#L19-L27 * Change hardcoded mocked response of the request to the prod response.
The decrupt message confirmation UI will crash if the origin metadata is not present. This PR makes the UI tolerant of that metadata being missing. It was always intended to be optional anyway.
All commits have been included in the changelog
Version v9.0.3 RC
* origin/develop: (29 commits) Reset swaps routeState in navigateBackToBuildQuote (#10166) Fix decrypt message confirmation UI crash (#10252) Fix site metadata JSON-RPC handler (#10243) Fix design system error constants (#10246) Remove unused environment variables (#10234) Update `yarn.lock` (#10241) Update postMessage structure for TrezorConnect 8 (#10192) Increase minimum Firefox version to v68 (#10195) Bump socket.io from 2.2.0 to 2.4.1 (#10232) Update `@reduxjs/toolkit` from v1.3.2 to v1.5.0 (#10228) eth-rpc-errors@4.0.2 (#10226) Add MAX_SAFE_CHAIN_ID and refactor chain ID validation (#10224) add chip component (#10199) add new typography component (#10197) @metamask/inpage-provider@8.0.3 (#10219) Add NETWORK_TYPE_RPC constant (#10203) Further improve organization of constants (#10200) add includePaths to sass-loader in storybook (#10213) Disable the swaps submit button after the first time it is clicked (#10162) Remove default to 18 decimals in quotesToRenderableData method (#10212) ...
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
danfinlay
approved these changes
Jan 22, 2021
Collaborator
Builds ready [74ee13f]
Page Load Metrics (553 ± 54 ms)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This brings
developup-to-date with v9.0.3