Merged
Conversation
* Fix getting the site metadata from the request origin params. Regressed from inpage-provider ts migration the request. The property domainMetadata is now set as a params key for the request. https://github.com/MetaMask/inpage-provider/blob/v7.0.0/src/siteMetadata.js#L19-L25 vs https://github.com/MetaMask/inpage-provider/blob/main/src/siteMetadata.ts#L19-L27 * Change hardcoded mocked response of the request to the prod response.
The decrupt message confirmation UI will crash if the origin metadata is not present. This PR makes the UI tolerant of that metadata being missing. It was always intended to be optional anyway.
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
All commits have been included in the changelog
Collaborator
Author
Builds ready [727ed51]
Page Load Metrics (558 ± 58 ms)
|
Gudahtt
approved these changes
Jan 22, 2021
Member
Gudahtt
left a comment
There was a problem hiding this comment.
LGTM! I've tested this on latest Chrome and Firefox, and have confirmed that there is no longer a UI crash on the decrypt confirmation on either. The site metadata is loading correctly as well.
I have also tested that this prevents a UI crash on sites using a legacy embedded inpage provider (e.g. https://gudahtt-test-dapp.herokuapp.com/). So if the site metadata is missing for whatever reason, there will still be no crash.
Contributor
|
Also verified the fix! Thanks for the fast response. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📦 🚀
Changelog