Skip to content

add includePaths to sass-loader in storybook#10213

Merged
brad-decker merged 1 commit intodevelopfrom
add-scss-path
Jan 20, 2021
Merged

add includePaths to sass-loader in storybook#10213
brad-decker merged 1 commit intodevelopfrom
add-scss-path

Conversation

@brad-decker
Copy link
Copy Markdown
Contributor

Fixes:

Not impacted yet, but #10197, #10199 and #10209 add storybook stories that use the design-system. In order to be able to do @use "design-system" versus @use "../../../css/design-system" we have to set the includePaths in the sass-loader

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [8fd5b63]
Page Load Metrics (466 ± 48 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint33624784
domContentLoaded28856646510048
load29056746610048
domInteractive28856546410048

@brad-decker brad-decker marked this pull request as ready for review January 19, 2021 18:33
@brad-decker brad-decker requested a review from a team as a code owner January 19, 2021 18:33
@brad-decker brad-decker requested a review from Gudahtt January 19, 2021 18:33
Copy link
Copy Markdown
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brad-decker brad-decker merged commit a3de54d into develop Jan 20, 2021
@brad-decker brad-decker deleted the add-scss-path branch January 20, 2021 15:58
@github-actions github-actions bot locked and limited conversation to collaborators Jan 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants