Skip to content

Remove unused environment variables#10234

Merged
Gudahtt merged 1 commit intodevelopfrom
remove-unused-environment-variables
Jan 21, 2021
Merged

Remove unused environment variables#10234
Gudahtt merged 1 commit intodevelopfrom
remove-unused-environment-variables

Conversation

@Gudahtt
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt commented Jan 21, 2021

The environment variables METAMETRICS_PROJECT_ID and ETH_GAS_STATION_API_KEY were still being injected into the JavaScript build, despite being unused. The MetaMetrics project ID was made obsolete in #9646, and the ETH Gas Station API key was made obsolete in PR #9867

@Gudahtt
Remove unused environment variables
c661788 
The environment variables `METAMETRICS_PROJECT_ID` and
`ETH_GAS_STATION_API_KEY` were still being injected into the JavaScript
build, despite being unused. The MetaMetrics project ID was made
obsolete in #9646, and the ETH Gas Station API key was made obsolete in
PR #9867
@Gudahtt Gudahtt requested review from a team and kumavis as code owners January 21, 2021 16:03
@Gudahtt Gudahtt requested a review from danjm January 21, 2021 16:03
@Gudahtt
Copy link
Copy Markdown
Member Author

Gudahtt commented Jan 21, 2021

It looks like METAMETRICS_PROJECT_ID has already been removed from CI. I'll remove ETH_GAS_STATION_API_KEY as well, after this is merged, and after saving it somewhere the team can access

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jan 21, 2021

Builds ready [c661788]
Page Load Metrics (509 ± 46 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint39635184
domContentLoaded3156255089646
load3206265099646
domInteractive3156245079646

@Gudahtt Gudahtt merged commit f6388f2 into develop Jan 21, 2021
@Gudahtt Gudahtt deleted the remove-unused-environment-variables branch January 21, 2021 20:34
@github-actions github-actions bot locked and limited conversation to collaborators Jan 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kumavis kumavis Awaiting requested review from kumavis kumavis is a code owner

@danjm danjm Awaiting requested review from danjm

1 more reviewer

@brad-decker brad-decker brad-decker approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Gudahtt @metamaskbot @brad-decker