Skip to content

Remove unnecessary optional chain operator#10256

Merged
Gudahtt merged 1 commit intodevelopfrom
remove-unnecessary-optional-chain-operator
Jan 22, 2021
Merged

Remove unnecessary optional chain operator#10256
Gudahtt merged 1 commit intodevelopfrom
remove-unnecessary-optional-chain-operator

Conversation

@Gudahtt
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt commented Jan 22, 2021

This operator is being used under a condition that guarantees that the property is present, so the optional chain operator is useless.

This operator is being used under a condition that guarantees that the
property is present, so the optional chain operator is useless.
@Gudahtt Gudahtt requested a review from a team as a code owner January 22, 2021 20:48
@Gudahtt Gudahtt requested review from darkwing and rekmarks January 22, 2021 20:48
Copy link
Copy Markdown
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right!

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [20aae89]
Page Load Metrics (549 ± 50 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint397150105
domContentLoaded33574154810450
load33674254910450
domInteractive33574154810450

@Gudahtt Gudahtt merged commit 9e7a799 into develop Jan 22, 2021
@Gudahtt Gudahtt deleted the remove-unnecessary-optional-chain-operator branch January 22, 2021 21:02
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants