Skip to content

Fix verification of single locale#10262

Merged
Gudahtt merged 1 commit intodevelopfrom
fix-verification-of-single-locale
Jan 26, 2021
Merged

Fix verification of single locale#10262
Gudahtt merged 1 commit intodevelopfrom
fix-verification-of-single-locale

Conversation

@Gudahtt
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt commented Jan 23, 2021

The verify-locale-strings.js script would blow up if you tried to verify a single locale. It now works.

The `verify-locale-strings.js` script would blow up if you tried to
verify a single locale. It now works.
@Gudahtt Gudahtt requested review from a team and kumavis as code owners January 23, 2021 04:07
@Gudahtt Gudahtt requested a review from darkwing January 23, 2021 04:07
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [492e02e]
Page Load Metrics (494 ± 51 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint40654973
domContentLoaded31164049310651
load31264149410651
domInteractive31164049210651

Copy link
Copy Markdown
Contributor

@brad-decker brad-decker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on my machine. Didn't know we could do this <_<

@Gudahtt Gudahtt merged commit 5b1da2c into develop Jan 26, 2021
@Gudahtt Gudahtt deleted the fix-verification-of-single-locale branch January 26, 2021 16:59
@github-actions github-actions bot locked and limited conversation to collaborators Jan 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants