move ufunc_defs.bzl to the top-level#77749
Closed
dagitses wants to merge 45 commits into
Closed
Conversation
Configerator supports this location already. This needs to be in the top-level so that caffe2/build.bzl can load it via relative load regardless of the build system used. Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)! [ghstack-poisoned]
Contributor
🔗 Helpful links
❌ 1 New FailuresAs of commit 4084b05 (more details on the Dr. CI page): Expand to see more
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages
|
This was referenced May 18, 2022
Configerator supports this location already. This needs to be in the top-level so that caffe2/build.bzl can load it via relative load regardless of the build system used. Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)! [ghstack-poisoned]
Configerator supports this location already. This needs to be in the top-level so that caffe2/build.bzl can load it via relative load regardless of the build system used. Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)! [ghstack-poisoned]
added 5 commits
May 18, 2022 09:17
Configerator supports this location already. This needs to be in the top-level so that caffe2/build.bzl can load it via relative load regardless of the build system used. Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)! [ghstack-poisoned]
Configerator supports this location already. This needs to be in the top-level so that caffe2/build.bzl can load it via relative load regardless of the build system used. Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)! [ghstack-poisoned]
Configerator supports this location already. This needs to be in the top-level so that caffe2/build.bzl can load it via relative load regardless of the build system used. Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)! [ghstack-poisoned]
Configerator supports this location already. This needs to be in the top-level so that caffe2/build.bzl can load it via relative load regardless of the build system used. Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)! [ghstack-poisoned]
Configerator supports this location already. This needs to be in the top-level so that caffe2/build.bzl can load it via relative load regardless of the build system used. Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)! [ghstack-poisoned]
added 2 commits
May 18, 2022 12:02
Configerator supports this location already. This needs to be in the top-level so that caffe2/build.bzl can load it via relative load regardless of the build system used. Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)! [ghstack-poisoned]
Configerator supports this location already. This needs to be in the top-level so that caffe2/build.bzl can load it via relative load regardless of the build system used. Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)! [ghstack-poisoned]
Configerator supports this location already. This needs to be in the top-level so that caffe2/build.bzl can load it via relative load regardless of the build system used. Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)! [ghstack-poisoned]
Configerator supports this location already. This needs to be in the top-level so that caffe2/build.bzl can load it via relative load regardless of the build system used. Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)! [ghstack-poisoned]
added 3 commits
May 18, 2022 14:11
Configerator supports this location already. This needs to be in the top-level so that caffe2/build.bzl can load it via relative load regardless of the build system used. Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)! [ghstack-poisoned]
Configerator supports this location already. This needs to be in the top-level so that caffe2/build.bzl can load it via relative load regardless of the build system used. Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)! [ghstack-poisoned]
Configerator supports this location already. This needs to be in the top-level so that caffe2/build.bzl can load it via relative load regardless of the build system used. Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)! [ghstack-poisoned]
Configerator supports this location already. This needs to be in the top-level so that caffe2/build.bzl can load it via relative load regardless of the build system used. Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)! [ghstack-poisoned]
added 11 commits
May 20, 2022 19:33
Configerator supports this location already. This needs to be in the top-level so that caffe2/build.bzl can load it via relative load regardless of the build system used. Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)! [ghstack-poisoned]
Configerator supports this location already. This needs to be in the top-level so that caffe2/build.bzl can load it via relative load regardless of the build system used. Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)! [ghstack-poisoned]
Configerator supports this location already. This needs to be in the top-level so that caffe2/build.bzl can load it via relative load regardless of the build system used. Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)! [ghstack-poisoned]
Configerator supports this location already. This needs to be in the top-level so that caffe2/build.bzl can load it via relative load regardless of the build system used. Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)! [ghstack-poisoned]
Configerator supports this location already. This needs to be in the top-level so that caffe2/build.bzl can load it via relative load regardless of the build system used. Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)! [ghstack-poisoned]
Configerator supports this location already. This needs to be in the top-level so that caffe2/build.bzl can load it via relative load regardless of the build system used. Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)! [ghstack-poisoned]
Configerator supports this location already. This needs to be in the top-level so that caffe2/build.bzl can load it via relative load regardless of the build system used. Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)! [ghstack-poisoned]
Configerator supports this location already. This needs to be in the top-level so that caffe2/build.bzl can load it via relative load regardless of the build system used. Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)! [ghstack-poisoned]
Configerator supports this location already. This needs to be in the top-level so that caffe2/build.bzl can load it via relative load regardless of the build system used. Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)! [ghstack-poisoned]
Configerator supports this location already. This needs to be in the top-level so that caffe2/build.bzl can load it via relative load regardless of the build system used. Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)! [ghstack-poisoned]
Configerator supports this location already. This needs to be in the top-level so that caffe2/build.bzl can load it via relative load regardless of the build system used. Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)! [ghstack-poisoned]
Configerator supports this location already. This needs to be in the top-level so that caffe2/build.bzl can load it via relative load regardless of the build system used. Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)! [ghstack-poisoned]
added 2 commits
May 23, 2022 09:58
Configerator supports this location already. This needs to be in the top-level so that caffe2/build.bzl can load it via relative load regardless of the build system used. Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)! [ghstack-poisoned]
Configerator supports this location already. This needs to be in the top-level so that caffe2/build.bzl can load it via relative load regardless of the build system used. Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)! [ghstack-poisoned]
added 6 commits
May 23, 2022 10:36
Configerator supports this location already. This needs to be in the top-level so that caffe2/build.bzl can load it via relative load regardless of the build system used. Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)! [ghstack-poisoned]
Configerator supports this location already. This needs to be in the top-level so that caffe2/build.bzl can load it via relative load regardless of the build system used. Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)! [ghstack-poisoned]
Configerator supports this location already. This needs to be in the top-level so that caffe2/build.bzl can load it via relative load regardless of the build system used. Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)! [ghstack-poisoned]
Configerator supports this location already. This needs to be in the top-level so that caffe2/build.bzl can load it via relative load regardless of the build system used. Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)! [ghstack-poisoned]
Configerator supports this location already. This needs to be in the top-level so that caffe2/build.bzl can load it via relative load regardless of the build system used. Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)! [ghstack-poisoned]
Configerator supports this location already. This needs to be in the top-level so that caffe2/build.bzl can load it via relative load regardless of the build system used. Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)! [ghstack-poisoned]
Configerator supports this location already. This needs to be in the top-level so that caffe2/build.bzl can load it via relative load regardless of the build system used. Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)! [ghstack-poisoned]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Configerator supports this location already. This needs to be in the
top-level so that caffe2/build.bzl can load it via relative load
regardless of the build system used.
Differential Revision: D36481463
NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!