extract aten_core_srcs function into shared build structure by dagitses · Pull Request #78535 · pytorch/pytorch

dagitses · 2022-05-31T16:27:28Z

Stack from ghstack (oldest at bottom):

This captures some overlap between Bazel and fbcode.

Differential Revision: D36780883

NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!

This captures some overlap between Bazel and fbcode. Differential Revision: [D36780883](https://our.internmc.facebook.com/intern/diff/D36780883/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36780883/)! [ghstack-poisoned]

facebook-github-bot · 2022-05-31T16:27:34Z

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/78535
📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓Need help or want to give feedback on the CI? Visit our office hours
↩️ [fb-only] Re-run with SSH instructions

❌ 2 New Failures

As of commit 1e19fbc (more details on the Dr. CI page):

Expand to see more

2/2 failures introduced in this PR

🕵️ 2 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages

pull / linux-bionic-py3_7-clang8-xla / test (xla, 1, 1, linux.2xlarge) (1/2)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

2022-07-12T17:30:23.9785166Z ##[error]Process completed with exit code 1.

2022-07-12T17:30:23.9748261Z Non-cacheable calls                   0
2022-07-12T17:30:23.9748514Z Non-compilation calls                 0
2022-07-12T17:30:23.9748727Z Unsupported compiler calls            0
2022-07-12T17:30:23.9748939Z Average cache write               0.000 s
2022-07-12T17:30:23.9749143Z Average cache read miss           0.000 s
2022-07-12T17:30:23.9749357Z Average cache read hit            0.000 s
2022-07-12T17:30:23.9749578Z Failed distributed compilations       0
2022-07-12T17:30:23.9750105Z Cache location                  S3, bucket: Bucket(name=ossci-compiler-cache-circleci-v2, base_url=http://ossci-compiler-cache-circleci-v2.s3.amazonaws.com/)
2022-07-12T17:30:23.9750508Z + echo ::endgroup::
2022-07-12T17:30:23.9750950Z ##[endgroup]
2022-07-12T17:30:23.9785166Z ##[error]Process completed with exit code 1.
2022-07-12T17:30:23.9820922Z Prepare all required actions
2022-07-12T17:30:23.9821202Z Getting action download info
2022-07-12T17:30:24.5151701Z ##[group]Run ./.github/actions/get-workflow-job-id
2022-07-12T17:30:24.5151930Z with:
2022-07-12T17:30:24.5152255Z   github-token: ***
2022-07-12T17:30:24.5152411Z env:
2022-07-12T17:30:24.5152591Z   GIT_DEFAULT_BRANCH: master
2022-07-12T17:30:24.5152776Z ##[endgroup]
2022-07-12T17:30:24.5178391Z ##[group]Run nick-fields/retry@71062288b76e2b6214ebde0e673ce0de1755740a
2022-07-12T17:30:24.5178711Z with:

pull / linux-xenial-cuda11.3-py3.7-gcc7-bazel-test / build-and-test (2/2)

Step: "Build" (full log | diagnosis details | 🔁 rerun)

2022-07-12T17:13:01.7931359Z �[0m�[1m�[31mERROR...c1plus: some warnings being treated as errors\n" }

2022-07-12T17:13:01.6894987Z �[32mINFO: �[0mElapsed time: 139.779s, Critical Path: 63.12s
2022-07-12T17:13:01.6900433Z �[32mINFO: �[0m1711 processes: 927 internal, 1 local, 783 processwrapper-sandbox.
2022-07-12T17:13:01.6920616Z �[31m�[1mFAILED:�[0m Build did NOT complete successfully
2022-07-12T17:13:01.7047370Z �[31m�[1mFAILED:�[0m Build did NOT complete successfully
2022-07-12T17:13:01.7272751Z �[0m+ sccache_epilogue
2022-07-12T17:13:01.7273400Z + echo '::group::Sccache Compilation Log'
2022-07-12T17:13:01.7274294Z ##[group]Sccache Compilation Log
2022-07-12T17:13:01.7274838Z + echo '=================== sccache compilation log ==================='
2022-07-12T17:13:01.7275205Z =================== sccache compilation log ===================
2022-07-12T17:13:01.7275741Z + python /var/lib/jenkins/workspace/.jenkins/pytorch/print_sccache_log.py /var/lib/jenkins/sccache_error.log
2022-07-12T17:13:01.7931359Z �[0m�[1m�[31mERROR�[0m 2022-07-12T17:13:00Z: sccache::server: Compilation failed: Output { status: ExitStatus(ExitStatus(256)), stdout: "", stderr: "In file included from bazel-out/k8-fastbuild/bin/_virtual_includes/aten_headers/ATen/native/CPUBlas.h:3:0,\n                 from aten/src/ATen/native/NaiveConvolutionTranspose3d.cpp:6:\nbazel-out/k8-fastbuild/bin/_virtual_includes/aten_headers/ATen/OpMathType.h:33:17: error: \'c10::ScalarType at::{anonymous}::toOpMathType(c10::ScalarType)\' defined but not used [-Werror=unused-function]\n c10::ScalarType toOpMathType(const c10::ScalarType type) {\n                 ^~~~~~~~~~~~\nIn file included from aten/src/ATen/native/NaiveConvolutionTranspose3d.cpp:5:0:\nbazel-out/k8-fastbuild/bin/_virtual_includes/aten_headers/ATen/native/ConvUtils.h:219:13: error: \'void at::native::convolution_shape_check(at::CheckedFrom, const at::TensorGeometryArg&, const at::TensorGeometryArg&, const at::TensorGeometryArg&, at::IntArrayRef, at::IntArrayRef, at::IntArrayRef, int64_t)\' defined but not used [-Werror=unused-function]\n static void convolution_shape_check(\n             ^~~~~~~~~~~~~~~~~~~~~~~\ncc1plus: some warnings being treated as errors\n" }
2022-07-12T17:13:01.7933667Z 
2022-07-12T17:13:01.7962500Z + echo '=========== If your build fails, please take a look at the log above for possible reasons ==========='
2022-07-12T17:13:01.7963277Z =========== If your build fails, please take a look at the log above for possible reasons ===========
2022-07-12T17:13:01.7963767Z + sccache --show-stats
2022-07-12T17:13:01.8280680Z Compile requests                    756
2022-07-12T17:13:01.8281307Z Compile requests executed           726
2022-07-12T17:13:01.8281730Z Cache hits                          691
2022-07-12T17:13:01.8282260Z Cache hits (C/C++)                  691
2022-07-12T17:13:01.8282782Z Cache misses                         20
2022-07-12T17:13:01.8283178Z Cache misses (C/C++)                 20

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

This captures some overlap between Bazel and fbcode. Differential Revision: [D36780883](https://our.internmc.facebook.com/intern/diff/D36780883/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36780883/)! ghstack-source-id: 157660578 Pull Request resolved: #78535

This captures some overlap between Bazel and fbcode. Differential Revision: [D36780883](https://our.internmc.facebook.com/intern/diff/D36780883/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36780883/)! [ghstack-poisoned]

Pull Request resolved: #78535 This captures some overlap between Bazel and fbcode. ghstack-source-id: 157660578 Differential Revision: [D36780883](https://our.internmc.facebook.com/intern/diff/D36780883/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36780883/)!

This captures some overlap between Bazel and fbcode. Differential Revision: [D36780883](https://our.internmc.facebook.com/intern/diff/D36780883/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36780883/)! [ghstack-poisoned]

Pull Request resolved: #78535 This captures some overlap between Bazel and fbcode. ghstack-source-id: 157660578 Differential Revision: [D36780883](https://our.internmc.facebook.com/intern/diff/D36780883/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36780883/)!

This captures some overlap between Bazel and fbcode. Differential Revision: [D36780883](https://our.internmc.facebook.com/intern/diff/D36780883/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36780883/)! [ghstack-poisoned]

Pull Request resolved: #78535 This captures some overlap between Bazel and fbcode. ghstack-source-id: 157660578 Differential Revision: [D36780883](https://our.internmc.facebook.com/intern/diff/D36780883/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36780883/)!

This captures some overlap between Bazel and fbcode. Differential Revision: [D36780883](https://our.internmc.facebook.com/intern/diff/D36780883/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36780883/)! [ghstack-poisoned]

Pull Request resolved: #78535 This captures some overlap between Bazel and fbcode. ghstack-source-id: 157660578 Differential Revision: [D36780883](https://our.internmc.facebook.com/intern/diff/D36780883/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36780883/)!

This captures some overlap between Bazel and fbcode. Differential Revision: [D36780883](https://our.internmc.facebook.com/intern/diff/D36780883/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36780883/)! [ghstack-poisoned]

Pull Request resolved: #78535 This captures some overlap between Bazel and fbcode. ghstack-source-id: 157660578 Differential Revision: [D36780883](https://our.internmc.facebook.com/intern/diff/D36780883/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36780883/)!

This captures some overlap between Bazel and fbcode. Differential Revision: [D36780883](https://our.internmc.facebook.com/intern/diff/D36780883/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36780883/)! [ghstack-poisoned]

github-actions · 2022-09-10T20:37:31Z

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

facebook-github-bot · 2022-10-04T01:03:51Z

/easycla

As part of the transition to the PyTorch Foundation, this project now requires contributions be covered under the new CLA. See #85559 for additional details.

This comment will trigger a new check of this PR. If you are already covered, you will simply see a new "EasyCLA" check that passes. If you are not covered, a bot will leave a new comment with a link to sign.

linux-foundation-easycla · 2022-10-04T01:03:56Z

❌ - login: @dagitses . The commit (3fda14b, 15c3982, 058f336, af54fa3, e6a555c, 2c9a88a, 56a3db6, c8cedf1, 5cb002a, 9ba10ce, ada5b21, 1e19fbc) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.

facebook-github-bot added the cla signed label May 31, 2022

dagitses mentioned this pull request May 31, 2022

move pytorch-root/tools/build_variables.bzl to the pytorch-root #78542

Closed

This was referenced Jun 17, 2022

gen_aten output into aten/src/ATen/ #79727

Closed

switch Bazel to common aten codegen #79783

Closed

dagitses mentioned this pull request Jul 6, 2022

yaml resources test #80961

Closed

Michael Andreas Dagitses added 2 commits July 8, 2022 07:25

github-actions Bot added the Stale label Sep 10, 2022

github-actions Bot closed this Nov 3, 2022

dagitses deleted the gh/dagitses/353/head branch November 19, 2022 03:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

extract aten_core_srcs function into shared build structure#78535

extract aten_core_srcs function into shared build structure#78535
dagitses wants to merge 12 commits into
gh/dagitses/353/basefrom
gh/dagitses/353/head

dagitses commented May 31, 2022 •

edited

Loading

Uh oh!

facebook-github-bot commented May 31, 2022 •

edited

Loading

🕵️ 2 new failures recognized by patterns

pull / linux-bionic-py3_7-clang8-xla / test (xla, 1, 1, linux.2xlarge) (1/2)

pull / linux-xenial-cuda11.3-py3.7-gcc7-bazel-test / build-and-test (2/2)

Uh oh!

github-actions Bot commented Sep 10, 2022

Uh oh!

facebook-github-bot commented Oct 4, 2022

Uh oh!

linux-foundation-easycla Bot commented Oct 4, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

dagitses commented May 31, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented May 31, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful links

❌ 2 New Failures

🕵️ 2 new failures recognized by patterns

pull / linux-bionic-py3_7-clang8-xla / test (xla, 1, 1, linux.2xlarge) (1/2)

pull / linux-xenial-cuda11.3-py3.7-gcc7-bazel-test / build-and-test (2/2)

Uh oh!

github-actions Bot commented Sep 10, 2022

Uh oh!

facebook-github-bot commented Oct 4, 2022

Uh oh!

linux-foundation-easycla Bot commented Oct 4, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

dagitses commented May 31, 2022 •

edited

Loading

facebook-github-bot commented May 31, 2022 •

edited

Loading