eliminate generated_cpu_cpp and generated_cuda_cpp from Bazel#77790
Closed
dagitses wants to merge 37 commits into
Closed
eliminate generated_cpu_cpp and generated_cuda_cpp from Bazel#77790dagitses wants to merge 37 commits into
dagitses wants to merge 37 commits into
Conversation
These are now redundant with shared variables. Differential Revision: [D36492536](https://our.internmc.facebook.com/intern/diff/D36492536/) [ghstack-poisoned]
Contributor
🔗 Helpful links
✅ No Failures (0 Pending)As of commit d264d43 (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced May 18, 2022
…zel" These are now redundant with shared variables. Differential Revision: [D36492536](https://our.internmc.facebook.com/intern/diff/D36492536/) [ghstack-poisoned]
dagitses
pushed a commit
that referenced
this pull request
May 18, 2022
Pull Request resolved: #77790 These are now redundant with shared variables. ghstack-source-id: 156715418 Differential Revision: [D36492536](https://our.internmc.facebook.com/intern/diff/D36492536/)
…zel" These are now redundant with shared variables. Differential Revision: [D36492536](https://our.internmc.facebook.com/intern/diff/D36492536/) [ghstack-poisoned]
…zel" These are now redundant with shared variables. Differential Revision: [D36492536](https://our.internmc.facebook.com/intern/diff/D36492536/) [ghstack-poisoned]
dagitses
pushed a commit
that referenced
this pull request
May 19, 2022
Pull Request resolved: #77790 These are now redundant with shared variables. ghstack-source-id: 156715418 Differential Revision: [D36492536](https://our.internmc.facebook.com/intern/diff/D36492536/)
…zel" These are now redundant with shared variables. Differential Revision: [D36492536](https://our.internmc.facebook.com/intern/diff/D36492536/) [ghstack-poisoned]
This was referenced May 19, 2022
added 5 commits
May 19, 2022 10:58
…zel" These are now redundant with shared variables. Differential Revision: [D36492536](https://our.internmc.facebook.com/intern/diff/D36492536/) [ghstack-poisoned]
…zel" These are now redundant with shared variables. Differential Revision: [D36492536](https://our.internmc.facebook.com/intern/diff/D36492536/) [ghstack-poisoned]
…zel" These are now redundant with shared variables. Differential Revision: [D36492536](https://our.internmc.facebook.com/intern/diff/D36492536/) [ghstack-poisoned]
…zel" These are now redundant with shared variables. Differential Revision: [D36492536](https://our.internmc.facebook.com/intern/diff/D36492536/) [ghstack-poisoned]
…zel" These are now redundant with shared variables. Differential Revision: [D36492536](https://our.internmc.facebook.com/intern/diff/D36492536/) [ghstack-poisoned]
…zel" These are now redundant with shared variables. Differential Revision: [D36492536](https://our.internmc.facebook.com/intern/diff/D36492536/) [ghstack-poisoned]
added 6 commits
May 23, 2022 10:36
…zel" These are now redundant with shared variables. Differential Revision: [D36492536](https://our.internmc.facebook.com/intern/diff/D36492536/) [ghstack-poisoned]
…zel" These are now redundant with shared variables. Differential Revision: [D36492536](https://our.internmc.facebook.com/intern/diff/D36492536/) [ghstack-poisoned]
…zel" These are now redundant with shared variables. Differential Revision: [D36492536](https://our.internmc.facebook.com/intern/diff/D36492536/) [ghstack-poisoned]
…zel" These are now redundant with shared variables. Differential Revision: [D36492536](https://our.internmc.facebook.com/intern/diff/D36492536/) [ghstack-poisoned]
…zel" These are now redundant with shared variables. Differential Revision: [D36492536](https://our.internmc.facebook.com/intern/diff/D36492536/) [ghstack-poisoned]
…zel" These are now redundant with shared variables. Differential Revision: [D36492536](https://our.internmc.facebook.com/intern/diff/D36492536/) [ghstack-poisoned]
…zel" These are now redundant with shared variables. Differential Revision: [D36492536](https://our.internmc.facebook.com/intern/diff/D36492536/) [ghstack-poisoned]
added 2 commits
June 2, 2022 13:23
…zel" These are now redundant with shared variables. Differential Revision: [D36492536](https://our.internmc.facebook.com/intern/diff/D36492536/) [ghstack-poisoned]
…zel" These are now redundant with shared variables. Differential Revision: [D36492536](https://our.internmc.facebook.com/intern/diff/D36492536/) [ghstack-poisoned]
This was referenced Jun 17, 2022
added 6 commits
June 20, 2022 08:09
…zel" These are now redundant with shared variables. Differential Revision: [D36492536](https://our.internmc.facebook.com/intern/diff/D36492536/) [ghstack-poisoned]
…zel" These are now redundant with shared variables. Differential Revision: [D36492536](https://our.internmc.facebook.com/intern/diff/D36492536/) [ghstack-poisoned]
…zel" These are now redundant with shared variables. Differential Revision: [D36492536](https://our.internmc.facebook.com/intern/diff/D36492536/) [ghstack-poisoned]
…zel" These are now redundant with shared variables. Differential Revision: [D36492536](https://our.internmc.facebook.com/intern/diff/D36492536/) [ghstack-poisoned]
…zel" These are now redundant with shared variables. Differential Revision: [D36492536](https://our.internmc.facebook.com/intern/diff/D36492536/) [ghstack-poisoned]
…zel" These are now redundant with shared variables. Differential Revision: [D36492536](https://our.internmc.facebook.com/intern/diff/D36492536/) [ghstack-poisoned]
Closed
added 2 commits
July 8, 2022 07:25
…zel" These are now redundant with shared variables. Differential Revision: [D36492536](https://our.internmc.facebook.com/intern/diff/D36492536/) [ghstack-poisoned]
…zel" These are now redundant with shared variables. Differential Revision: [D36492536](https://our.internmc.facebook.com/intern/diff/D36492536/) [ghstack-poisoned]
Contributor
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Contributor
|
/easycla As part of the transition to the PyTorch Foundation, this project now requires contributions be covered under the new CLA. See #85559 for additional details. This comment will trigger a new check of this PR. If you are already covered, you will simply see a new "EasyCLA" check that passes. If you are not covered, a bot will leave a new comment with a link to sign. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
These are now redundant with shared variables.
Differential Revision: D36492536