move the GENERATED_CORE_H headers into aten_core_headers by dagitses · Pull Request #78097 · pytorch/pytorch

dagitses · 2022-05-23T16:42:45Z

Stack from ghstack (oldest at bottom):

This will eventually allow us to eliminate some redundant libraries in
fbcode.

Differential Revision: D36598491

NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!

This will eventually allow us to eliminate some redundant libraries in fbcode. Differential Revision: [D36598491](https://our.internmc.facebook.com/intern/diff/D36598491/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36598491/)! [ghstack-poisoned]

facebook-github-bot · 2022-05-23T16:42:51Z

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/78097
📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓Need help or want to give feedback on the CI? Visit our office hours
↩️ [fb-only] Re-run with SSH instructions

❌ 1 New Failures

As of commit 6bb13c0 (more details on the Dr. CI page):

Expand to see more

1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages

pull / linux-xenial-cuda11.3-py3.7-gcc7-bazel-test / build-and-test (1/1)

Step: "Build" (full log | diagnosis details | 🔁 rerun)

2022-07-12T17:09:36.4938727Z �[0m�[1m�[31mERROR...c1plus: some warnings being treated as errors\n" }

2022-07-12T17:09:36.3764129Z �[32mINFO: �[0mElapsed time: 138.980s, Critical Path: 48.10s
2022-07-12T17:09:36.3770406Z �[32mINFO: �[0m2000 processes: 941 internal, 1 local, 1058 processwrapper-sandbox.
2022-07-12T17:09:36.3807917Z �[31m�[1mFAILED:�[0m Build did NOT complete successfully
2022-07-12T17:09:36.3972286Z �[31m�[1mFAILED:�[0m Build did NOT complete successfully
2022-07-12T17:09:36.4217300Z �[0m+ sccache_epilogue
2022-07-12T17:09:36.4218492Z + echo '::group::Sccache Compilation Log'
2022-07-12T17:09:36.4220427Z ##[group]Sccache Compilation Log
2022-07-12T17:09:36.4221344Z + echo '=================== sccache compilation log ==================='
2022-07-12T17:09:36.4222532Z =================== sccache compilation log ===================
2022-07-12T17:09:36.4224972Z + python /var/lib/jenkins/workspace/.jenkins/pytorch/print_sccache_log.py /var/lib/jenkins/sccache_error.log
2022-07-12T17:09:36.4938727Z �[0m�[1m�[31mERROR�[0m 2022-07-12T17:09:35Z: sccache::server: Compilation failed: Output { status: ExitStatus(ExitStatus(256)), stdout: "", stderr: "In file included from bazel-out/k8-fastbuild/bin/_virtual_includes/aten_headers/ATen/native/ScatterGatherChecks.h:5:0,\n                 from aten/src/ATen/native/TensorAdvancedIndexing.cpp:65:\nbazel-out/k8-fastbuild/bin/_virtual_includes/aten_headers/ATen/native/ReduceOpsUtils.h:382:23: error: \'at::TensorIterator at::meta::make_reduction(const at::Tensor&, const at::Tensor&, const at::Tensor&, at::IntArrayRef, bool, c10::ScalarType, c10::ScalarType)\' defined but not used [-Werror=unused-function]\n static TensorIterator make_reduction(\n                       ^~~~~~~~~~~~~~\nbazel-out/k8-fastbuild/bin/_virtual_includes/aten_headers/ATen/native/ReduceOpsUtils.h:349:13: error: \'void at::meta::resize_reduction_with_indices(at::impl::MetaBase&, const at::Tensor&, at::IntArrayRef, bool, c10::ScalarType)\' defined but not used [-Werror=unused-function]\n static void resize_reduction_with_indices(\n             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~\nbazel-out/k8-fastbuild/bin/_virtual_includes/aten_headers/ATen/native/ReduceOpsUtils.h:335:13: error: \'void at::meta::resize_reduction(at::impl::MetaBase&, const at::Tensor&, at::OptionalIntArrayRef, bool, c10::ScalarType)\' defined but not used [-Werror=unused-function]\n static void resize_reduction(\n             ^~~~~~~~~~~~~~~~\nbazel-out/k8-fastbuild/bin/_virtual_includes/aten_headers/ATen/native/ReduceOpsUtils.h:278:13: error: \'void at::native::zero_numel_check_dims(const at::Tensor&, at::IntArrayRef, const char*)\' defined but not used [-Werror=unused-function]\n static void zero_numel_check_dims(const Tensor& self, const IntArrayRef dim, const char *fn_name) {\n             ^~~~~~~~~~~~~~~~~~~~~\ncc1plus: some warnings being treated as errors\n" }
2022-07-12T17:09:36.4942232Z 
2022-07-12T17:09:36.4982193Z + echo '=========== If your build fails, please take a look at the log above for possible reasons ==========='
2022-07-12T17:09:36.4982786Z =========== If your build fails, please take a look at the log above for possible reasons ===========
2022-07-12T17:09:36.4983242Z + sccache --show-stats
2022-07-12T17:09:36.5022148Z Compile requests                   1032
2022-07-12T17:09:36.5022539Z Compile requests executed           992
2022-07-12T17:09:36.5022854Z Cache hits                          976
2022-07-12T17:09:36.5023163Z Cache hits (C/C++)                  976
2022-07-12T17:09:36.5023462Z Cache misses                          4
2022-07-12T17:09:36.5023760Z Cache misses (C/C++)                  4

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

This will eventually allow us to eliminate some redundant libraries in fbcode. Differential Revision: [D36598491](https://our.internmc.facebook.com/intern/diff/D36598491/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36598491/)! [ghstack-poisoned]

Pull Request resolved: #78097 This will eventually allow us to eliminate some redundant libraries in fbcode. ghstack-source-id: 157063113 Differential Revision: [D36598491](https://our.internmc.facebook.com/intern/diff/D36598491/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36598491/)!

This will eventually allow us to eliminate some redundant libraries in fbcode. Differential Revision: [D36598491](https://our.internmc.facebook.com/intern/diff/D36598491/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36598491/)! [ghstack-poisoned]

github-actions · 2022-09-10T20:37:28Z

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

facebook-github-bot · 2022-10-04T01:04:08Z

/easycla

As part of the transition to the PyTorch Foundation, this project now requires contributions be covered under the new CLA. See #85559 for additional details.

This comment will trigger a new check of this PR. If you are already covered, you will simply see a new "EasyCLA" check that passes. If you are not covered, a bot will leave a new comment with a link to sign.

linux-foundation-easycla · 2022-10-04T01:04:16Z

❌ - login: @dagitses . The commit (85e0d94, 5d9568a, e0e5fd3, b47efb7, e744fe7, 9c20802, e81d89f, 699f540, 8cd1d56, b304e21, 4ea5179, 6210490, 2a75f17, 974da24, ae70021, bb9facd, 5b3994a, 403907d, 276a903, 6bb13c0) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.

facebook-github-bot added the cla signed label May 23, 2022

dagitses mentioned this pull request May 23, 2022

use full paths to files to generate-code genrule #78104

Closed

Michael Andreas Dagitses added 6 commits May 23, 2022 10:36

dagitses mentioned this pull request May 31, 2022

extract aten_core_srcs function into shared build structure #78535

Closed

dagitses mentioned this pull request May 31, 2022

move pytorch-root/tools/build_variables.bzl to the pytorch-root #78542

Closed

Michael Andreas Dagitses added 2 commits June 2, 2022 13:23

This was referenced Jun 17, 2022

gen_aten output into aten/src/ATen/ #79727

Closed

switch Bazel to common aten codegen #79783

Closed

Michael Andreas Dagitses added 6 commits June 20, 2022 08:09

dagitses mentioned this pull request Jul 6, 2022

yaml resources test #80961

Closed

Michael Andreas Dagitses added 2 commits July 8, 2022 07:25

github-actions Bot added the Stale label Sep 10, 2022

github-actions Bot closed this Nov 3, 2022

dagitses deleted the gh/dagitses/351/head branch November 19, 2022 03:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

move the GENERATED_CORE_H headers into aten_core_headers#78097

move the GENERATED_CORE_H headers into aten_core_headers#78097
dagitses wants to merge 20 commits into
gh/dagitses/351/basefrom
gh/dagitses/351/head

dagitses commented May 23, 2022 •

edited

Loading

Uh oh!

facebook-github-bot commented May 23, 2022 •

edited

Loading

🕵️ 1 new failure recognized by patterns

pull / linux-xenial-cuda11.3-py3.7-gcc7-bazel-test / build-and-test (1/1)

Uh oh!

github-actions Bot commented Sep 10, 2022

Uh oh!

facebook-github-bot commented Oct 4, 2022

Uh oh!

linux-foundation-easycla Bot commented Oct 4, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

dagitses commented May 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented May 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful links

❌ 1 New Failures

🕵️ 1 new failure recognized by patterns

pull / linux-xenial-cuda11.3-py3.7-gcc7-bazel-test / build-and-test (1/1)

Uh oh!

github-actions Bot commented Sep 10, 2022

Uh oh!

facebook-github-bot commented Oct 4, 2022

Uh oh!

linux-foundation-easycla Bot commented Oct 4, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

dagitses commented May 23, 2022 •

edited

Loading

facebook-github-bot commented May 23, 2022 •

edited

Loading