use full paths to files to generate-code genrule by dagitses · Pull Request #78104 · pytorch/pytorch

dagitses · 2022-05-23T17:31:37Z

Stack from ghstack (oldest at bottom):

We can use the same paths in Bazel and fbcode. No need to add aliases.

Differential Revision: D36600018

NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!

We can use the same paths in Bazel and fbcode. No need to add aliases. Differential Revision: [D36600018](https://our.internmc.facebook.com/intern/diff/D36600018/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36600018/)! [ghstack-poisoned]

facebook-github-bot · 2022-05-23T17:31:43Z

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/78104
📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓Need help or want to give feedback on the CI? Visit our office hours
↩️ [fb-only] Re-run with SSH instructions

❌ 1 New Failures, 1 Pending

As of commit 920c796 (more details on the Dr. CI page):

Expand to see more

1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages

pull / linux-xenial-cuda11.3-py3.7-gcc7-bazel-test / build-and-test (1/1)

Step: "Build" (full log | diagnosis details | 🔁 rerun)

2022-07-12T17:04:10.5134830Z �[0m�[1m�[31mERROR...c1plus: some warnings being treated as errors\n" }

2022-07-12T17:04:10.4104829Z �[32mINFO: �[0mElapsed time: 116.232s, Critical Path: 28.70s
2022-07-12T17:04:10.4111925Z �[32mINFO: �[0m1911 processes: 886 internal, 1 local, 1024 processwrapper-sandbox.
2022-07-12T17:04:10.4127366Z �[31m�[1mFAILED:�[0m Build did NOT complete successfully
2022-07-12T17:04:10.4191420Z �[31m�[1mFAILED:�[0m Build did NOT complete successfully
2022-07-12T17:04:10.4454553Z �[0m+ sccache_epilogue
2022-07-12T17:04:10.4506747Z + echo '::group::Sccache Compilation Log'
2022-07-12T17:04:10.4513270Z ##[group]Sccache Compilation Log
2022-07-12T17:04:10.4519692Z + echo '=================== sccache compilation log ==================='
2022-07-12T17:04:10.4524880Z =================== sccache compilation log ===================
2022-07-12T17:04:10.4530736Z + python /var/lib/jenkins/workspace/.jenkins/pytorch/print_sccache_log.py /var/lib/jenkins/sccache_error.log
2022-07-12T17:04:10.5134830Z �[0m�[1m�[31mERROR�[0m 2022-07-12T17:04:09Z: sccache::server: Compilation failed: Output { status: ExitStatus(ExitStatus(256)), stdout: "", stderr: "In file included from bazel-out/k8-fastbuild/bin/_virtual_includes/aten_headers/ATen/native/CPUBlas.h:3:0,\n                 from bazel-out/k8-fastbuild/bin/aten/src/ATen/native/cpu/BlasKernel.cpp.AVX2.cpp:3:\nbazel-out/k8-fastbuild/bin/_virtual_includes/aten_headers/ATen/OpMathType.h:33:17: error: \'c10::ScalarType at::{anonymous}::toOpMathType(c10::ScalarType)\' defined but not used [-Werror=unused-function]\n c10::ScalarType toOpMathType(const c10::ScalarType type) {\n                 ^~~~~~~~~~~~\ncc1plus: some warnings being treated as errors\n" }
2022-07-12T17:04:10.5136136Z 
2022-07-12T17:04:10.5249613Z + echo '=========== If your build fails, please take a look at the log above for possible reasons ==========='
2022-07-12T17:04:10.5251297Z =========== If your build fails, please take a look at the log above for possible reasons ===========
2022-07-12T17:04:10.5253582Z + sccache --show-stats
2022-07-12T17:04:10.5538749Z Compile requests                    888
2022-07-12T17:04:10.5539133Z Compile requests executed           875
2022-07-12T17:04:10.5539489Z Cache hits                          860
2022-07-12T17:04:10.5539806Z Cache hits (C/C++)                  860
2022-07-12T17:04:10.5540106Z Cache misses                          2
2022-07-12T17:04:10.5540393Z Cache misses (C/C++)                  2

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

We can use the same paths in Bazel and fbcode. No need to add aliases. Differential Revision: [D36600018](https://our.internmc.facebook.com/intern/diff/D36600018/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36600018/)! [ghstack-poisoned]

Pull Request resolved: #78104 We can use the same paths in Bazel and fbcode. No need to add aliases. ghstack-source-id: 157069732 Differential Revision: [D36600018](https://our.internmc.facebook.com/intern/diff/D36600018/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36600018/)!

We can use the same paths in Bazel and fbcode. No need to add aliases. Differential Revision: [D36600018](https://our.internmc.facebook.com/intern/diff/D36600018/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36600018/)! [ghstack-poisoned]

Pull Request resolved: #78104 We can use the same paths in Bazel and fbcode. No need to add aliases. ghstack-source-id: 157069732 Differential Revision: [D36600018](https://our.internmc.facebook.com/intern/diff/D36600018/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36600018/)!

We can use the same paths in Bazel and fbcode. No need to add aliases. Differential Revision: [D36600018](https://our.internmc.facebook.com/intern/diff/D36600018/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36600018/)! [ghstack-poisoned]

Pull Request resolved: #78104 We can use the same paths in Bazel and fbcode. No need to add aliases. ghstack-source-id: 157069732 Differential Revision: [D36600018](https://our.internmc.facebook.com/intern/diff/D36600018/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36600018/)!

We can use the same paths in Bazel and fbcode. No need to add aliases. Differential Revision: [D36600018](https://our.internmc.facebook.com/intern/diff/D36600018/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36600018/)! [ghstack-poisoned]

Pull Request resolved: #78104 We can use the same paths in Bazel and fbcode. No need to add aliases. ghstack-source-id: 157069732 Differential Revision: [D36600018](https://our.internmc.facebook.com/intern/diff/D36600018/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36600018/)!

We can use the same paths in Bazel and fbcode. No need to add aliases. Differential Revision: [D36600018](https://our.internmc.facebook.com/intern/diff/D36600018/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36600018/)! [ghstack-poisoned]

Pull Request resolved: #78104 We can use the same paths in Bazel and fbcode. No need to add aliases. ghstack-source-id: 157069732 Differential Revision: [D36600018](https://our.internmc.facebook.com/intern/diff/D36600018/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36600018/)!

We can use the same paths in Bazel and fbcode. No need to add aliases. Differential Revision: [D36600018](https://our.internmc.facebook.com/intern/diff/D36600018/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36600018/)! [ghstack-poisoned]

github-actions · 2022-09-10T20:37:29Z

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

facebook-github-bot · 2022-10-04T01:04:03Z

/easycla

As part of the transition to the PyTorch Foundation, this project now requires contributions be covered under the new CLA. See #85559 for additional details.

This comment will trigger a new check of this PR. If you are already covered, you will simply see a new "EasyCLA" check that passes. If you are not covered, a bot will leave a new comment with a link to sign.

linux-foundation-easycla · 2022-10-04T01:04:10Z

❌ - login: @dagitses . The commit (6ca81e3, 43bc255, f3d62a5, 639d5eb, 84878c7, 004f6af, b51b3f4, 2413b66, f0032da, ea97401, 5fe5096, 2d3d154, 4f7b1ba, 03648f0, 90c440a, e1c552f, 8546873, 920c796) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.

facebook-github-bot added the cla signed label May 23, 2022

dagitses mentioned this pull request May 31, 2022

extract aten_core_srcs function into shared build structure #78535

Closed

dagitses mentioned this pull request May 31, 2022

move pytorch-root/tools/build_variables.bzl to the pytorch-root #78542

Closed

Michael Andreas Dagitses added 2 commits June 2, 2022 13:23

This was referenced Jun 17, 2022

gen_aten output into aten/src/ATen/ #79727

Closed

switch Bazel to common aten codegen #79783

Closed

Michael Andreas Dagitses added 6 commits June 20, 2022 08:09

dagitses mentioned this pull request Jul 6, 2022

yaml resources test #80961

Closed

Michael Andreas Dagitses added 2 commits July 8, 2022 07:25

github-actions Bot added the Stale label Sep 10, 2022

github-actions Bot closed this Nov 3, 2022

dagitses deleted the gh/dagitses/352/head branch November 19, 2022 03:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

use full paths to files to generate-code genrule#78104

use full paths to files to generate-code genrule#78104
dagitses wants to merge 18 commits into
gh/dagitses/352/basefrom
gh/dagitses/352/head

dagitses commented May 23, 2022 •

edited

Loading

Uh oh!

facebook-github-bot commented May 23, 2022 •

edited

Loading

🕵️ 1 new failure recognized by patterns

pull / linux-xenial-cuda11.3-py3.7-gcc7-bazel-test / build-and-test (1/1)

Uh oh!

github-actions Bot commented Sep 10, 2022

Uh oh!

facebook-github-bot commented Oct 4, 2022

Uh oh!

linux-foundation-easycla Bot commented Oct 4, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

dagitses commented May 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented May 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful links

❌ 1 New Failures, 1 Pending

🕵️ 1 new failure recognized by patterns

pull / linux-xenial-cuda11.3-py3.7-gcc7-bazel-test / build-and-test (1/1)

Uh oh!

github-actions Bot commented Sep 10, 2022

Uh oh!

facebook-github-bot commented Oct 4, 2022

Uh oh!

linux-foundation-easycla Bot commented Oct 4, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

dagitses commented May 23, 2022 •

edited

Loading

facebook-github-bot commented May 23, 2022 •

edited

Loading