Skip to content

move fbcode ATEN_CORE_H to shared build structure#77863

Closed
dagitses wants to merge 33 commits into
gh/dagitses/345/basefrom
gh/dagitses/345/head
Closed

move fbcode ATEN_CORE_H to shared build structure#77863
dagitses wants to merge 33 commits into
gh/dagitses/345/basefrom
gh/dagitses/345/head

Conversation

@dagitses

@dagitses dagitses commented May 19, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Stack from ghstack (oldest at bottom):

We're about to start using this in Bazel.

Differential Revision: D36521516

NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!

move fbcode ATEN_CORE_H to shared build structure
7856cdf 
We're about to start using this in Bazel.

Differential Revision: [D36521516](https://our.internmc.facebook.com/intern/diff/D36521516/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36521516/)!

[ghstack-poisoned]
@facebook-github-bot

facebook-github-bot commented May 19, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit b5bdf47 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

This was referenced May 19, 2022
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Michael Andreas Dagitses added 6 commits May 19, 2022 10:58
Update on "move fbcode ATEN_CORE_H to shared build structure"
5c5023c 
We're about to start using this in Bazel.

Differential Revision: [D36521516](https://our.internmc.facebook.com/intern/diff/D36521516/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36521516/)!

[ghstack-poisoned]
Update on "move fbcode ATEN_CORE_H to shared build structure"
1681e73 
We're about to start using this in Bazel.

Differential Revision: [D36521516](https://our.internmc.facebook.com/intern/diff/D36521516/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36521516/)!

[ghstack-poisoned]
Update on "move fbcode ATEN_CORE_H to shared build structure"
1b65be0 
We're about to start using this in Bazel.

Differential Revision: [D36521516](https://our.internmc.facebook.com/intern/diff/D36521516/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36521516/)!

[ghstack-poisoned]
Update on "move fbcode ATEN_CORE_H to shared build structure"
7e6d791 
We're about to start using this in Bazel.

Differential Revision: [D36521516](https://our.internmc.facebook.com/intern/diff/D36521516/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36521516/)!

[ghstack-poisoned]
Update on "move fbcode ATEN_CORE_H to shared build structure"
b9679cf 
We're about to start using this in Bazel.

Differential Revision: [D36521516](https://our.internmc.facebook.com/intern/diff/D36521516/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36521516/)!

[ghstack-poisoned]
Update on "move fbcode ATEN_CORE_H to shared build structure"
bf0d2a4 
We're about to start using this in Bazel.

Differential Revision: [D36521516](https://our.internmc.facebook.com/intern/diff/D36521516/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36521516/)!

[ghstack-poisoned]
This was referenced May 23, 2022
Closed
Closed
Michael Andreas Dagitses added 6 commits May 23, 2022 07:13
Update on "move fbcode ATEN_CORE_H to shared build structure"
6638b15 
We're about to start using this in Bazel.

Differential Revision: [D36521516](https://our.internmc.facebook.com/intern/diff/D36521516/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36521516/)!

[ghstack-poisoned]
Update on "move fbcode ATEN_CORE_H to shared build structure"
2b4627c 
We're about to start using this in Bazel.

Differential Revision: [D36521516](https://our.internmc.facebook.com/intern/diff/D36521516/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36521516/)!

[ghstack-poisoned]
Update on "move fbcode ATEN_CORE_H to shared build structure"
c56daf4 
We're about to start using this in Bazel.

Differential Revision: [D36521516](https://our.internmc.facebook.com/intern/diff/D36521516/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36521516/)!

[ghstack-poisoned]
Update on "move fbcode ATEN_CORE_H to shared build structure"
1471071 
We're about to start using this in Bazel.

Differential Revision: [D36521516](https://our.internmc.facebook.com/intern/diff/D36521516/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36521516/)!

[ghstack-poisoned]
Update on "move fbcode ATEN_CORE_H to shared build structure"
e0cfed8 
We're about to start using this in Bazel.

Differential Revision: [D36521516](https://our.internmc.facebook.com/intern/diff/D36521516/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36521516/)!

[ghstack-poisoned]
Update on "move fbcode ATEN_CORE_H to shared build structure"
eadbcba 
We're about to start using this in Bazel.

Differential Revision: [D36521516](https://our.internmc.facebook.com/intern/diff/D36521516/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36521516/)!

[ghstack-poisoned]
@dagitses dagitses mentioned this pull request May 23, 2022
Closed
Michael Andreas Dagitses added 6 commits May 23, 2022 10:36
Update on "move fbcode ATEN_CORE_H to shared build structure"
2bcc3d1 
We're about to start using this in Bazel.

Differential Revision: [D36521516](https://our.internmc.facebook.com/intern/diff/D36521516/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36521516/)!

[ghstack-poisoned]
Update on "move fbcode ATEN_CORE_H to shared build structure"
5b5a839 
We're about to start using this in Bazel.

Differential Revision: [D36521516](https://our.internmc.facebook.com/intern/diff/D36521516/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36521516/)!

[ghstack-poisoned]
Update on "move fbcode ATEN_CORE_H to shared build structure"
f19ea4f 
We're about to start using this in Bazel.

Differential Revision: [D36521516](https://our.internmc.facebook.com/intern/diff/D36521516/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36521516/)!

[ghstack-poisoned]
Update on "move fbcode ATEN_CORE_H to shared build structure"
8362142 
We're about to start using this in Bazel.

Differential Revision: [D36521516](https://our.internmc.facebook.com/intern/diff/D36521516/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36521516/)!

[ghstack-poisoned]
Update on "move fbcode ATEN_CORE_H to shared build structure"
4767e25 
We're about to start using this in Bazel.

Differential Revision: [D36521516](https://our.internmc.facebook.com/intern/diff/D36521516/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36521516/)!

[ghstack-poisoned]
Update on "move fbcode ATEN_CORE_H to shared build structure"
ea71dd5 
We're about to start using this in Bazel.

Differential Revision: [D36521516](https://our.internmc.facebook.com/intern/diff/D36521516/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36521516/)!

[ghstack-poisoned]
@dagitses dagitses mentioned this pull request May 31, 2022
Closed
Update on "move fbcode ATEN_CORE_H to shared build structure"
6fc6e52 
We're about to start using this in Bazel.

Differential Revision: [D36521516](https://our.internmc.facebook.com/intern/diff/D36521516/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36521516/)!

[ghstack-poisoned]
@dagitses dagitses mentioned this pull request May 31, 2022
Closed
Update on "move fbcode ATEN_CORE_H to shared build structure"
e58401d 
We're about to start using this in Bazel.

Differential Revision: [D36521516](https://our.internmc.facebook.com/intern/diff/D36521516/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36521516/)!

[ghstack-poisoned]
@kit1980 kit1980 added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 3, 2022
Update on "move fbcode ATEN_CORE_H to shared build structure"
d9bdfef 
We're about to start using this in Bazel.

Differential Revision: [D36521516](https://our.internmc.facebook.com/intern/diff/D36521516/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36521516/)!

[ghstack-poisoned]
This was referenced Jun 17, 2022
Closed
Closed
Michael Andreas Dagitses added 6 commits June 20, 2022 08:09
Update on "move fbcode ATEN_CORE_H to shared build structure"
e862d9c 
We're about to start using this in Bazel.

Differential Revision: [D36521516](https://our.internmc.facebook.com/intern/diff/D36521516/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36521516/)!

[ghstack-poisoned]
Update on "move fbcode ATEN_CORE_H to shared build structure"
b83d3cb 
We're about to start using this in Bazel.

Differential Revision: [D36521516](https://our.internmc.facebook.com/intern/diff/D36521516/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36521516/)!

[ghstack-poisoned]
Update on "move fbcode ATEN_CORE_H to shared build structure"
d8703b7 
We're about to start using this in Bazel.

Differential Revision: [D36521516](https://our.internmc.facebook.com/intern/diff/D36521516/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36521516/)!

[ghstack-poisoned]
Update on "move fbcode ATEN_CORE_H to shared build structure"
0dc7d07 
We're about to start using this in Bazel.

Differential Revision: [D36521516](https://our.internmc.facebook.com/intern/diff/D36521516/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36521516/)!

[ghstack-poisoned]
Update on "move fbcode ATEN_CORE_H to shared build structure"
e56d5e3 
We're about to start using this in Bazel.

Differential Revision: [D36521516](https://our.internmc.facebook.com/intern/diff/D36521516/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36521516/)!

[ghstack-poisoned]
Update on "move fbcode ATEN_CORE_H to shared build structure"
37cae7b 
We're about to start using this in Bazel.

Differential Revision: [D36521516](https://our.internmc.facebook.com/intern/diff/D36521516/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36521516/)!

[ghstack-poisoned]
@dagitses dagitses mentioned this pull request Jul 6, 2022
Closed
Michael Andreas Dagitses added 2 commits July 8, 2022 07:25
Update on "move fbcode ATEN_CORE_H to shared build structure"
a48409e 
We're about to start using this in Bazel.

Differential Revision: [D36521516](https://our.internmc.facebook.com/intern/diff/D36521516/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36521516/)!

[ghstack-poisoned]
Update on "move fbcode ATEN_CORE_H to shared build structure"
b5bdf47 
We're about to start using this in Bazel.

Differential Revision: [D36521516](https://our.internmc.facebook.com/intern/diff/D36521516/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36521516/)!

[ghstack-poisoned]
@github-actions

github-actions Bot commented Sep 11, 2022

Copy link
Copy Markdown
Contributor

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions Bot added the Stale label Sep 11, 2022
@facebook-github-bot

facebook-github-bot commented Oct 4, 2022

Copy link
Copy Markdown
Contributor

/easycla

As part of the transition to the PyTorch Foundation, this project now requires contributions be covered under the new CLA. See #85559 for additional details.

This comment will trigger a new check of this PR. If you are already covered, you will simply see a new "EasyCLA" check that passes. If you are not covered, a bot will leave a new comment with a link to sign.

@linux-foundation-easycla

linux-foundation-easycla Bot commented Oct 4, 2022

Copy link
Copy Markdown

CLA Not Signed

@github-actions github-actions Bot closed this Nov 3, 2022
@dagitses dagitses deleted the gh/dagitses/345/head branch November 19, 2022 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request cla signed Stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dagitses @facebook-github-bot @kit1980