switch aten_headers to use strip_include_prefix instead of includes by dagitses · Pull Request #77865 · pytorch/pytorch

dagitses · 2022-05-19T17:53:04Z

Stack from ghstack (oldest at bottom):

This is Bazel best practices and easier to maintain.

Differential Revision: D36521515

This is Bazel best practices and easier to maintain. Differential Revision: [D36521515](https://our.internmc.facebook.com/intern/diff/D36521515/) [ghstack-poisoned]

facebook-github-bot · 2022-05-19T17:53:17Z

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/77865
📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓Need help or want to give feedback on the CI? Visit our office hours
↩️ [fb-only] Re-run with SSH instructions

❌ 1 New Failures

As of commit 0940115 (more details on the Dr. CI page):

Expand to see more

1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages

pull / linux-xenial-cuda11.3-py3.7-gcc7-bazel-test / build-and-test (1/1)

Step: "Build" (full log | diagnosis details | 🔁 rerun)

2022-07-12T17:10:42.7991779Z �[0m�[1m�[31mERROR...c1plus: some warnings being treated as errors\n" }

2022-07-12T17:10:42.7224612Z �[32mINFO: �[0mElapsed time: 85.530s, Critical Path: 22.74s
2022-07-12T17:10:42.7235054Z �[32mINFO: �[0m1140 processes: 861 internal, 1 local, 278 processwrapper-sandbox.
2022-07-12T17:10:42.7239282Z �[31m�[1mFAILED:�[0m Build did NOT complete successfully
2022-07-12T17:10:42.7458736Z �[31m�[1mFAILED:�[0m Build did NOT complete successfully
2022-07-12T17:10:42.7709579Z �[0m+ sccache_epilogue
2022-07-12T17:10:42.7710165Z + echo '::group::Sccache Compilation Log'
2022-07-12T17:10:42.7711178Z ##[group]Sccache Compilation Log
2022-07-12T17:10:42.7711739Z + echo '=================== sccache compilation log ==================='
2022-07-12T17:10:42.7712167Z =================== sccache compilation log ===================
2022-07-12T17:10:42.7712687Z + python /var/lib/jenkins/workspace/.jenkins/pytorch/print_sccache_log.py /var/lib/jenkins/sccache_error.log
2022-07-12T17:10:42.7991779Z �[0m�[1m�[31mERROR�[0m 2022-07-12T17:10:42Z: sccache::server: Compilation failed: Output { status: ExitStatus(ExitStatus(256)), stdout: "", stderr: "In file included from bazel-out/k8-fastbuild/bin/_virtual_includes/aten_headers/ATen/native/CPUBlas.h:3:0,\n                 from bazel-out/k8-fastbuild/bin/aten/src/ATen/native/cpu/BlasKernel.cpp.DEFAULT.cpp:3:\nbazel-out/k8-fastbuild/bin/_virtual_includes/aten_headers/ATen/OpMathType.h:33:17: error: \'c10::ScalarType at::{anonymous}::toOpMathType(c10::ScalarType)\' defined but not used [-Werror=unused-function]\n c10::ScalarType toOpMathType(const c10::ScalarType type) {\n                 ^~~~~~~~~~~~\ncc1plus: some warnings being treated as errors\n" }
2022-07-12T17:10:42.7993202Z 
2022-07-12T17:10:42.8016859Z + echo '=========== If your build fails, please take a look at the log above for possible reasons ==========='
2022-07-12T17:10:42.8018122Z =========== If your build fails, please take a look at the log above for possible reasons ===========
2022-07-12T17:10:42.8019560Z + sccache --show-stats
2022-07-12T17:10:42.8137123Z Compile requests                    193
2022-07-12T17:10:42.8138300Z Compile requests executed           181
2022-07-12T17:10:42.8139673Z Cache hits                          166
2022-07-12T17:10:42.8141043Z Cache hits (C/C++)                  166
2022-07-12T17:10:42.8142385Z Cache misses                          0
2022-07-12T17:10:42.8143746Z Cache timeouts                        0

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

… includes" This is Bazel best practices and easier to maintain. Differential Revision: [D36521515](https://our.internmc.facebook.com/intern/diff/D36521515/) [ghstack-poisoned]

Pull Request resolved: #77865 This is Bazel best practices and easier to maintain. ghstack-source-id: 156812099 Differential Revision: [D36521515](https://our.internmc.facebook.com/intern/diff/D36521515/)

… includes" This is Bazel best practices and easier to maintain. Differential Revision: [D36521515](https://our.internmc.facebook.com/intern/diff/D36521515/) [ghstack-poisoned]

Pull Request resolved: #77865 This is Bazel best practices and easier to maintain. ghstack-source-id: 156812099 Differential Revision: [D36521515](https://our.internmc.facebook.com/intern/diff/D36521515/)

… includes" This is Bazel best practices and easier to maintain. Differential Revision: [D36521515](https://our.internmc.facebook.com/intern/diff/D36521515/) [ghstack-poisoned]

Pull Request resolved: #77865 This is Bazel best practices and easier to maintain. ghstack-source-id: 156812099 Differential Revision: [D36521515](https://our.internmc.facebook.com/intern/diff/D36521515/)

… includes" This is Bazel best practices and easier to maintain. Differential Revision: [D36521515](https://our.internmc.facebook.com/intern/diff/D36521515/) [ghstack-poisoned]

github-actions · 2022-09-10T20:37:25Z

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

facebook-github-bot · 2022-10-04T01:04:37Z

/easycla

As part of the transition to the PyTorch Foundation, this project now requires contributions be covered under the new CLA. See #85559 for additional details.

This comment will trigger a new check of this PR. If you are already covered, you will simply see a new "EasyCLA" check that passes. If you are not covered, a bot will leave a new comment with a link to sign.

linux-foundation-easycla · 2022-10-04T01:04:48Z

❌ - login: @dagitses . The commit (09b61a1, fa4a98f, 4121fd1, 43e59d1, d857401, 677fb76, 88920c6, 31c7e67, 16182c1, 26f0033, 6291a07, 3337f94, 193a95d, 7b5f809, a8eb510, 170e627, fe621e9, b7920b6, 032bdbd, e19bbd7, e7d898b, 4e240aa, 21d4b2b, abf06d3, 89dbd9f, 1f6d88e, 5747b3c, a4c6592, c3a9eba, 44fb736, 0859106, f9701e8, 0940115) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.

switch aten_headers to use strip_include_prefix instead of includes

09b61a1

This is Bazel best practices and easier to maintain. Differential Revision: [D36521515](https://our.internmc.facebook.com/intern/diff/D36521515/) [ghstack-poisoned]

facebook-github-bot added the cla signed label May 19, 2022

Update on "switch aten_headers to use strip_include_prefix instead of…

fa4a98f

… includes" This is Bazel best practices and easier to maintain. Differential Revision: [D36521515](https://our.internmc.facebook.com/intern/diff/D36521515/) [ghstack-poisoned]

Update on "switch aten_headers to use strip_include_prefix instead of…

4121fd1

… includes" This is Bazel best practices and easier to maintain. Differential Revision: [D36521515](https://our.internmc.facebook.com/intern/diff/D36521515/) [ghstack-poisoned]

Update on "switch aten_headers to use strip_include_prefix instead of…

43e59d1

… includes" This is Bazel best practices and easier to maintain. Differential Revision: [D36521515](https://our.internmc.facebook.com/intern/diff/D36521515/) [ghstack-poisoned]

Update on "switch aten_headers to use strip_include_prefix instead of…

d857401

… includes" This is Bazel best practices and easier to maintain. Differential Revision: [D36521515](https://our.internmc.facebook.com/intern/diff/D36521515/) [ghstack-poisoned]

Update on "switch aten_headers to use strip_include_prefix instead of…

677fb76

… includes" This is Bazel best practices and easier to maintain. Differential Revision: [D36521515](https://our.internmc.facebook.com/intern/diff/D36521515/) [ghstack-poisoned]

Update on "switch aten_headers to use strip_include_prefix instead of…

88920c6

… includes" This is Bazel best practices and easier to maintain. Differential Revision: [D36521515](https://our.internmc.facebook.com/intern/diff/D36521515/) [ghstack-poisoned]

This was referenced May 23, 2022

remove Bazel globs that don't match any files #78007

Closed

canonicalize includes of form <aten/src/ATen/...> #78033

Closed

Update on "switch aten_headers to use strip_include_prefix instead of…

170e627

… includes" This is Bazel best practices and easier to maintain. Differential Revision: [D36521515](https://our.internmc.facebook.com/intern/diff/D36521515/) [ghstack-poisoned]

dagitses mentioned this pull request May 23, 2022

use full paths to files to generate-code genrule #78104

Closed

Michael Andreas Dagitses added 6 commits May 23, 2022 10:36

Update on "switch aten_headers to use strip_include_prefix instead of…

fe621e9

… includes" This is Bazel best practices and easier to maintain. Differential Revision: [D36521515](https://our.internmc.facebook.com/intern/diff/D36521515/) [ghstack-poisoned]

Update on "switch aten_headers to use strip_include_prefix instead of…

b7920b6

… includes" This is Bazel best practices and easier to maintain. Differential Revision: [D36521515](https://our.internmc.facebook.com/intern/diff/D36521515/) [ghstack-poisoned]

Update on "switch aten_headers to use strip_include_prefix instead of…

032bdbd

… includes" This is Bazel best practices and easier to maintain. Differential Revision: [D36521515](https://our.internmc.facebook.com/intern/diff/D36521515/) [ghstack-poisoned]

Update on "switch aten_headers to use strip_include_prefix instead of…

e19bbd7

… includes" This is Bazel best practices and easier to maintain. Differential Revision: [D36521515](https://our.internmc.facebook.com/intern/diff/D36521515/) [ghstack-poisoned]

Update on "switch aten_headers to use strip_include_prefix instead of…

e7d898b

… includes" This is Bazel best practices and easier to maintain. Differential Revision: [D36521515](https://our.internmc.facebook.com/intern/diff/D36521515/) [ghstack-poisoned]

Update on "switch aten_headers to use strip_include_prefix instead of…

4e240aa

… includes" This is Bazel best practices and easier to maintain. Differential Revision: [D36521515](https://our.internmc.facebook.com/intern/diff/D36521515/) [ghstack-poisoned]

dagitses mentioned this pull request May 31, 2022

extract aten_core_srcs function into shared build structure #78535

Closed

Update on "switch aten_headers to use strip_include_prefix instead of…

21d4b2b

… includes" This is Bazel best practices and easier to maintain. Differential Revision: [D36521515](https://our.internmc.facebook.com/intern/diff/D36521515/) [ghstack-poisoned]

dagitses mentioned this pull request May 31, 2022

move pytorch-root/tools/build_variables.bzl to the pytorch-root #78542

Closed

Michael Andreas Dagitses added 2 commits June 2, 2022 13:23

Update on "switch aten_headers to use strip_include_prefix instead of…

abf06d3

… includes" This is Bazel best practices and easier to maintain. Differential Revision: [D36521515](https://our.internmc.facebook.com/intern/diff/D36521515/) [ghstack-poisoned]

Update on "switch aten_headers to use strip_include_prefix instead of…

89dbd9f

… includes" This is Bazel best practices and easier to maintain. Differential Revision: [D36521515](https://our.internmc.facebook.com/intern/diff/D36521515/) [ghstack-poisoned]

This was referenced Jun 17, 2022

gen_aten output into aten/src/ATen/ #79727

Closed

switch Bazel to common aten codegen #79783

Closed

Michael Andreas Dagitses added 6 commits June 20, 2022 08:09

Update on "switch aten_headers to use strip_include_prefix instead of…

1f6d88e

… includes" This is Bazel best practices and easier to maintain. Differential Revision: [D36521515](https://our.internmc.facebook.com/intern/diff/D36521515/) [ghstack-poisoned]

Update on "switch aten_headers to use strip_include_prefix instead of…

5747b3c

… includes" This is Bazel best practices and easier to maintain. Differential Revision: [D36521515](https://our.internmc.facebook.com/intern/diff/D36521515/) [ghstack-poisoned]

Update on "switch aten_headers to use strip_include_prefix instead of…

a4c6592

… includes" This is Bazel best practices and easier to maintain. Differential Revision: [D36521515](https://our.internmc.facebook.com/intern/diff/D36521515/) [ghstack-poisoned]

Update on "switch aten_headers to use strip_include_prefix instead of…

c3a9eba

… includes" This is Bazel best practices and easier to maintain. Differential Revision: [D36521515](https://our.internmc.facebook.com/intern/diff/D36521515/) [ghstack-poisoned]

Update on "switch aten_headers to use strip_include_prefix instead of…

44fb736

… includes" This is Bazel best practices and easier to maintain. Differential Revision: [D36521515](https://our.internmc.facebook.com/intern/diff/D36521515/) [ghstack-poisoned]

Update on "switch aten_headers to use strip_include_prefix instead of…

0859106

… includes" This is Bazel best practices and easier to maintain. Differential Revision: [D36521515](https://our.internmc.facebook.com/intern/diff/D36521515/) [ghstack-poisoned]

dagitses mentioned this pull request Jul 6, 2022

yaml resources test #80961

Closed

Michael Andreas Dagitses added 2 commits July 8, 2022 07:25

Update on "switch aten_headers to use strip_include_prefix instead of…

f9701e8

… includes" This is Bazel best practices and easier to maintain. Differential Revision: [D36521515](https://our.internmc.facebook.com/intern/diff/D36521515/) [ghstack-poisoned]

Update on "switch aten_headers to use strip_include_prefix instead of…

0940115

… includes" This is Bazel best practices and easier to maintain. Differential Revision: [D36521515](https://our.internmc.facebook.com/intern/diff/D36521515/) [ghstack-poisoned]

github-actions Bot added the Stale label Sep 10, 2022

github-actions Bot closed this Nov 3, 2022

dagitses deleted the gh/dagitses/347/head branch November 19, 2022 03:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

switch aten_headers to use strip_include_prefix instead of includes#77865

switch aten_headers to use strip_include_prefix instead of includes#77865
dagitses wants to merge 33 commits into
gh/dagitses/347/basefrom
gh/dagitses/347/head

dagitses commented May 19, 2022 •

edited

Loading

Uh oh!

facebook-github-bot commented May 19, 2022 •

edited

Loading

🕵️ 1 new failure recognized by patterns

pull / linux-xenial-cuda11.3-py3.7-gcc7-bazel-test / build-and-test (1/1)

Uh oh!

github-actions Bot commented Sep 10, 2022

Uh oh!

facebook-github-bot commented Oct 4, 2022

Uh oh!

linux-foundation-easycla Bot commented Oct 4, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

dagitses commented May 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented May 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful links

❌ 1 New Failures

🕵️ 1 new failure recognized by patterns

pull / linux-xenial-cuda11.3-py3.7-gcc7-bazel-test / build-and-test (1/1)

Uh oh!

github-actions Bot commented Sep 10, 2022

Uh oh!

facebook-github-bot commented Oct 4, 2022

Uh oh!

linux-foundation-easycla Bot commented Oct 4, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

dagitses commented May 19, 2022 •

edited

Loading

facebook-github-bot commented May 19, 2022 •

edited

Loading