Skip to content

switch Bazel to common aten codegen#77778

Closed
dagitses wants to merge 30 commits into
gh/dagitses/342/basefrom
gh/dagitses/342/head
Closed

switch Bazel to common aten codegen#77778
dagitses wants to merge 30 commits into
gh/dagitses/342/basefrom
gh/dagitses/342/head

Conversation

@dagitses

@dagitses dagitses commented May 18, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Stack from ghstack (oldest at bottom):

We can also clean up the other rule generation. This is removing
support for per-operator headers right now. We don't take advantage of
that internally, so it's better to have the Bazel build compatible
with our internal builds.

Differential Revision: D36489359

NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!

switch Bazel to common aten codegen
d0d8b42 
We can also clean up the other rule generation. This is removing
support for per-operator headers right now. We don't take advantage of
that internally, so it's better to have the Bazel build compatible
with our internal builds.

Differential Revision: [D36489359](https://our.internmc.facebook.com/intern/diff/D36489359/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36489359/)!

[ghstack-poisoned]
@facebook-github-bot

facebook-github-bot commented May 18, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

🔗 Helpful links

❌ 1 New Failures

As of commit 605639f (more details on the Dr. CI page):

Expand to see more
  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages

See GitHub Actions build pull / linux-xenial-cuda11.3-py3.7-gcc7 / test (default, 1, 4, linux.4xlarge.nvidia.gpu) (1/1)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

2022-06-02T22:24:37.4214813Z RuntimeError: test_ops failed! Received signal: SIGIOT 
2022-06-02T22:24:34.6563906Z /opt/conda/lib/python3.7/site-packages/torch/autograd/__init__.py:278: UserWarning: An output with one or more elements was resized since it had shape [], which does not match the required output shape [10, 5]. This behavior is deprecated, and in a future PyTorch release outputs will not be resized unless they have zero elements. You can explicitly reuse an out tensor t by resizing it, inplace, to zero elements with t.resize_(0). (Triggered internally at  /var/lib/jenkins/workspace/aten/src/ATen/native/Resize.cpp:24.)
2022-06-02T22:24:34.6565027Z   allow_unused, accumulate_grad=False)  # Calls into the C++ engine to run the backward pass
2022-06-02T22:24:34.6610397Z ok (0.027s)
2022-06-02T22:24:34.6763508Z   test_backward_nn_functional_multilabel_margin_loss_cuda_float32 (__main__.TestCompositeComplianceCUDA) ... ok (0.015s)
2022-06-02T22:24:34.8289531Z   test_backward_nn_functional_multilabel_soft_margin_loss_cuda_float32 (__main__.TestCompositeComplianceCUDA) ... ok (0.152s)
2022-06-02T22:24:37.4207494Z   test_backward_nn_functional_nll_loss_cuda_float32 (__main__.TestCompositeComplianceCUDA) ... Traceback (most recent call last):
2022-06-02T22:24:37.4208028Z   File "test/run_test.py", line 1077, in <module>
2022-06-02T22:24:37.4210997Z     main()
2022-06-02T22:24:37.4211295Z   File "test/run_test.py", line 1055, in main
2022-06-02T22:24:37.4214421Z     raise RuntimeError(err_message)
2022-06-02T22:24:37.4214813Z RuntimeError: test_ops failed! Received signal: SIGIOT
2022-06-02T22:24:38.5684044Z + cleanup
2022-06-02T22:24:38.5684417Z + retcode=1
2022-06-02T22:24:38.5685033Z + set +x
2022-06-02T22:24:38.5732611Z ##[error]Process completed with exit code 1.
2022-06-02T22:24:38.5778511Z ##[group]Run pytorch/pytorch/.github/actions/get-workflow-job-id@master
2022-06-02T22:24:38.5778880Z with:
2022-06-02T22:24:38.5779441Z   github-token: ***
2022-06-02T22:24:38.5779669Z env:
2022-06-02T22:24:38.5779887Z   IN_CI: 1
2022-06-02T22:24:38.5780114Z   IS_GHA: 1
This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

This was referenced May 18, 2022
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
dagitses pushed a commit that referenced this pull request May 18, 2022
switch Bazel to common aten codegen
7ea844c 
We can also clean up the other rule generation. This is removing
support for per-operator headers right now. We don't take advantage of
that internally, so it's better to have the Bazel build compatible
with our internal builds.

Differential Revision: [D36489359](https://our.internmc.facebook.com/intern/diff/D36489359/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36489359/)!

ghstack-source-id: 156704036
Pull Request resolved: #77778
Update on "switch Bazel to common aten codegen"
8aef799 
We can also clean up the other rule generation. This is removing
support for per-operator headers right now. We don't take advantage of
that internally, so it's better to have the Bazel build compatible
with our internal builds.

Differential Revision: [D36489359](https://our.internmc.facebook.com/intern/diff/D36489359/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36489359/)!

[ghstack-poisoned]
@dagitses dagitses mentioned this pull request May 18, 2022
Closed
Update on "switch Bazel to common aten codegen"
41e374f 
We can also clean up the other rule generation. This is removing
support for per-operator headers right now. We don't take advantage of
that internally, so it's better to have the Bazel build compatible
with our internal builds.

Differential Revision: [D36489359](https://our.internmc.facebook.com/intern/diff/D36489359/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36489359/)!

[ghstack-poisoned]
@dagitses dagitses mentioned this pull request May 18, 2022
Closed
Michael Andreas Dagitses added 4 commits May 18, 2022 14:11
Update on "switch Bazel to common aten codegen"
c26cf57 
We can also clean up the other rule generation. This is removing
support for per-operator headers right now. We don't take advantage of
that internally, so it's better to have the Bazel build compatible
with our internal builds.

Differential Revision: [D36489359](https://our.internmc.facebook.com/intern/diff/D36489359/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36489359/)!

[ghstack-poisoned]
Update on "switch Bazel to common aten codegen"
c04c6d4 
We can also clean up the other rule generation. This is removing
support for per-operator headers right now. We don't take advantage of
that internally, so it's better to have the Bazel build compatible
with our internal builds.

Differential Revision: [D36489359](https://our.internmc.facebook.com/intern/diff/D36489359/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36489359/)!

[ghstack-poisoned]
Update on "switch Bazel to common aten codegen"
bcd5f27 
We can also clean up the other rule generation. This is removing
support for per-operator headers right now. We don't take advantage of
that internally, so it's better to have the Bazel build compatible
with our internal builds.

Differential Revision: [D36489359](https://our.internmc.facebook.com/intern/diff/D36489359/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36489359/)!

[ghstack-poisoned]
Update on "switch Bazel to common aten codegen"
c1913a6 
We can also clean up the other rule generation. This is removing
support for per-operator headers right now. We don't take advantage of
that internally, so it's better to have the Bazel build compatible
with our internal builds.

Differential Revision: [D36489359](https://our.internmc.facebook.com/intern/diff/D36489359/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36489359/)!

[ghstack-poisoned]
This was referenced May 19, 2022
Closed
Closed
Closed
Michael Andreas Dagitses added 6 commits May 19, 2022 10:58
Update on "switch Bazel to common aten codegen"
49fe56e 
We can also clean up the other rule generation. This is removing
support for per-operator headers right now. We don't take advantage of
that internally, so it's better to have the Bazel build compatible
with our internal builds.

Differential Revision: [D36489359](https://our.internmc.facebook.com/intern/diff/D36489359/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36489359/)!

[ghstack-poisoned]
Update on "switch Bazel to common aten codegen"
2fb8fb5 
We can also clean up the other rule generation. This is removing
support for per-operator headers right now. We don't take advantage of
that internally, so it's better to have the Bazel build compatible
with our internal builds.

Differential Revision: [D36489359](https://our.internmc.facebook.com/intern/diff/D36489359/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36489359/)!

[ghstack-poisoned]
Update on "switch Bazel to common aten codegen"
51b750a 
We can also clean up the other rule generation. This is removing
support for per-operator headers right now. We don't take advantage of
that internally, so it's better to have the Bazel build compatible
with our internal builds.

Differential Revision: [D36489359](https://our.internmc.facebook.com/intern/diff/D36489359/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36489359/)!

[ghstack-poisoned]
Update on "switch Bazel to common aten codegen"
d6255c6 
We can also clean up the other rule generation. This is removing
support for per-operator headers right now. We don't take advantage of
that internally, so it's better to have the Bazel build compatible
with our internal builds.

Differential Revision: [D36489359](https://our.internmc.facebook.com/intern/diff/D36489359/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36489359/)!

[ghstack-poisoned]
Update on "switch Bazel to common aten codegen"
b29c14d 
We can also clean up the other rule generation. This is removing
support for per-operator headers right now. We don't take advantage of
that internally, so it's better to have the Bazel build compatible
with our internal builds.

Differential Revision: [D36489359](https://our.internmc.facebook.com/intern/diff/D36489359/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36489359/)!

[ghstack-poisoned]
Update on "switch Bazel to common aten codegen"
3e286a6 
We can also clean up the other rule generation. This is removing
support for per-operator headers right now. We don't take advantage of
that internally, so it's better to have the Bazel build compatible
with our internal builds.

Differential Revision: [D36489359](https://our.internmc.facebook.com/intern/diff/D36489359/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36489359/)!

[ghstack-poisoned]
This was referenced May 23, 2022
Closed
Closed
Michael Andreas Dagitses added 6 commits May 23, 2022 07:13
Update on "switch Bazel to common aten codegen"
5e78d4a 
We can also clean up the other rule generation. This is removing
support for per-operator headers right now. We don't take advantage of
that internally, so it's better to have the Bazel build compatible
with our internal builds.

Differential Revision: [D36489359](https://our.internmc.facebook.com/intern/diff/D36489359/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36489359/)!

[ghstack-poisoned]
Update on "switch Bazel to common aten codegen"
a80229e 
We can also clean up the other rule generation. This is removing
support for per-operator headers right now. We don't take advantage of
that internally, so it's better to have the Bazel build compatible
with our internal builds.

Differential Revision: [D36489359](https://our.internmc.facebook.com/intern/diff/D36489359/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36489359/)!

[ghstack-poisoned]
Update on "switch Bazel to common aten codegen"
81236d5 
We can also clean up the other rule generation. This is removing
support for per-operator headers right now. We don't take advantage of
that internally, so it's better to have the Bazel build compatible
with our internal builds.

Differential Revision: [D36489359](https://our.internmc.facebook.com/intern/diff/D36489359/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36489359/)!

[ghstack-poisoned]
Update on "switch Bazel to common aten codegen"
8c1f32a 
We can also clean up the other rule generation. This is removing
support for per-operator headers right now. We don't take advantage of
that internally, so it's better to have the Bazel build compatible
with our internal builds.

Differential Revision: [D36489359](https://our.internmc.facebook.com/intern/diff/D36489359/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36489359/)!

[ghstack-poisoned]
Update on "switch Bazel to common aten codegen"
0c9d6e8 
We can also clean up the other rule generation. This is removing
support for per-operator headers right now. We don't take advantage of
that internally, so it's better to have the Bazel build compatible
with our internal builds.

Differential Revision: [D36489359](https://our.internmc.facebook.com/intern/diff/D36489359/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36489359/)!

[ghstack-poisoned]
Update on "switch Bazel to common aten codegen"
add0f8d 
We can also clean up the other rule generation. This is removing
support for per-operator headers right now. We don't take advantage of
that internally, so it's better to have the Bazel build compatible
with our internal builds.

Differential Revision: [D36489359](https://our.internmc.facebook.com/intern/diff/D36489359/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36489359/)!

[ghstack-poisoned]
@dagitses dagitses mentioned this pull request May 23, 2022
Closed
Update on "switch Bazel to common aten codegen"
f15cab1 
We can also clean up the other rule generation. This is removing
support for per-operator headers right now. We don't take advantage of
that internally, so it's better to have the Bazel build compatible
with our internal builds.

Differential Revision: [D36489359](https://our.internmc.facebook.com/intern/diff/D36489359/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36489359/)!

[ghstack-poisoned]
@dagitses dagitses mentioned this pull request May 23, 2022
Closed
Michael Andreas Dagitses added 2 commits May 23, 2022 09:59
Update on "switch Bazel to common aten codegen"
fcf1b89 
We can also clean up the other rule generation. This is removing
support for per-operator headers right now. We don't take advantage of
that internally, so it's better to have the Bazel build compatible
with our internal builds.

Differential Revision: [D36489359](https://our.internmc.facebook.com/intern/diff/D36489359/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36489359/)!

[ghstack-poisoned]
Update on "switch Bazel to common aten codegen"
21073a1 
We can also clean up the other rule generation. This is removing
support for per-operator headers right now. We don't take advantage of
that internally, so it's better to have the Bazel build compatible
with our internal builds.

Differential Revision: [D36489359](https://our.internmc.facebook.com/intern/diff/D36489359/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36489359/)!

[ghstack-poisoned]
@dagitses dagitses mentioned this pull request May 23, 2022
Closed
Michael Andreas Dagitses added 6 commits May 23, 2022 10:36
Update on "switch Bazel to common aten codegen"
47543eb 
We can also clean up the other rule generation. This is removing
support for per-operator headers right now. We don't take advantage of
that internally, so it's better to have the Bazel build compatible
with our internal builds.

Differential Revision: [D36489359](https://our.internmc.facebook.com/intern/diff/D36489359/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36489359/)!

[ghstack-poisoned]
Update on "switch Bazel to common aten codegen"
2b07c85 
We can also clean up the other rule generation. This is removing
support for per-operator headers right now. We don't take advantage of
that internally, so it's better to have the Bazel build compatible
with our internal builds.

Differential Revision: [D36489359](https://our.internmc.facebook.com/intern/diff/D36489359/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36489359/)!

[ghstack-poisoned]
Update on "switch Bazel to common aten codegen"
46064ce 
We can also clean up the other rule generation. This is removing
support for per-operator headers right now. We don't take advantage of
that internally, so it's better to have the Bazel build compatible
with our internal builds.

Differential Revision: [D36489359](https://our.internmc.facebook.com/intern/diff/D36489359/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36489359/)!

[ghstack-poisoned]
Update on "switch Bazel to common aten codegen"
6dac181 
We can also clean up the other rule generation. This is removing
support for per-operator headers right now. We don't take advantage of
that internally, so it's better to have the Bazel build compatible
with our internal builds.

Differential Revision: [D36489359](https://our.internmc.facebook.com/intern/diff/D36489359/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36489359/)!

[ghstack-poisoned]
Update on "switch Bazel to common aten codegen"
3c81551 
We can also clean up the other rule generation. This is removing
support for per-operator headers right now. We don't take advantage of
that internally, so it's better to have the Bazel build compatible
with our internal builds.

Differential Revision: [D36489359](https://our.internmc.facebook.com/intern/diff/D36489359/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36489359/)!

[ghstack-poisoned]
Update on "switch Bazel to common aten codegen"
661bbf2 
We can also clean up the other rule generation. This is removing
support for per-operator headers right now. We don't take advantage of
that internally, so it's better to have the Bazel build compatible
with our internal builds.

Differential Revision: [D36489359](https://our.internmc.facebook.com/intern/diff/D36489359/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36489359/)!

[ghstack-poisoned]
@dagitses dagitses mentioned this pull request May 31, 2022
Closed
Update on "switch Bazel to common aten codegen"
223a734 
We can also clean up the other rule generation. This is removing
support for per-operator headers right now. We don't take advantage of
that internally, so it's better to have the Bazel build compatible
with our internal builds.

Differential Revision: [D36489359](https://our.internmc.facebook.com/intern/diff/D36489359/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36489359/)!

[ghstack-poisoned]
@dagitses dagitses mentioned this pull request May 31, 2022
Closed
Update on "switch Bazel to common aten codegen"
605639f 
We can also clean up the other rule generation. This is removing
support for per-operator headers right now. We don't take advantage of
that internally, so it's better to have the Bazel build compatible
with our internal builds.

Differential Revision: [D36489359](https://our.internmc.facebook.com/intern/diff/D36489359/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36489359/)!

[ghstack-poisoned]
@dagitses dagitses closed this Jun 16, 2022
@dagitses dagitses deleted the gh/dagitses/342/head branch June 16, 2022 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dagitses @facebook-github-bot