use ufunc_defs.bzl in BUILD.bazel by dagitses · Pull Request #77747 · pytorch/pytorch

dagitses · 2022-05-18T15:34:48Z

Stack from ghstack (oldest at bottom):

This allows us to remove some duplication in aten.bzl.

Differential Revision: D36481025

NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!

This allows us to remove some duplication in aten.bzl. Differential Revision: [D36481025](https://our.internmc.facebook.com/intern/diff/D36481025/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481025/)! [ghstack-poisoned]

facebook-github-bot · 2022-05-18T15:34:54Z

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/77747
📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓Need help or want to give feedback on the CI? Visit our office hours

✅ No Failures (0 Pending)

As of commit d56a132 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

This allows us to remove some duplication in aten.bzl. Differential Revision: [D36481025](https://our.internmc.facebook.com/intern/diff/D36481025/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481025/)! [ghstack-poisoned]

Pull Request resolved: #77747 This allows us to remove some duplication in aten.bzl. ghstack-source-id: 157009720 Differential Revision: [D36481025](https://our.internmc.facebook.com/intern/diff/D36481025/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481025/)!

This allows us to remove some duplication in aten.bzl. Differential Revision: [D36481025](https://our.internmc.facebook.com/intern/diff/D36481025/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481025/)! [ghstack-poisoned]

Pull Request resolved: #77747 This allows us to remove some duplication in aten.bzl. ghstack-source-id: 158991647 Differential Revision: [D36481025](https://our.internmc.facebook.com/intern/diff/D36481025/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481025/)!

This allows us to remove some duplication in aten.bzl. Differential Revision: [D36481025](https://our.internmc.facebook.com/intern/diff/D36481025/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481025/)! [ghstack-poisoned]

facebook-github-bot · 2022-06-16T07:52:28Z

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

pytorchmergebot · 2022-06-16T07:56:31Z

@pytorchbot successfully started a merge job. Check the current status here

github-actions · 2022-06-16T07:57:38Z

Hey @dagitses.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

Summary: Pull Request resolved: #77747 This allows us to remove some duplication in aten.bzl. ghstack-source-id: 159044901 Test Plan: Rely on CI. Reviewed By: seemethere Differential Revision: D36481025 fbshipit-source-id: e17aabd2e246382219b21a1408a03d577ac1fb4f

Pull Request resolved: pytorch#77747 This allows us to remove some duplication in aten.bzl. Differential Revision: [D36481025](https://our.internmc.facebook.com/intern/diff/D36481025/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481025/)! Approved by: https://github.com/seemethere

facebook-github-bot added the cla signed label May 18, 2022

dagitses mentioned this pull request May 18, 2022

move ufunc_defs.bzl to the top-level #77749

Closed

Michael Andreas Dagitses added 2 commits May 18, 2022 08:57

dagitses mentioned this pull request May 18, 2022

move gen_aten and gen_aten_hip into shared build structure #77751

Closed

Michael Andreas Dagitses added 5 commits May 18, 2022 09:17

dagitses mentioned this pull request May 18, 2022

gen_aten output into aten/src/ATen/ #77773

Closed

Michael Andreas Dagitses added 2 commits May 18, 2022 12:02

dagitses mentioned this pull request May 18, 2022

switch Bazel to common aten codegen #77778

Closed

dagitses mentioned this pull request May 18, 2022

gen_aten uses full paths to aten files #77788

Closed

dagitses mentioned this pull request May 18, 2022

eliminate generated_cpu_cpp and generated_cuda_cpp from Bazel #77790

Closed

dagitses mentioned this pull request May 23, 2022

move the GENERATED_CORE_H headers into aten_core_headers #78097

Closed

Michael Andreas Dagitses added 2 commits May 23, 2022 09:58

dagitses mentioned this pull request May 23, 2022

use full paths to files to generate-code genrule #78104

Closed

Michael Andreas Dagitses added 6 commits May 23, 2022 10:36

dagitses mentioned this pull request May 31, 2022

extract aten_core_srcs function into shared build structure #78535

Closed

dagitses mentioned this pull request May 31, 2022

move pytorch-root/tools/build_variables.bzl to the pytorch-root #78542

Closed

Michael Andreas Dagitses added 2 commits June 2, 2022 13:22

seemethere approved these changes Jun 15, 2022

View reviewed changes

pytorchmergebot added the Merged label Jun 16, 2022

pytorchmergebot closed this in c6c207f Jun 16, 2022

dagitses mentioned this pull request Jun 16, 2022

exclude jit_core_headers from hipification #79689

Closed

facebook-github-bot deleted the gh/dagitses/338/head branch June 19, 2022 14:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

use ufunc_defs.bzl in BUILD.bazel#77747

use ufunc_defs.bzl in BUILD.bazel#77747
dagitses wants to merge 51 commits into
gh/dagitses/338/basefrom
gh/dagitses/338/head

dagitses commented May 18, 2022 •

edited

Loading

Uh oh!

facebook-github-bot commented May 18, 2022 •

edited

Loading

Uh oh!

facebook-github-bot commented Jun 16, 2022

Uh oh!

pytorchmergebot commented Jun 16, 2022

Uh oh!

github-actions Bot commented Jun 16, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

dagitses commented May 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented May 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful links

✅ No Failures (0 Pending)

Uh oh!

facebook-github-bot commented Jun 16, 2022

Uh oh!

pytorchmergebot commented Jun 16, 2022

Uh oh!

github-actions Bot commented Jun 16, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dagitses commented May 18, 2022 •

edited

Loading

facebook-github-bot commented May 18, 2022 •

edited

Loading