move gen_aten and gen_aten_hip into shared build structure#77751
Closed
dagitses wants to merge 50 commits into
Closed
move gen_aten and gen_aten_hip into shared build structure#77751dagitses wants to merge 50 commits into
dagitses wants to merge 50 commits into
Conversation
This requires two changes to rule generation: * pulling the cpu static dispatch prediction into the rules * disabling the Bazel-style generated file aliases Differential Revision: [D36481918](https://our.internmc.facebook.com/intern/diff/D36481918/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481918/)! [ghstack-poisoned]
Contributor
🔗 Helpful links
✅ No Failures (0 Pending)As of commit f74a8f6 (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced May 18, 2022
This requires two changes to rule generation: * pulling the cpu static dispatch prediction into the rules * disabling the Bazel-style generated file aliases Differential Revision: [D36481918](https://our.internmc.facebook.com/intern/diff/D36481918/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481918/)! [ghstack-poisoned]
This requires two changes to rule generation: * pulling the cpu static dispatch prediction into the rules * disabling the Bazel-style generated file aliases Differential Revision: [D36481918](https://our.internmc.facebook.com/intern/diff/D36481918/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481918/)! [ghstack-poisoned]
This requires two changes to rule generation: * pulling the cpu static dispatch prediction into the rules * disabling the Bazel-style generated file aliases Differential Revision: [D36481918](https://our.internmc.facebook.com/intern/diff/D36481918/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481918/)! [ghstack-poisoned]
This requires two changes to rule generation: * pulling the cpu static dispatch prediction into the rules * disabling the Bazel-style generated file aliases Differential Revision: [D36481918](https://our.internmc.facebook.com/intern/diff/D36481918/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481918/)! [ghstack-poisoned]
This requires two changes to rule generation: * pulling the cpu static dispatch prediction into the rules * disabling the Bazel-style generated file aliases Differential Revision: [D36481918](https://our.internmc.facebook.com/intern/diff/D36481918/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481918/)! [ghstack-poisoned]
added 2 commits
May 18, 2022 12:02
This requires two changes to rule generation: * pulling the cpu static dispatch prediction into the rules * disabling the Bazel-style generated file aliases Differential Revision: [D36481918](https://our.internmc.facebook.com/intern/diff/D36481918/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481918/)! [ghstack-poisoned]
This requires two changes to rule generation: * pulling the cpu static dispatch prediction into the rules * disabling the Bazel-style generated file aliases Differential Revision: [D36481918](https://our.internmc.facebook.com/intern/diff/D36481918/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481918/)! [ghstack-poisoned]
This requires two changes to rule generation: * pulling the cpu static dispatch prediction into the rules * disabling the Bazel-style generated file aliases Differential Revision: [D36481918](https://our.internmc.facebook.com/intern/diff/D36481918/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481918/)! [ghstack-poisoned]
This requires two changes to rule generation: * pulling the cpu static dispatch prediction into the rules * disabling the Bazel-style generated file aliases Differential Revision: [D36481918](https://our.internmc.facebook.com/intern/diff/D36481918/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481918/)! [ghstack-poisoned]
added 2 commits
May 18, 2022 14:11
This requires two changes to rule generation: * pulling the cpu static dispatch prediction into the rules * disabling the Bazel-style generated file aliases Differential Revision: [D36481918](https://our.internmc.facebook.com/intern/diff/D36481918/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481918/)! [ghstack-poisoned]
This requires two changes to rule generation: * pulling the cpu static dispatch prediction into the rules * disabling the Bazel-style generated file aliases Differential Revision: [D36481918](https://our.internmc.facebook.com/intern/diff/D36481918/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481918/)! [ghstack-poisoned]
This requires two changes to rule generation: * pulling the cpu static dispatch prediction into the rules * disabling the Bazel-style generated file aliases Differential Revision: [D36481918](https://our.internmc.facebook.com/intern/diff/D36481918/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481918/)! [ghstack-poisoned]
kit1980
approved these changes
Jun 2, 2022
This requires two changes to rule generation: * pulling the cpu static dispatch prediction into the rules * disabling the Bazel-style generated file aliases Differential Revision: [D36481918](https://our.internmc.facebook.com/intern/diff/D36481918/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481918/)! [ghstack-poisoned]
dagitses
pushed a commit
that referenced
this pull request
Jun 14, 2022
Pull Request resolved: #77751 This requires two changes to rule generation: * pulling the cpu static dispatch prediction into the rules * disabling the Bazel-style generated file aliases Differential Revision: [D36481918](https://our.internmc.facebook.com/intern/diff/D36481918/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481918/)! ghstack-source-id: 158938991
This requires two changes to rule generation: * pulling the cpu static dispatch prediction into the rules * disabling the Bazel-style generated file aliases Differential Revision: [D36481918](https://our.internmc.facebook.com/intern/diff/D36481918/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481918/)! [ghstack-poisoned]
dagitses
pushed a commit
that referenced
this pull request
Jun 15, 2022
Pull Request resolved: #77751 This requires two changes to rule generation: * pulling the cpu static dispatch prediction into the rules * disabling the Bazel-style generated file aliases ghstack-source-id: 158938991 Differential Revision: [D36481918](https://our.internmc.facebook.com/intern/diff/D36481918/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481918/)!
This requires two changes to rule generation: * pulling the cpu static dispatch prediction into the rules * disabling the Bazel-style generated file aliases Differential Revision: [D36481918](https://our.internmc.facebook.com/intern/diff/D36481918/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481918/)! [ghstack-poisoned]
This requires two changes to rule generation: * pulling the cpu static dispatch prediction into the rules * disabling the Bazel-style generated file aliases Differential Revision: [D36481918](https://our.internmc.facebook.com/intern/diff/D36481918/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481918/)! [ghstack-poisoned]
This requires two changes to rule generation: * pulling the cpu static dispatch prediction into the rules * disabling the Bazel-style generated file aliases Differential Revision: [D36481918](https://our.internmc.facebook.com/intern/diff/D36481918/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481918/)! [ghstack-poisoned]
dagitses
pushed a commit
that referenced
this pull request
Jun 15, 2022
Pull Request resolved: #77751 This requires two changes to rule generation: * pulling the cpu static dispatch prediction into the rules * disabling the Bazel-style generated file aliases ghstack-source-id: 158938991 Differential Revision: [D36481918](https://our.internmc.facebook.com/intern/diff/D36481918/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481918/)!
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 15, 2022
Summary: Pull Request resolved: #77751 This requires two changes to rule generation: * pulling the cpu static dispatch prediction into the rules * disabling the Bazel-style generated file aliases ghstack-source-id: 158938991 Test Plan: Rely on CI. Reviewed By: kit1980 Differential Revision: D36481918 fbshipit-source-id: c6d53a9acad3a94290313db2b9db9fe5ab4dbf7a
Member
|
@pytorchbot merge |
Collaborator
|
@pytorchbot successfully started a merge job. Check the current status here |
Collaborator
|
Merge failed due to This PR has internal changes and must be landed via Phabricator |
This requires two changes to rule generation: * pulling the cpu static dispatch prediction into the rules * disabling the Bazel-style generated file aliases Differential Revision: [D36481918](https://our.internmc.facebook.com/intern/diff/D36481918/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481918/)! [ghstack-poisoned]
Contributor
|
@pytorchbot merge |
seemethere
approved these changes
Jun 15, 2022
Collaborator
|
@pytorchbot successfully started a merge job. Check the current status here |
Collaborator
|
Merge failed due to Refusing to merge as mandatory check(s) linux-docs / build-docs (cpp), linux-docs / build-docs (python), win-vs2019-cpu-py3 / build, win-vs2019-cuda11.3-py3 / build, linux-bionic-py3.7-clang9 / build, linux-xenial-py3.7-clang7-onnx / build, linux-vulkan-bionic-py3.7-clang9 / build, linux-xenial-cuda11.3-py3.7-gcc7 / build, linux-bionic-cuda11.3-py3.7-clang9 / build, linux-xenial-py3-clang5-mobile-custom-build-static / build, pytorch-xla-linux-bionic-py3.7-clang8 / build, deploy-linux-xenial-cuda11.3-py3.7-gcc7 / build, linux-focal-py3.7-gcc7 / build are pending/not yet run for rule superuser |
Contributor
|
@pytorchbot merge -f |
Collaborator
|
@pytorchbot successfully started a merge job. Check the current status here |
Contributor
|
Hey @dagitses. |
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 25, 2026
Pull Request resolved: pytorch#77751 This requires two changes to rule generation: * pulling the cpu static dispatch prediction into the rules * disabling the Bazel-style generated file aliases Differential Revision: [D36481918](https://our.internmc.facebook.com/intern/diff/D36481918/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481918/)! Approved by: https://github.com/kit1980, https://github.com/seemethere
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This requires two changes to rule generation:
Differential Revision: D36481918
NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!