move pytorch-root/tools/build_variables.bzl to the pytorch-root by dagitses · Pull Request #78542 · pytorch/pytorch

dagitses · 2022-05-31T17:28:30Z

Stack from ghstack (oldest at bottom):

-> move pytorch-root/tools/build_variables.bzl to the pytorch-root #78542

This makes importing easier in different build systems that have
different absolute names for the pytorch-root.

Differential Revision: D36782582

NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!

This makes importing easier in different build systems that have different absolute names for the pytorch-root. Differential Revision: [D36782582](https://our.internmc.facebook.com/intern/diff/D36782582/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36782582/)! [ghstack-poisoned]

facebook-github-bot · 2022-05-31T17:28:36Z

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/78542
📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓Need help or want to give feedback on the CI? Visit our office hours
↩️ [fb-only] Re-run with SSH instructions

❌ 2 New Failures

As of commit e721f39 (more details on the Dr. CI page):

Expand to see more

2/2 failures introduced in this PR

🕵️ 2 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages

pull / linux-xenial-cuda11.3-py3.7-gcc7 / test (distributed, 1, 2, linux.8xlarge.nvidia.gpu) (1/2)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

2022-06-02T17:02:04.4825629Z FAIL [7.312s]: test_ddp_namedtuple (__main__.TestDistBackendWithSpawn)

2022-06-02T17:02:01.3152132Z INFO:torch.testing._internal.common_distributed:Starting event listener thread for rank 1
2022-06-02T17:02:01.4110060Z INFO:torch.testing._internal.common_distributed:Starting event listener thread for rank 0
2022-06-02T17:02:02.6651068Z INFO:torch.distributed.nn.jit.instantiator:Created a temporary directory at /tmp/tmptl_is55a
2022-06-02T17:02:02.6651931Z INFO:torch.distributed.nn.jit.instantiator:Writing /tmp/tmptl_is55a/_remote_module_non_scriptable.py
2022-06-02T17:02:02.7715767Z INFO:torch.distributed.nn.jit.instantiator:Created a temporary directory at /tmp/tmp3s3pxn9n
2022-06-02T17:02:02.7716698Z INFO:torch.distributed.nn.jit.instantiator:Writing /tmp/tmp3s3pxn9n/_remote_module_non_scriptable.py
2022-06-02T17:02:04.4823050Z ok (4.447s)
2022-06-02T17:02:04.4823869Z     test_ddp_namedtuple succeeded - num_retries_left: 0
2022-06-02T17:02:04.4824537Z 
2022-06-02T17:02:04.4824696Z ======================================================================
2022-06-02T17:02:04.4825629Z FAIL [7.312s]: test_ddp_namedtuple (__main__.TestDistBackendWithSpawn)
2022-06-02T17:02:04.4826818Z ----------------------------------------------------------------------
2022-06-02T17:02:04.4827866Z Traceback (most recent call last):
2022-06-02T17:02:04.4828448Z   File "/opt/conda/lib/python3.7/site-packages/torch/testing/_internal/common_distributed.py", line 501, in wrapper
2022-06-02T17:02:04.4828829Z     self._join_processes(fn)
2022-06-02T17:02:04.4829373Z   File "/opt/conda/lib/python3.7/site-packages/torch/testing/_internal/common_distributed.py", line 724, in _join_processes
2022-06-02T17:02:04.4829797Z     self._check_return_codes(elapsed_time)
2022-06-02T17:02:04.4830378Z   File "/opt/conda/lib/python3.7/site-packages/torch/testing/_internal/common_distributed.py", line 783, in _check_return_codes
2022-06-02T17:02:04.4830814Z     i, first_process.exitcode, p.exitcode
2022-06-02T17:02:04.4831347Z   File "/opt/conda/lib/python3.7/site-packages/torch/testing/_internal/common_utils.py", line 2286, in assertEqual
2022-06-02T17:02:04.4831857Z     msg=(lambda generated_msg: f"{generated_msg} : {msg}") if isinstance(msg, str) and self.longMessage else msg,

trunk / win-vs2019-cuda11.3-py3 / test (default, 4, 5, windows.8xlarge.nvidia.gpu) (2/2)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

2022-06-02T17:41:35.9929485Z FAIL [0.016s]: tes...cosh_cuda_complex32 (__main__.TestUnaryUfuncsCUDA)

2022-06-02T17:41:35.9926522Z     assert_equal(
2022-06-02T17:41:35.9927024Z   File "C:\actions-runner\_work\pytorch\pytorch\build\win_tmp\build\torch\testing\_comparison.py", line 1095, in assert_equal
2022-06-02T17:41:35.9927480Z     raise error_metas[0].to_error(msg)
2022-06-02T17:41:35.9927768Z AssertionError: Tensor-likes are not close!
2022-06-02T17:41:35.9927953Z 
2022-06-02T17:41:35.9928076Z Mismatched elements: 1200 / 10000 (12.0%)
2022-06-02T17:41:35.9928413Z Greatest absolute difference: nan at index (700,) (up to 1e-05 allowed)
2022-06-02T17:41:35.9928781Z Greatest relative difference: nan at index (700,) (up to 0.001 allowed)
2022-06-02T17:41:35.9928991Z 
2022-06-02T17:41:35.9929116Z ======================================================================
2022-06-02T17:41:35.9929485Z FAIL [0.016s]: test_reference_numerics_large_cosh_cuda_complex32 (__main__.TestUnaryUfuncsCUDA)
2022-06-02T17:41:35.9929913Z ----------------------------------------------------------------------
2022-06-02T17:41:35.9930223Z Traceback (most recent call last):
2022-06-02T17:41:35.9930756Z   File "C:\actions-runner\_work\pytorch\pytorch\build\win_tmp\build\torch\testing\_internal\common_device_type.py", line 377, in instantiated_test
2022-06-02T17:41:35.9931226Z     result = test(self, **param_kwargs)
2022-06-02T17:41:35.9931736Z   File "C:\actions-runner\_work\pytorch\pytorch\build\win_tmp\build\torch\testing\_internal\common_device_type.py", line 786, in test_wrapper
2022-06-02T17:41:35.9932156Z     return test(*args, **kwargs)
2022-06-02T17:41:35.9932630Z   File "C:\actions-runner\_work\pytorch\pytorch\build\win_tmp\build\torch\testing\_internal\common_utils.py", line 1168, in wrapper
2022-06-02T17:41:35.9933044Z     fn(*args, **kwargs)
2022-06-02T17:41:35.9933400Z   File "test_unary_ufuncs.py", line 344, in test_reference_numerics_large
2022-06-02T17:41:35.9933747Z     self._test_reference_numerics(dtype, op, tensors)

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

This makes importing easier in different build systems that have different absolute names for the pytorch-root. Differential Revision: [D36782582](https://our.internmc.facebook.com/intern/diff/D36782582/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36782582/)! ghstack-source-id: 157667784 Pull Request resolved: #78542

…-root" This makes importing easier in different build systems that have different absolute names for the pytorch-root. Differential Revision: [D36782582](https://our.internmc.facebook.com/intern/diff/D36782582/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36782582/)! [ghstack-poisoned]

Pull Request resolved: #78542 This makes importing easier in different build systems that have different absolute names for the pytorch-root. ghstack-source-id: 157667784 Differential Revision: [D36782582](https://our.internmc.facebook.com/intern/diff/D36782582/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36782582/)!

…-root" This makes importing easier in different build systems that have different absolute names for the pytorch-root. Differential Revision: [D36782582](https://our.internmc.facebook.com/intern/diff/D36782582/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36782582/)! [ghstack-poisoned]

…to the root Pull Request resolved: #78542 This makes importing easier in different build systems that have different absolute names for the pytorch-root. ghstack-source-id: 157796694 Differential Revision: [D36782582](https://our.internmc.facebook.com/intern/diff/D36782582/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36782582/)!

malfet

I kind of dislike the idea, but it's ok

dagitses · 2022-06-02T14:12:19Z

I kind of dislike the idea, but it's ok

fair enough. fwiw: This has caused problems outside of the build unification too, example: https://github.com/pytorch/pytorch/blob/master/aten.bzl#L98

…-root" This makes importing easier in different build systems that have different absolute names for the pytorch-root. Differential Revision: [D36782582](https://our.internmc.facebook.com/intern/diff/D36782582/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36782582/)! [ghstack-poisoned]

…to the root Pull Request resolved: #78542 This makes importing easier in different build systems that have different absolute names for the pytorch-root. ghstack-source-id: 157906103 Differential Revision: [D36782582](https://our.internmc.facebook.com/intern/diff/D36782582/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36782582/)!

…-root" This makes importing easier in different build systems that have different absolute names for the pytorch-root. Differential Revision: [D36782582](https://our.internmc.facebook.com/intern/diff/D36782582/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36782582/)! [ghstack-poisoned]

…to the root Pull Request resolved: #78542 This makes importing easier in different build systems that have different absolute names for the pytorch-root. ghstack-source-id: 157910819 Differential Revision: [D36782582](https://our.internmc.facebook.com/intern/diff/D36782582/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36782582/)!

facebook-github-bot · 2022-06-02T19:37:14Z

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

github-actions · 2022-06-02T19:40:33Z

Hey @dagitses.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

…to the root (#78542) Summary: Pull Request resolved: #78542 This makes importing easier in different build systems that have different absolute names for the pytorch-root. ghstack-source-id: 157910819 Test Plan: Rely on CI. Reviewed By: malfet, linbinyu Differential Revision: D36782582 fbshipit-source-id: 1693f233fbf07de6fd2ba5d1747e8a03b9cc0d50

…to the root Pull Request resolved: pytorch#78542 This makes importing easier in different build systems that have different absolute names for the pytorch-root. Differential Revision: [D36782582](https://our.internmc.facebook.com/intern/diff/D36782582/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36782582/)! Approved by: https://github.com/malfet

facebook-github-bot added the cla signed label May 31, 2022

linbinyu added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 2, 2022

malfet approved these changes Jun 2, 2022

View reviewed changes

pytorchmergebot added the Merged label Jun 2, 2022

pytorchmergebot closed this in 501d072 Jun 2, 2022

facebook-github-bot deleted the gh/dagitses/354/head branch June 6, 2022 14:17

iago-lito mentioned this pull request Jun 28, 2022

CMake Error: File /opt/pytorch/build_variables.bzl does not exist. #80431

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

move pytorch-root/tools/build_variables.bzl to the pytorch-root#78542

move pytorch-root/tools/build_variables.bzl to the pytorch-root#78542
dagitses wants to merge 6 commits into
gh/dagitses/354/basefrom
gh/dagitses/354/head

dagitses commented May 31, 2022 •

edited

Loading

Uh oh!

facebook-github-bot commented May 31, 2022 •

edited

Loading

🕵️ 2 new failures recognized by patterns

pull / linux-xenial-cuda11.3-py3.7-gcc7 / test (distributed, 1, 2, linux.8xlarge.nvidia.gpu) (1/2)

trunk / win-vs2019-cuda11.3-py3 / test (default, 4, 5, windows.8xlarge.nvidia.gpu) (2/2)

Uh oh!

malfet left a comment

Uh oh!

dagitses commented Jun 2, 2022

Uh oh!

facebook-github-bot commented Jun 2, 2022

Uh oh!

github-actions Bot commented Jun 2, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

dagitses commented May 31, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented May 31, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful links

❌ 2 New Failures

🕵️ 2 new failures recognized by patterns

pull / linux-xenial-cuda11.3-py3.7-gcc7 / test (distributed, 1, 2, linux.8xlarge.nvidia.gpu) (1/2)

trunk / win-vs2019-cuda11.3-py3 / test (default, 4, 5, windows.8xlarge.nvidia.gpu) (2/2)

Uh oh!

malfet left a comment

Choose a reason for hiding this comment

Uh oh!

dagitses commented Jun 2, 2022

Uh oh!

facebook-github-bot commented Jun 2, 2022

Uh oh!

github-actions Bot commented Jun 2, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

dagitses commented May 31, 2022 •

edited

Loading

facebook-github-bot commented May 31, 2022 •

edited

Loading