move GENERATED_CPP_CUDA to caffe2/build.bzl#77744
Closed
dagitses wants to merge 52 commits into
Closed
Conversation
This is needed by gen_aten and it's immediate downstream libraries. As such, it can live solely in the shared build structure. Differential Revision: [D36480812](https://our.internmc.facebook.com/intern/diff/D36480812/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36480812/)! [ghstack-poisoned]
Contributor
🔗 Helpful links
✅ No Failures (0 Pending)As of commit 1e8b550 (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced May 18, 2022
This is needed by gen_aten and it's immediate downstream libraries. As such, it can live solely in the shared build structure. Differential Revision: [D36480812](https://our.internmc.facebook.com/intern/diff/D36480812/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36480812/)! [ghstack-poisoned]
added 2 commits
May 18, 2022 08:38
This is needed by gen_aten and it's immediate downstream libraries. As such, it can live solely in the shared build structure. Differential Revision: [D36480812](https://our.internmc.facebook.com/intern/diff/D36480812/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36480812/)! [ghstack-poisoned]
This is needed by gen_aten and it's immediate downstream libraries. As such, it can live solely in the shared build structure. Differential Revision: [D36480812](https://our.internmc.facebook.com/intern/diff/D36480812/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36480812/)! [ghstack-poisoned]
added 2 commits
May 18, 2022 08:57
This is needed by gen_aten and it's immediate downstream libraries. As such, it can live solely in the shared build structure. Differential Revision: [D36480812](https://our.internmc.facebook.com/intern/diff/D36480812/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36480812/)! [ghstack-poisoned]
This is needed by gen_aten and it's immediate downstream libraries. As such, it can live solely in the shared build structure. Differential Revision: [D36480812](https://our.internmc.facebook.com/intern/diff/D36480812/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36480812/)! [ghstack-poisoned]
added 5 commits
May 18, 2022 09:17
This is needed by gen_aten and it's immediate downstream libraries. As such, it can live solely in the shared build structure. Differential Revision: [D36480812](https://our.internmc.facebook.com/intern/diff/D36480812/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36480812/)! [ghstack-poisoned]
This is needed by gen_aten and it's immediate downstream libraries. As such, it can live solely in the shared build structure. Differential Revision: [D36480812](https://our.internmc.facebook.com/intern/diff/D36480812/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36480812/)! [ghstack-poisoned]
This is needed by gen_aten and it's immediate downstream libraries. As such, it can live solely in the shared build structure. Differential Revision: [D36480812](https://our.internmc.facebook.com/intern/diff/D36480812/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36480812/)! [ghstack-poisoned]
This is needed by gen_aten and it's immediate downstream libraries. As such, it can live solely in the shared build structure. Differential Revision: [D36480812](https://our.internmc.facebook.com/intern/diff/D36480812/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36480812/)! [ghstack-poisoned]
This is needed by gen_aten and it's immediate downstream libraries. As such, it can live solely in the shared build structure. Differential Revision: [D36480812](https://our.internmc.facebook.com/intern/diff/D36480812/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36480812/)! [ghstack-poisoned]
added 2 commits
May 18, 2022 12:02
This is needed by gen_aten and it's immediate downstream libraries. As such, it can live solely in the shared build structure. Differential Revision: [D36480812](https://our.internmc.facebook.com/intern/diff/D36480812/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36480812/)! [ghstack-poisoned]
This is needed by gen_aten and it's immediate downstream libraries. As such, it can live solely in the shared build structure. Differential Revision: [D36480812](https://our.internmc.facebook.com/intern/diff/D36480812/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36480812/)! [ghstack-poisoned]
This is needed by gen_aten and it's immediate downstream libraries. As such, it can live solely in the shared build structure. Differential Revision: [D36480812](https://our.internmc.facebook.com/intern/diff/D36480812/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36480812/)! [ghstack-poisoned]
This is needed by gen_aten and it's immediate downstream libraries. As such, it can live solely in the shared build structure. Differential Revision: [D36480812](https://our.internmc.facebook.com/intern/diff/D36480812/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36480812/)! [ghstack-poisoned]
added 2 commits
May 18, 2022 14:11
This is needed by gen_aten and it's immediate downstream libraries. As such, it can live solely in the shared build structure. Differential Revision: [D36480812](https://our.internmc.facebook.com/intern/diff/D36480812/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36480812/)! [ghstack-poisoned]
This is needed by gen_aten and it's immediate downstream libraries. As such, it can live solely in the shared build structure. Differential Revision: [D36480812](https://our.internmc.facebook.com/intern/diff/D36480812/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36480812/)! [ghstack-poisoned]
added 2 commits
May 23, 2022 09:58
This is needed by gen_aten and it's immediate downstream libraries. As such, it can live solely in the shared build structure. Differential Revision: [D36480812](https://our.internmc.facebook.com/intern/diff/D36480812/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36480812/)! [ghstack-poisoned]
This is needed by gen_aten and it's immediate downstream libraries. As such, it can live solely in the shared build structure. Differential Revision: [D36480812](https://our.internmc.facebook.com/intern/diff/D36480812/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36480812/)! [ghstack-poisoned]
added 6 commits
May 23, 2022 10:35
This is needed by gen_aten and it's immediate downstream libraries. As such, it can live solely in the shared build structure. Differential Revision: [D36480812](https://our.internmc.facebook.com/intern/diff/D36480812/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36480812/)! [ghstack-poisoned]
This is needed by gen_aten and it's immediate downstream libraries. As such, it can live solely in the shared build structure. Differential Revision: [D36480812](https://our.internmc.facebook.com/intern/diff/D36480812/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36480812/)! [ghstack-poisoned]
This is needed by gen_aten and it's immediate downstream libraries. As such, it can live solely in the shared build structure. Differential Revision: [D36480812](https://our.internmc.facebook.com/intern/diff/D36480812/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36480812/)! [ghstack-poisoned]
This is needed by gen_aten and it's immediate downstream libraries. As such, it can live solely in the shared build structure. Differential Revision: [D36480812](https://our.internmc.facebook.com/intern/diff/D36480812/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36480812/)! [ghstack-poisoned]
This is needed by gen_aten and it's immediate downstream libraries. As such, it can live solely in the shared build structure. Differential Revision: [D36480812](https://our.internmc.facebook.com/intern/diff/D36480812/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36480812/)! [ghstack-poisoned]
This is needed by gen_aten and it's immediate downstream libraries. As such, it can live solely in the shared build structure. Differential Revision: [D36480812](https://our.internmc.facebook.com/intern/diff/D36480812/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36480812/)! [ghstack-poisoned]
This is needed by gen_aten and it's immediate downstream libraries. As such, it can live solely in the shared build structure. Differential Revision: [D36480812](https://our.internmc.facebook.com/intern/diff/D36480812/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36480812/)! [ghstack-poisoned]
This is needed by gen_aten and it's immediate downstream libraries. As such, it can live solely in the shared build structure. Differential Revision: [D36480812](https://our.internmc.facebook.com/intern/diff/D36480812/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36480812/)! [ghstack-poisoned]
This is needed by gen_aten and it's immediate downstream libraries. As such, it can live solely in the shared build structure. Differential Revision: [D36480812](https://our.internmc.facebook.com/intern/diff/D36480812/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36480812/)! [ghstack-poisoned]
dagitses
pushed a commit
that referenced
this pull request
Jun 1, 2022
Pull Request resolved: #77744 This is needed by gen_aten and it's immediate downstream libraries. As such, it can live solely in the shared build structure. ghstack-source-id: 157009736 Differential Revision: [D36480812](https://our.internmc.facebook.com/intern/diff/D36480812/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36480812/)!
kit1980
approved these changes
Jun 1, 2022
This is needed by gen_aten and it's immediate downstream libraries. As such, it can live solely in the shared build structure. Differential Revision: [D36480812](https://our.internmc.facebook.com/intern/diff/D36480812/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36480812/)! [ghstack-poisoned]
dagitses
pushed a commit
that referenced
this pull request
Jun 2, 2022
Pull Request resolved: #77744 This is needed by gen_aten and it's immediate downstream libraries. As such, it can live solely in the shared build structure. ghstack-source-id: 157768285 Differential Revision: [D36480812](https://our.internmc.facebook.com/intern/diff/D36480812/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36480812/)!
This is needed by gen_aten and it's immediate downstream libraries. As such, it can live solely in the shared build structure. Differential Revision: [D36480812](https://our.internmc.facebook.com/intern/diff/D36480812/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36480812/)! [ghstack-poisoned]
dagitses
pushed a commit
that referenced
this pull request
Jun 2, 2022
Pull Request resolved: #77744 This is needed by gen_aten and it's immediate downstream libraries. As such, it can live solely in the shared build structure. ghstack-source-id: 157879134 Differential Revision: [D36480812](https://our.internmc.facebook.com/intern/diff/D36480812/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36480812/)!
Contributor
|
@pytorchbot merge |
Contributor
|
Hey @dagitses. |
bigfootjon
pushed a commit
that referenced
this pull request
Jun 2, 2022
Summary: Pull Request resolved: #77744 This is needed by gen_aten and it's immediate downstream libraries. As such, it can live solely in the shared build structure. ghstack-source-id: 157879134 Test Plan: Rely on CI. Reviewed By: kit1980 Differential Revision: D36480812 fbshipit-source-id: 05c3327c3b01f30205af9879a4db51bf387dcb6a
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 25, 2026
Pull Request resolved: pytorch#77744 This is needed by gen_aten and it's immediate downstream libraries. As such, it can live solely in the shared build structure. Differential Revision: [D36480812](https://our.internmc.facebook.com/intern/diff/D36480812/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36480812/)! Approved by: https://github.com/kit1980
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This is needed by gen_aten and it's immediate downstream libraries. As
such, it can live solely in the shared build structure.
Differential Revision: D36480812
NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!