move generated_srcs_list.bzl into caffe2/build.bzl by dagitses · Pull Request #77680 · pytorch/pytorch

dagitses · 2022-05-17T21:12:43Z

Stack from ghstack (oldest at bottom):

This is only used by ATen code generation and libraries. These are
about to move into the shared build structure, so let's move this
cleanly first.

Differential Revision: D36455725

NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!

This is only used by ATen code generation and libraries. These are about to move into the shared build structure, so let's move this cleanly first. Differential Revision: [D36455725](https://our.internmc.facebook.com/intern/diff/D36455725/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36455725/)! [ghstack-poisoned]

facebook-github-bot · 2022-05-17T21:12:49Z

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/77680
📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓Need help or want to give feedback on the CI? Visit our office hours
↩️ [fb-only] Re-run with SSH instructions

❌ 1 New Failures

As of commit 4ec3b1c (more details on the Dr. CI page):

Expand to see more

1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages

pull / pytorch-xla-linux-bionic-py3.7-clang8 / test (xla, 1, 1, linux.2xlarge) (1/1)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

2022-06-01T17:30:07.5607270Z ##[error]Process completed with exit code 134.

2022-06-01T17:30:01.6228452Z 	PyRun_SimpleFileExFlags
2022-06-01T17:30:01.6228626Z 	
2022-06-01T17:30:01.6228761Z 	_Py_UnixMain
2022-06-01T17:30:01.6228933Z 	__libc_start_main
2022-06-01T17:30:01.6229095Z 	
2022-06-01T17:30:01.6229238Z *** End stack trace ***
2022-06-01T17:30:07.2918281Z ./test/run_tests.sh: line 35: 26021 Aborted                 (core dumped) "$@"
2022-06-01T17:30:07.2923804Z + cleanup
2022-06-01T17:30:07.2924081Z + retcode=134
2022-06-01T17:30:07.2924373Z + set +x
2022-06-01T17:30:07.5607270Z ##[error]Process completed with exit code 134.
2022-06-01T17:30:07.6511179Z ##[group]Run pytorch/pytorch/.github/actions/get-workflow-job-id@master
2022-06-01T17:30:07.6511543Z with:
2022-06-01T17:30:07.6511936Z   github-token: ***
2022-06-01T17:30:07.6512113Z env:
2022-06-01T17:30:07.6512278Z   IN_CI: 1
2022-06-01T17:30:07.6512426Z   IS_GHA: 1
2022-06-01T17:30:07.6512607Z   GIT_DEFAULT_BRANCH: master
2022-06-01T17:30:07.6512794Z ##[endgroup]
2022-06-01T17:30:07.6684457Z ##[group]Run nick-fields/retry@71062288b76e2b6214ebde0e673ce0de1755740a
2022-06-01T17:30:07.6684705Z with:

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

This is only used by ATen code generation and libraries. These are about to move into the shared build structure, so let's move this cleanly first. Differential Revision: [D36455725](https://our.internmc.facebook.com/intern/diff/D36455725/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36455725/)! ghstack-source-id: 156582857 Pull Request resolved: #77680

This is only used by ATen code generation and libraries. These are about to move into the shared build structure, so let's move this cleanly first. Differential Revision: [D36455725](https://our.internmc.facebook.com/intern/diff/D36455725/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36455725/)! [ghstack-poisoned]

Pull Request resolved: #77680 This is only used by ATen code generation and libraries. These are about to move into the shared build structure, so let's move this cleanly first. ghstack-source-id: 156590531 Differential Revision: [D36455725](https://our.internmc.facebook.com/intern/diff/D36455725/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36455725/)!

This is only used by ATen code generation and libraries. These are about to move into the shared build structure, so let's move this cleanly first. Differential Revision: [D36455725](https://our.internmc.facebook.com/intern/diff/D36455725/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36455725/)! [ghstack-poisoned]

facebook-github-bot · 2022-06-01T23:02:38Z

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

github-actions · 2022-06-01T23:04:30Z

Hey @dagitses.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

Summary: Pull Request resolved: #77680 This is only used by ATen code generation and libraries. These are about to move into the shared build structure, so let's move this cleanly first. ghstack-source-id: 157767103 Test Plan: Rely on CI. Reviewed By: kit1980 Differential Revision: D36455725 fbshipit-source-id: de00f6759cd488d68c70892abb4de8c019402c4f

Pull Request resolved: pytorch#77680 This is only used by ATen code generation and libraries. These are about to move into the shared build structure, so let's move this cleanly first. Differential Revision: [D36455725](https://our.internmc.facebook.com/intern/diff/D36455725/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36455725/)! Approved by: https://github.com/kit1980

facebook-github-bot added the cla signed label May 17, 2022

This was referenced May 17, 2022

move generated-autograd-headers to the shared build structure #76183

Closed

remove unnecessary ATen/core/Macros.h #76376

Closed

This was referenced May 18, 2022

move GENERATED_CPP_CUDA to caffe2/build.bzl #77744

Closed

move aten_ufunc_headers to ufunc_defs.bzl #77745

Closed

dagitses mentioned this pull request May 18, 2022

use ufunc_defs.bzl in BUILD.bazel #77747

Closed

Michael Andreas Dagitses added 2 commits May 18, 2022 08:38

dagitses mentioned this pull request May 18, 2022

move ufunc_defs.bzl to the top-level #77749

Closed

Michael Andreas Dagitses added 2 commits May 18, 2022 08:57

dagitses mentioned this pull request May 18, 2022

move gen_aten and gen_aten_hip into shared build structure #77751

Closed

Michael Andreas Dagitses added 5 commits May 18, 2022 09:17

dagitses mentioned this pull request May 18, 2022

gen_aten output into aten/src/ATen/ #77773

Closed

Michael Andreas Dagitses added 2 commits May 18, 2022 12:02

dagitses mentioned this pull request May 18, 2022

switch Bazel to common aten codegen #77778

Closed

dagitses mentioned this pull request May 18, 2022

gen_aten uses full paths to aten files #77788

Closed

Michael Andreas Dagitses added 4 commits May 23, 2022 08:16

dagitses mentioned this pull request May 23, 2022

move aten_core_headers to common build structure #78093

Closed

dagitses mentioned this pull request May 23, 2022

move the GENERATED_CORE_H headers into aten_core_headers #78097

Closed

Michael Andreas Dagitses added 2 commits May 23, 2022 09:58

dagitses mentioned this pull request May 23, 2022

use full paths to files to generate-code genrule #78104

Closed

Michael Andreas Dagitses added 6 commits May 23, 2022 10:35

dagitses mentioned this pull request May 31, 2022

extract aten_core_srcs function into shared build structure #78535

Closed

dagitses mentioned this pull request May 31, 2022

move pytorch-root/tools/build_variables.bzl to the pytorch-root #78542

Closed

Michael Andreas Dagitses added 2 commits June 1, 2022 07:47

kit1980 approved these changes Jun 1, 2022

View reviewed changes

pytorchmergebot added the Merged label Jun 1, 2022

pytorchmergebot closed this in 7dc5b5b Jun 1, 2022

facebook-github-bot deleted the gh/dagitses/335/head branch June 5, 2022 14:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

move generated_srcs_list.bzl into caffe2/build.bzl#77680

move generated_srcs_list.bzl into caffe2/build.bzl#77680
dagitses wants to merge 52 commits into
gh/dagitses/335/basefrom
gh/dagitses/335/head

dagitses commented May 17, 2022 •

edited

Loading

Uh oh!

facebook-github-bot commented May 17, 2022 •

edited

Loading

🕵️ 1 new failure recognized by patterns

pull / pytorch-xla-linux-bionic-py3.7-clang8 / test (xla, 1, 1, linux.2xlarge) (1/1)

Uh oh!

facebook-github-bot commented Jun 1, 2022

Uh oh!

github-actions Bot commented Jun 1, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

dagitses commented May 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented May 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful links

❌ 1 New Failures

🕵️ 1 new failure recognized by patterns

pull / pytorch-xla-linux-bionic-py3.7-clang8 / test (xla, 1, 1, linux.2xlarge) (1/1)

Uh oh!

facebook-github-bot commented Jun 1, 2022

Uh oh!

github-actions Bot commented Jun 1, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dagitses commented May 17, 2022 •

edited

Loading

facebook-github-bot commented May 17, 2022 •

edited

Loading