move aten_ufunc_headers to ufunc_defs.bzl by dagitses · Pull Request #77745 · pytorch/pytorch

dagitses · 2022-05-18T15:25:30Z

Stack from ghstack (oldest at bottom):

This will allow a great refactoring to eliminate duplication in
aten.bzl.

Differential Revision: D36480810

NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!

This will allow a great refactoring to eliminate duplication in aten.bzl. Differential Revision: [D36480810](https://our.internmc.facebook.com/intern/diff/D36480810/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36480810/)! [ghstack-poisoned]

facebook-github-bot · 2022-05-18T15:25:38Z

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/77745
📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓Need help or want to give feedback on the CI? Visit our office hours
↩️ [fb-only] Re-run with SSH instructions

❌ 1 New Failures

As of commit 79a226b (more details on the Dr. CI page):

Expand to see more

1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages

pull / linux-xenial-py3.7-gcc5.4 / test (backwards_compat, 1, 1, linux.2xlarge) (1/1)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

2022-05-31T17:47:28.9321252Z The PR is introduc...m to confirm whether this change is wanted or not.

2022-05-31T17:47:28.9308774Z processing existing schema:  text(__torch__.torch.classes.profiling.SourceRef _0) -> (str _0)
2022-05-31T17:47:28.9310180Z processing existing schema:  count(__torch__.torch.classes.profiling.InstructionStats _0) -> (int _0)
2022-05-31T17:47:28.9311418Z processing existing schema:  duration_ns(__torch__.torch.classes.profiling.InstructionStats _0) -> (int _0)
2022-05-31T17:47:28.9312452Z processing existing schema:  source(__torch__.torch.classes.profiling.SourceStats _0) -> (__torch__.torch.classes.profiling.SourceRef _0)
2022-05-31T17:47:28.9314401Z processing existing schema:  line_map(__torch__.torch.classes.profiling.SourceStats _0) -> (Dict(int, __torch__.torch.classes.profiling.InstructionStats) _0)
2022-05-31T17:47:28.9315342Z processing existing schema:  __init__(__torch__.torch.classes.profiling._ScriptProfile _0) -> (NoneType _0)
2022-05-31T17:47:28.9316563Z processing existing schema:  enable(__torch__.torch.classes.profiling._ScriptProfile _0) -> (NoneType _0)
2022-05-31T17:47:28.9317691Z processing existing schema:  disable(__torch__.torch.classes.profiling._ScriptProfile _0) -> (NoneType _0)
2022-05-31T17:47:28.9319501Z processing existing schema:  _dump_stats(__torch__.torch.classes.profiling._ScriptProfile _0) -> (__torch__.torch.classes.profiling.SourceStats[] _0)
2022-05-31T17:47:28.9321010Z processing existing schema:  __init__(__torch__.torch.classes.dist_rpc.WorkerInfo _0, str _1, int _2) -> (NoneType _0)
2022-05-31T17:47:28.9321252Z The PR is introducing backward incompatible changes to the operator library. Please contact PyTorch team to confirm whether this change is wanted or not. 
2022-05-31T17:47:28.9321279Z 
2022-05-31T17:47:28.9321855Z Broken ops: [
2022-05-31T17:47:28.9322133Z 	prims::uniform(int[] shape, *, Scalar low, Scalar high, int dtype, Device device) -> (Tensor)
2022-05-31T17:47:28.9323933Z 	prims::empty_strided(int[] shape, int[] strides, *, int dtype, Device device, bool requires_grad) -> (Tensor)
2022-05-31T17:47:28.9324259Z 	prims::var(Tensor inp, int[]? dims, *, int correction, int? output_dtype=None) -> (Tensor)
2022-05-31T17:47:28.9324416Z 	prims::minium_value(int dtype) -> (Scalar)
2022-05-31T17:47:28.9324598Z 	prims::maximum_value(int dtype) -> (Scalar)
2022-05-31T17:47:28.9324735Z 	prims::item(Tensor a) -> (Scalar)
2022-05-31T17:47:28.9324917Z 	prims::where(Tensor pred, Tensor a, Tensor b) -> (Tensor)
2022-05-31T17:47:28.9325080Z 	prims::cat(Tensor[] tensors, int dim) -> (Tensor)

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

This will allow a great refactoring to eliminate duplication in aten.bzl. Differential Revision: [D36480810](https://our.internmc.facebook.com/intern/diff/D36480810/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36480810/)! [ghstack-poisoned]

kit1980 · 2022-06-06T20:02:33Z

Please rebase on master, several workflows were removed/added.

facebook-github-bot added the cla signed label May 18, 2022

This was referenced May 18, 2022

move generated-autograd-headers to the shared build structure #76183

Closed

remove unnecessary ATen/core/Macros.h #76376

Closed

move generated_srcs_list.bzl into caffe2/build.bzl #77680

Closed

move GENERATED_CPP_CUDA to caffe2/build.bzl #77744

Closed

dagitses mentioned this pull request May 18, 2022

use ufunc_defs.bzl in BUILD.bazel #77747

Closed

Michael Andreas Dagitses added 2 commits May 18, 2022 08:38

dagitses mentioned this pull request May 18, 2022

move ufunc_defs.bzl to the top-level #77749

Closed

Michael Andreas Dagitses added 2 commits May 18, 2022 08:57

dagitses mentioned this pull request May 18, 2022

move gen_aten and gen_aten_hip into shared build structure #77751

Closed

Michael Andreas Dagitses added 5 commits May 18, 2022 09:17

dagitses mentioned this pull request May 18, 2022

gen_aten output into aten/src/ATen/ #77773

Closed

Michael Andreas Dagitses added 2 commits May 18, 2022 12:02

dagitses mentioned this pull request May 18, 2022

switch Bazel to common aten codegen #77778

Closed

dagitses mentioned this pull request May 18, 2022

gen_aten uses full paths to aten files #77788

Closed

dagitses mentioned this pull request May 18, 2022

eliminate generated_cpu_cpp and generated_cuda_cpp from Bazel #77790

Closed

Michael Andreas Dagitses added 11 commits May 20, 2022 19:33

dagitses mentioned this pull request May 23, 2022

move aten_core_headers to common build structure #78093

Closed

dagitses mentioned this pull request May 23, 2022

move the GENERATED_CORE_H headers into aten_core_headers #78097

Closed

Michael Andreas Dagitses added 2 commits May 23, 2022 09:58

dagitses mentioned this pull request May 23, 2022

use full paths to files to generate-code genrule #78104

Closed

Michael Andreas Dagitses added 6 commits May 23, 2022 10:36

dagitses mentioned this pull request May 31, 2022

extract aten_core_srcs function into shared build structure #78535

Closed

dagitses mentioned this pull request May 31, 2022

move pytorch-root/tools/build_variables.bzl to the pytorch-root #78542

Closed

kit1980 approved these changes Jun 6, 2022

View reviewed changes

dagitses closed this Jun 16, 2022

dagitses deleted the gh/dagitses/337/head branch June 16, 2022 08:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

move aten_ufunc_headers to ufunc_defs.bzl#77745

move aten_ufunc_headers to ufunc_defs.bzl#77745
dagitses wants to merge 48 commits into
gh/dagitses/337/basefrom
gh/dagitses/337/head

dagitses commented May 18, 2022 •

edited

Loading

Uh oh!

facebook-github-bot commented May 18, 2022 •

edited

Loading

🕵️ 1 new failure recognized by patterns

pull / linux-xenial-py3.7-gcc5.4 / test (backwards_compat, 1, 1, linux.2xlarge) (1/1)

Uh oh!

kit1980 commented Jun 6, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

dagitses commented May 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented May 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful links

❌ 1 New Failures

🕵️ 1 new failure recognized by patterns

pull / linux-xenial-py3.7-gcc5.4 / test (backwards_compat, 1, 1, linux.2xlarge) (1/1)

Uh oh!

kit1980 commented Jun 6, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dagitses commented May 18, 2022 •

edited

Loading

facebook-github-bot commented May 18, 2022 •

edited

Loading