Skip to content

Lint test#104

Closed
brianteeman wants to merge 427 commits intosxm26from
lint_test
Closed

Lint test#104
brianteeman wants to merge 427 commits intosxm26from
lint_test

Conversation

@brianteeman
Copy link
Copy Markdown
Owner

Pull Request for Issue # .

Summary of Changes

Testing Instructions

Expected result

Actual result

Documentation Changes Required

SharkyKZ and others added 30 commits January 16, 2020 12:26
Alternative to joomla#27489
This requires no template overrides at all
Co-authored-by: Harald Leithner <leithner@itronic.at>
Co-authored-by: infograf768 <infografjms@gmail.com>
Co-authored-by: Quy <quy@fluxbb.org>
* [4.0] [Cassiopeia] Remove header SVG curve

* change banner pos style to html5

* color white

* give p tag back it's margin

Co-authored-by: infograf768 <infografjms@gmail.com>
This PR corrects lots of different errors in the table for assigning modules to your menu item.

Removes ID from table cells
Adds caption to table
Adds ID to table
Adds scope to cols and rows
Moves column width style from every cell in every row to just the thead
Removes the inline style text-center from every cell in every row - text should be left aligned in columns
Because of changes in the tinymce mobile experience we have to disable the toggle editor button on a mobile device. Otherwise it floats on top of the editor.
bembelimen and others added 27 commits February 9, 2020 05:49
The child count of items is using a definition list. This is completely the wrong markup to use as a number is not the description of the term in this use.

This PR changes it to a span **exactly** the same as every other use of show_cat_items
This adds a layout for items to remove duplicate code.
Fix page navigation links by fixing query to join on the workflow stages table correctly.
…a#24329)

Since the introduction of the categoryedit form field in the edit 
models/views of com_content, com_contact, com_newsfeeds and com_banners 
(d6673d7), there is no `action` attribute on the `catid` form field and 
thus no need to set it anymore.
Faster login
Solves stutter bug joomla#25904
Solves internet explorer bug joomla#26005
* Namespace Content - Confirm Consent plugin

* Revert

* Move addfieldprefix to form

* Update file list in manifest

* Align
* Allow empty metakey values in database tables

* Remove meta from keywords in comments

* Use null instead empty string for empty metakey

* Roll back unnecessary change for categories

* For tags do like for categories because varchar not null in past
Codemirror was locked at a specific version that is now very old.

This PR changes the setting in package.json so that it follows semver

Codemirror has always been very good at following semver so this should be totally safe.

(the update process also updated tinymce at the same time)
* [4.0] Main menu add new shortcuts

The admin menu module has options to show/hide the "add new" shortcuts on the menu. This option was not working. It is now

* Update administrator/modules/mod_menu/tmpl/default_submenu.php

Co-Authored-By: Quy <quy@fluxbb.org>

Co-authored-by: Quy <quy@fluxbb.org>
* Move component specific presets to component folder

* Move preset language strings from lib to components

* Dynamically load presets from component folders instead of using hardcoded list.

* Name of preset is without ".xml"

* Move language strings use din presets to respective component
* [4.0] Internet Explorer message

Although you can kind of use the admin with IE it is not supported and will not work 100%. This PR uses css to detect if you are using ie10 or 11 and displays a warning if you are.

To test `npm i` or `node build.js --compile.css`

Make sure that you do not see a message with your normal browser
If you have access to IE10 or 11 then make sure you do see a message

* typo

* important

* cs

* Update joomla.ini

* Update administrator/templates/atum/scss/blocks/_login.scss

Co-Authored-By: Quy <quy@fluxbb.org>

Co-authored-by: Quy <quy@fluxbb.org>
* Adding frontend edit for com_contact

* Revert change in package-lock.json

* Removing description strings

* Adding newline character at end of file (CS)

* Prevent changing language in frontend when item is already associated.

* Adding type hint for preprocessform so it's similar to parent function.

* Redirect to previos page on cancel

* addfieldpath doesn't work anymore in 4.0

* Adjusting to template changes

* Removing tabstate as it is no longer available.

* Codestyle

* wip

* Import the RouteHelper

* cs

* Taking care of changes regarding FontAwesome Icons

* Update administrator/components/com_contact/Service/HTML/Icon.php

Co-Authored-By: Richard Fath <richard67@users.noreply.github.com>

* Update components/com_contact/Controller/ContactController.php

Co-Authored-By: Richard Fath <richard67@users.noreply.github.com>

* Update components/com_contact/View/Form/HtmlView.php

Co-Authored-By: Richard Fath <richard67@users.noreply.github.com>

* Update components/com_contact/View/Form/HtmlView.php

Co-Authored-By: Richard Fath <richard67@users.noreply.github.com>

* Update components/com_contact/tmpl/category/default_items.php

Co-Authored-By: Richard Fath <richard67@users.noreply.github.com>

* Update components/com_contact/tmpl/contact/default.php

Co-Authored-By: Richard Fath <richard67@users.noreply.github.com>

* Update administrator/components/com_contact/Service/HTML/Icon.php

Co-Authored-By: Richard Fath <richard67@users.noreply.github.com>

* Update administrator/components/com_contact/Service/HTML/Icon.php

Co-Authored-By: Richard Fath <richard67@users.noreply.github.com>

* Update administrator/components/com_contact/Service/HTML/Icon.php

Co-Authored-By: Richard Fath <richard67@users.noreply.github.com>

* Update administrator/components/com_contact/Extension/ContactComponent.php

Co-Authored-By: Richard Fath <richard67@users.noreply.github.com>

* Correct publish up and down check

* PHPCS

Co-authored-by: Quy <quy@fluxbb.org>
Co-authored-by: Astrid  <astridx@users.noreply.github.com>
Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
* Use layout to set layout

* Update forms

* Set layout

* Cleanup

* Double label workaround

* Update newly added fields

* Remove extra quote

* Update forms

Co-authored-by: Quy <quy@fluxbb.org>
@brianteeman brianteeman deleted the lint_test branch February 11, 2020 13:54
brianteeman pushed a commit that referenced this pull request May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.