Merged
Conversation
Although you can kind of use the admin with IE it is not supported and will not work 100%. This PR uses css to detect if you are using ie10 or 11 and displays a warning if you are. To test `npm i` or `node build.js --compile.css` Make sure that you do not see a message with your normal browser If you have access to IE10 or 11 then make sure you do see a message
C-Lodder
reviewed
Feb 10, 2020
C-Lodder
reviewed
Feb 10, 2020
ciar4n
reviewed
Feb 10, 2020
Quy
reviewed
Feb 10, 2020
Member
|
I have tested this item ✅ successfully on 2c82c3d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27879. |
Co-Authored-By: Quy <quy@fluxbb.org>
Contributor
|
I have tested this item ✅ successfully on b2bd0ea This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27879. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27879. |
Member
|
Setting back to pending. Missing 1 more test before moving to commit changes. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27879. |
Contributor
|
It is only coding style change that does not affect test results. |
Member
|
@Quy @brianteeman That detail needs to be called out in testing. The notes do not indicate this and will only cause confusion and problems for Testers. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27879. |
Contributor
|
I have tested this item ✅ successfully on b2bd0ea This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27879. |
Contributor
Author
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although you can kind of use the admin with IE it is not supported and will not work 100%. This PR uses css to detect if you are using ie10 or 11 and displays a warning if you are. (hopefully this will save us from numerous reports that something doesn't work)
To test
npm iornode build.js --compile.cssMake sure that you do not see a message with your normal browser
If you have access to IE10 or 11 then make sure you do see a message
Expected result on IE