Skip to content

[4.0] tooltip text alignment#27554

Merged
wilsonge merged 3 commits intojoomla:4.0-devfrom
brianteeman:ttft1
Jan 18, 2020
Merged

[4.0] tooltip text alignment#27554
wilsonge merged 3 commits intojoomla:4.0-devfrom
brianteeman:ttft1

Conversation

@brianteeman
Copy link
Copy Markdown
Contributor

@brianteeman brianteeman commented Jan 17, 2020

Simple PR adds clarity and improves readability

dont forget npm i

example on smart search

before

image

after

image

@brianteeman
[4.0] tooltip text alignment
f792bff 
Simple PR adds clarity and improves readability
@ciar4n
Copy link
Copy Markdown
Contributor

ciar4n commented Jan 17, 2020

I have tested this item ✅ successfully on f792bff

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27554.

1 similar comment
@jwaisner
Copy link
Copy Markdown
Member

jwaisner commented Jan 17, 2020

I have tested this item ✅ successfully on f792bff

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27554.

@SharkyKZ
Copy link
Copy Markdown
Contributor

SharkyKZ commented Jan 17, 2020

RTC.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27554.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 17, 2020
@Quy
Copy link
Copy Markdown
Contributor

Quy commented Jan 17, 2020

For RTL, it should be right-aligned.

@infograf768 infograf768 removed the RTC This Pull Request is Ready To Commit label Jan 17, 2020
@infograf768
Copy link
Copy Markdown
Member

infograf768 commented Jan 17, 2020

Back to pending until rtl is taken care of to avoid another pr for mini stuff

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27554.

@infograf768
Copy link
Copy Markdown
Member

infograf768 commented Jan 18, 2020

Suggestion:

[...]
  z-index: $zindex-tooltip;

  [dir=ltr] & {
    text-align: left;
  }
  
  [dir=rtl] & {
    text-align: right;
  }

@infograf768 infograf768 mentioned this pull request Jan 18, 2020
Merged
@brianteeman
Copy link
Copy Markdown
Contributor Author

brianteeman commented Jan 18, 2020 •
edited
Loading

Thanks. I will update soon

@brianteeman
Copy link
Copy Markdown
Contributor Author

brianteeman commented Jan 18, 2020

updated for rtl

@infograf768
Copy link
Copy Markdown
Member

infograf768 commented Jan 18, 2020

As change is obvious, setting rtc

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27554.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 18, 2020
infograf768
infograf768 reviewed Jan 18, 2020
View reviewed changes
@brianteeman
Copy link
Copy Markdown
Contributor Author

brianteeman commented Jan 18, 2020

Done it - its hard to check this sort of thing from my phone

@wilsonge wilsonge merged commit 6480354 into joomla:4.0-dev Jan 18, 2020
@wilsonge
Copy link
Copy Markdown
Contributor

wilsonge commented Jan 18, 2020

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 18, 2020
@wilsonge wilsonge added this to the Joomla 4.0 milestone Jan 18, 2020
@brianteeman
Copy link
Copy Markdown
Contributor Author

brianteeman commented Jan 18, 2020

Thanks

@brianteeman brianteeman deleted the ttft1 branch January 18, 2020 16:01
brianteeman added a commit to brianteeman/joomla-cms that referenced this pull request Feb 4, 2020
@brianteeman
[4.0] tooltip text alignment (joomla#27554)
cd439da
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@infograf768 infograf768 infograf768 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Joomla 4.0

Development

Successfully merging this pull request may close these issues.

8 participants

@brianteeman @ciar4n @jwaisner @SharkyKZ @Quy @infograf768 @wilsonge @joomla-cms-bot