[4.0] Load Bootstrap JS in some modules#27585
Merged
wilsonge merged 4 commits intojoomla:4.0-devfrom Jan 21, 2020
SharkyKZ:j4/admin-modules-bs
Merged
[4.0] Load Bootstrap JS in some modules#27585wilsonge merged 4 commits intojoomla:4.0-devfrom SharkyKZ:j4/admin-modules-bs
wilsonge merged 4 commits intojoomla:4.0-devfrom
SharkyKZ:j4/admin-modules-bs
Conversation
Contributor
|
Wouldnt it be better to remove the bootstrap dropdowns from those pages? |
Contributor
Author
|
No. |
added 2 commits
January 21, 2020 10:37
…mla-cms into j4/admin-modules-bs
Contributor
|
@brianteeman I'm not too fussed about removing bootstrap from the backend pages. If you want to do a PR though I'm happy to treat it with an open mind. This is more than fine in the short term |
Contributor
|
Thanks! |
brianteeman
pushed a commit
to brianteeman/joomla-cms
that referenced
this pull request
Feb 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Loads Bootstrap JS in some modules that use BS dropdowns.
Testing Instructions
Cause an error in administrator. E.g. modify
administrator/templates/atum/index.phpto have a syntax error.In Joomla error page click
User MenuorPost-Installation Messagesat the top bar.Expected result
Dropdown opens.
Actual result
Nothing happens.
Documentation Changes Required
No.