[4.0] WebAsset correct user.css dependencies and sorting#27872
Merged
wilsonge merged 3 commits intojoomla:4.0-devfrom Feb 9, 2020
Merged
[4.0] WebAsset correct user.css dependencies and sorting#27872wilsonge merged 3 commits intojoomla:4.0-devfrom
wilsonge merged 3 commits intojoomla:4.0-devfrom
Conversation
Contributor
|
I have tested this item ✅ successfully on ffa3f8e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27872. |
1 similar comment
Member
|
I have tested this item ✅ successfully on ffa3f8e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27872. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27872. |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #27867
Summary of Changes
I have corrected dependencies for user.css asset, they was missed, that lead to incorrect sorting.
And made a little improvement for sorting.
Testing Instructions
Please have a look #27867 for detail.
Create
user.cssand make sure the order is correct.Do the test for both Atum and Cassiopeia.
Also repeat the test for
user.jsfor Cassiopeia template