Merged
Conversation
The child count of items is using a definition list. This is completely the wrong markup to use as a number is not the description of the term in this use. This PR changes it to a span **exactly** the same as every other use of show_cat_items
Contributor
|
I have tested this item ✅ successfully on 6e97fd3 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27825. |
Member
|
@brianteeman I've tried to test but I did not get the questionable markup (before applying the PR of course). What am I doing wrong? Was checking the category view for newsfeeds category after having installed testing sample data and switched on all show this or that options in the component settings. |
Contributor
Author
|
as it is in the child you need to make sure you add a subcategory and create a feed in that subcategory |
Member
|
Thanks, will try soon. |
Member
|
I have tested this item ✅ successfully on 6e97fd3 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27825. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27825. |
Contributor
Author
|
thx |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The child count of items is using a definition list. This is completely the wrong markup to use as a number is not the description of the term in this use.
This PR changes it to a span exactly the same as every other use of show_cat_items